Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-34000

query_response_time.session_toggle fails sporadically in buildbot with wrong result

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Critical
    • Resolution: Fixed
    • N/A
    • 11.5.1
    • Plugins, Tests
    • None

    Description

      The new test query_response_time.session_toggle, added in the scope of MDEV-33501, already failed several times in buildbot. The failure is odd; while there may be some q the test, I don't see how it could be failing this particular way, so maybe there is a deeper issue than just non-deterministic test logic.

      The failures so far happened in two places (line numbers of e.g. 811825a36):

      @@ -106,7 +106,7 @@
       1
       SELECT SUM(COUNT) FROM INFORMATION_SCHEMA.QUERY_RESPONSE_TIME;
       SUM(COUNT)
      -17
      +18
       connection con3;
       # 3rd connection: global ON: session: OFF: must not be logged
       SELECT sleep(1)+1 as '1';
      @@ -114,7 +114,7 @@
       1
       SELECT SUM(COUNT) FROM INFORMATION_SCHEMA.QUERY_RESPONSE_TIME;
       SUM(COUNT)
      -18
      +19
       disconnect con2;
       disconnect con3;
       connection default;
      

      The fragment of the test/result preceding the wrong result is this:

      connection default;
      # 1st connection: global ON, session: ON: must be logged
      SET GLOBAL query_response_time_stats= 'ON';
      SELECT 1;
      1
      1
      SELECT SUM(COUNT) FROM INFORMATION_SCHEMA.QUERY_RESPONSE_TIME;
      SUM(COUNT)
      15
      connection con2;
      # 2nd connection: global ON, session: default(GLOBAL): must be logged
      SELECT sleep(1)+1 as '1';
      1
      1
      SELECT SUM(COUNT) FROM INFORMATION_SCHEMA.QUERY_RESPONSE_TIME;
      SUM(COUNT)
      17
      

      So, the previous SELECT SUM works okay and returns 15 as it's supposed to. Then there are only 2 queries, SELECT sleep and another SELECT SUM, without visible concurrency, so the result is expected to be 17, but sometimes it just happens to be 18. I don't see where the extra query may come from.

      The other failure is

      @@ -98,7 +98,7 @@
       1
       SELECT SUM(COUNT) FROM INFORMATION_SCHEMA.QUERY_RESPONSE_TIME;
       SUM(COUNT)
      -15
      +16
       connection con2;
       # 2nd connection: global ON, session: default(GLOBAL): must be logged
       SELECT sleep(1)+1 as '1';
      @@ -106,7 +106,7 @@
       1
       SELECT SUM(COUNT) FROM INFORMATION_SCHEMA.QUERY_RESPONSE_TIME;
       SUM(COUNT)
      -17
      +18
       connection con3;
       # 3rd connection: global ON: session: OFF: must not be logged
       SELECT sleep(1)+1 as '1';
      @@ -114,7 +114,7 @@
       1
       SELECT SUM(COUNT) FROM INFORMATION_SCHEMA.QUERY_RESPONSE_TIME;
       SUM(COUNT)
      -18
      +19
       disconnect con2;
       disconnect con3;
       connection default;
      

      https://buildbot.mariadb.org/#/builders/534/builds/16693
      https://buildbot.mariadb.org/#/builders/369/builds/19973

      Attachments

        Issue Links

          Activity

            People

              monty Michael Widenius
              elenst Elena Stepanova
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.