Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-33627

Add option --dir to mariadb-import

Details

    Description

      For symmetry with mariadb-dump , add option --dir to mariadb-import.

      also add --all-databases, --databases options that work together with --dir , to provide full or partial restore capabilities.

      Mode of operation - for matching databases or tables, mariadb-import will execute <table>.sql script, to create or recreate tables, then load the data from *.txt file.

      databases will be created, if they do not exist.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-34741 mariadb-import occasionally fails with "Table 'child' was not locked"

          • Major - Major loss of function.
          • Open
          split from

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. MDEV-33188 Enhance mariadb-dump and mariadb-import capabilities similar to MyDumper

          • Critical - Crashes, loss of data, severe memory leak.
          • Stalled

          Activity

            Ascending order - Click to sort in descending order
            sanja Oleksandr Byelkin added a comment -

            OK is OK, but remove changing only empty lines without changing something near by

            sanja Oleksandr Byelkin added a comment - OK is OK, but remove changing only empty lines without changing something near by
            lstartseva Lena Startseva added a comment - - edited

            Testing finished.
            Everything is Ok, if dump was made with options " - - dir". But in the description of commit there is an information that it also works for dump with "- - tab". When dump is creating with "- - dir" the path with results contains database name (<dump_path>/<database_name>). When dump is creating with "--tab" the path with results does NOT contain database name (<dump_path>), so for correct work of import the name of database must be add in the path. I guess this information should somehow be reflected in the description so that the user does not have questions.
            Also, I saw in the tests that "mariadb-import" can be run with option "- - parallel", but this option does not work now. But "The files are loaded in descending order by datafile size" - yes, this part works.

            Summing up: Based on the task description, everything works, and this part of the implementation can be pushed

            lstartseva Lena Startseva added a comment - - edited Testing finished. Everything is Ok, if dump was made with options " - - dir". But in the description of commit there is an information that it also works for dump with "- - tab". When dump is creating with "- - dir" the path with results contains database name (<dump_path>/<database_name>). When dump is creating with "--tab" the path with results does NOT contain database name (<dump_path>), so for correct work of import the name of database must be add in the path. I guess this information should somehow be reflected in the description so that the user does not have questions. Also, I saw in the tests that "mariadb-import" can be run with option "- - parallel", but this option does not work now. But "The files are loaded in descending order by datafile size" - yes, this part works. Summing up: Based on the task description, everything works, and this part of the implementation can be pushed

            People

              wlad Vladislav Vaintroub
              wlad Vladislav Vaintroub
              Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.