Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-33581

Modern versions of MariaDB no longer build on OpenBSD

Details

    Description

      MariaDB beyond 10.10 no longer build on OpenBSD.

      /home/ports/pobj/mariadb-10.11.7/mariadb-10.11.7/extra/mariabackup/xtrabackup.cc:2431:39: error: use of undeclared identifier 'OS_DATA_FILE_NO_O_DIRECT'
      		 
                                            OS_DATA_FILE_NO_O_DIRECT, false, &ret);
      		 
                                            ^

      https://github.com/MariaDB/server/pull/3002

      This pull request seems to be where the breakage was introduced.

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. MDBF-655 Add OpenBSD builder to buildbot

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. MDEV-33095 innodb_flush_method=O_DIRECT creates excessive errors on Solaris

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-33379 innodb_log_file_buffering=OFF causes corruption on bcachefs

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            danblack Daniel Black added a comment -

            Sorry brad0, fixed - https://github.com/MariaDB/server/pull/3039, but not quite in time for release.

            danblack Daniel Black added a comment - Sorry brad0 , fixed - https://github.com/MariaDB/server/pull/3039 , but not quite in time for release.
            brad0 Brad Smith added a comment -

            I noticed that PR was only for xtrabackup. I was testing other versions and noticed the same root issue but with other files.

            /home/ports/pobj/mariadb-11.2.3/mariadb-11.2.3/storage/innobase/fil/fil0fil.cc:1415:15: error: use of undeclared identifier 'OS_DATA_FILE_NO_O_DIRECT'
            		 
                    type= OS_DATA_FILE_NO_O_DIRECT;
            		 
                          ^

            brad0 Brad Smith added a comment - I noticed that PR was only for xtrabackup. I was testing other versions and noticed the same root issue but with other files. /home/ports/pobj/mariadb-11.2.3/mariadb-11.2.3/storage/innobase/fil/fil0fil.cc:1415:15: error: use of undeclared identifier 'OS_DATA_FILE_NO_O_DIRECT' type= OS_DATA_FILE_NO_O_DIRECT; ^
            brad0 Brad Smith added a comment -

            Looking at further commits to the branch it looks like this has been resolved. I'll wait for the next set of releases.

            brad0 Brad Smith added a comment - Looking at further commits to the branch it looks like this has been resolved. I'll wait for the next set of releases.
            serg Sergei Golubchik added a comment -

            brad0, just FYI, we've created MDBF-655 so that it wouldn't keep happening over and over.

            serg Sergei Golubchik added a comment - brad0 , just FYI, we've created MDBF-655 so that it wouldn't keep happening over and over.
            brad0 Brad Smith added a comment -

            Ok, great. Thanks.

            brad0 Brad Smith added a comment - Ok, great. Thanks.
            marko Marko Mäkelä added a comment -

            The code was last refactored in MDEV-33379. We already had another experimental builder where O_DIRECT is not available: macOS.

            marko Marko Mäkelä added a comment - The code was last refactored in MDEV-33379 . We already had another experimental builder where O_DIRECT is not available: macOS.

            People

              Unassigned Unassigned
              brad0 Brad Smith
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.