Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-33500

rpl.rpl_parallel_sbm can fail on slow machines, e.g. MSAN/Valgrind builders

Details

    Description

      In an addition to test rpl.rpl_parallel_sbm added by MDEV-32265, the test uses sleep statements alone to test Seconds_Behind_Master with delayed replication. On slow running machines, the test can pass the intended MASTER_DELAY duration and Seconds_Behind_Master can become 0, when the test expects the transaction to still be actively in a delaying state.

      The test failure resembles the following: 

      rpl.rpl_parallel_sbm 'mix'               w20 [ fail ]
      		 
              Test ended at 2024-02-20 10:27:35
      		 
      CURRENT_TEST: rpl.rpl_parallel_sbm
      		 
      mysqltest: At line 85: Seconds_Behind_Master did not increase after sleeping, but should have

      And the following patch reproduces this consistently

      diff --git a/mysql-test/suite/rpl/t/rpl_parallel_sbm.test b/mysql-test/suite/rpl/t/rpl_parallel_sbm.test
      		 
      index 58c0db15e47..5baf6a56487 100644
      		 
      --- a/mysql-test/suite/rpl/t/rpl_parallel_sbm.test
      		 
      +++ b/mysql-test/suite/rpl/t/rpl_parallel_sbm.test
      		 
      @@ -77,6 +77,10 @@ if (`SELECT $sbm_trx1_arrive > ($seconds_since_idling + 1)`)
      		 
       --echo # Sleeping 1s to increment SBM
      		 
       sleep 1;
      		 
       
      +--disable_query_log
      		 
      +sleep 4;
      		 
      +--enable_query_log
      		 
      +
      		 
       --echo # Ensuring Seconds_Behind_Master increases after sleeping..
      		 
       --let $sbm_trx1_after_1s_sleep= query_get_value(SHOW SLAVE STATUS, Seconds_Behind_Master, 1)
      		 
       if (`SELECT $sbm_trx1_after_1s_sleep <= $sbm_trx1_arrive`)

      Attachments

        Issue Links

          is caused by

          Bug - A problem which impairs or prevents the functions of the product. MDEV-32265 seconds_behind_master is inaccurate for Delayed replication

          • Major - Major loss of function.
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. MDEV-33499 rpl.rpl_parallel_sbm can fail on slow machines, e.g. MSAN/Valgrind builders

          • Major - Major loss of function.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-35858 rpl.rpl_parallel_sbm: Slave_last_event_time is not equal to Master_last_event_time

          • Major - Major loss of function.
          • Open

          Activity

            Ascending order - Click to sort in descending order
            bnestere Brandon Nesterenko created issue -
            bnestere Brandon Nesterenko made changes -
            Field Original Value New Value
            bnestere Brandon Nesterenko made changes -
            bnestere Brandon Nesterenko made changes -
            Description In an addition to test rpl.rpl_parallel_sbm added by MDEV-32265, the test uses sleep statements alone to test Seconds_Behind_Master with delayed replication. On slow running machines, the test can pass the intended MASTER_DELAY duration and Seconds_Behind_Master can become 0, when the test expects the transaction to still be actively in a delaying state. In an addition to test rpl.rpl_parallel_sbm added by MDEV-32265, the test uses sleep statements alone to test Seconds_Behind_Master with delayed replication. On slow running machines, the test can pass the intended MASTER_DELAY duration and Seconds_Behind_Master can become 0, when the test expects the transaction to still be actively in a delaying state.

            The test failure resembles the following:
            {noformat}
            rpl.rpl_parallel_sbm 'mix' w20 [ fail ]
                    Test ended at 2024-02-20 10:27:35
            CURRENT_TEST: rpl.rpl_parallel_sbm
            mysqltest: At line 85: Seconds_Behind_Master did not increase after sleeping, but should have
            {noformat}

            And the following patch reproduces this consistently
            {noformat}
            diff --git a/mysql-test/suite/rpl/t/rpl_parallel_sbm.test b/mysql-test/suite/rpl/t/rpl_parallel_sbm.test
            index 58c0db15e47..5baf6a56487 100644
            --- a/mysql-test/suite/rpl/t/rpl_parallel_sbm.test
            +++ b/mysql-test/suite/rpl/t/rpl_parallel_sbm.test
            @@ -77,6 +77,10 @@ if (`SELECT $sbm_trx1_arrive > ($seconds_since_idling + 1)`)
             --echo # Sleeping 1s to increment SBM
             sleep 1;
             
            +--disable_query_log
            +sleep 4;
            +--enable_query_log
            +
             --echo # Ensuring Seconds_Behind_Master increases after sleeping..
             --let $sbm_trx1_after_1s_sleep= query_get_value(SHOW SLAVE STATUS, Seconds_Behind_Master, 1)
             if (`SELECT $sbm_trx1_after_1s_sleep <= $sbm_trx1_arrive`)
            {noformat}
            bnestere Brandon Nesterenko made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            bnestere Brandon Nesterenko made changes -
            issue.field.resolutiondate 2024-02-20 16:48:23.0 2024-02-20 16:48:23.452
            bnestere Brandon Nesterenko made changes -
            Fix Version/s 10.5.25 [ 29626 ]
            Fix Version/s 10.5 [ 23123 ]
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Closed [ 6 ]
            JIraAutomate JiraAutomate made changes -
            Fix Version/s 10.6.18 [ 29627 ]
            Fix Version/s 10.11.8 [ 29630 ]
            Fix Version/s 11.0.6 [ 29628 ]
            Fix Version/s 11.1.5 [ 29629 ]
            Fix Version/s 11.2.4 [ 29631 ]
            bnestere Brandon Nesterenko made changes -
            Resolution Fixed [ 1 ]
            Status Closed [ 6 ] Stalled [ 10000 ]
            bnestere Brandon Nesterenko made changes -
            Assignee Brandon Nesterenko [ JIRAUSER48702 ] Andrei Elkin [ elkin ]
            Status Stalled [ 10000 ] In Review [ 10002 ]
            Elkin Andrei Elkin made changes -
            Assignee Andrei Elkin [ elkin ] Brandon Nesterenko [ JIRAUSER48702 ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            julien.fritsch Julien Fritsch made changes -
            Fix Version/s 10.5 [ 23123 ]
            Fix Version/s 10.6 [ 24028 ]
            Fix Version/s 10.11 [ 27614 ]
            Fix Version/s 11.2 [ 28603 ]
            Fix Version/s 10.5.25 [ 29626 ]
            Fix Version/s 10.6.18 [ 29627 ]
            Fix Version/s 11.0.6 [ 29628 ]
            Fix Version/s 11.1.5 [ 29629 ]
            Fix Version/s 10.11.8 [ 29630 ]
            Fix Version/s 11.2.4 [ 29631 ]
            bnestere Brandon Nesterenko made changes -
            issue.field.resolutiondate 2024-09-17 14:52:03.0 2024-09-17 14:52:02.695
            bnestere Brandon Nesterenko made changes -
            Fix Version/s 10.5.27 [ 29902 ]
            Fix Version/s 10.5 [ 23123 ]
            Fix Version/s 10.6 [ 24028 ]
            Fix Version/s 10.11 [ 27614 ]
            Fix Version/s 11.2 [ 28603 ]
            Resolution Fixed [ 1 ]
            Status Stalled [ 10000 ] Closed [ 6 ]
            JIraAutomate JiraAutomate made changes -
            Fix Version/s 10.6.20 [ 29903 ]
            Fix Version/s 10.11.10 [ 29904 ]
            Fix Version/s 11.2.6 [ 29906 ]
            Fix Version/s 11.4.4 [ 29907 ]
            bnestere Brandon Nesterenko made changes -

            People

              bnestere Brandon Nesterenko
              bnestere Brandon Nesterenko
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.