Details
-
Bug
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
10.5, 10.6, 10.11, 11.0(EOL), 11.1(EOL), 11.2(EOL), 11.3(EOL)
-
None
Description
In an addition to test rpl.rpl_parallel_sbm added by MDEV-32265, the test uses sleep statements alone to test Seconds_Behind_Master with delayed replication. On slow running machines, the test can pass the intended MASTER_DELAY duration and Seconds_Behind_Master can become 0, when the test expects the transaction to still be actively in a delaying state.
The test failure resembles the following:
rpl.rpl_parallel_sbm 'mix' w20 [ fail ]
|
Test ended at 2024-02-20 10:27:35
|
CURRENT_TEST: rpl.rpl_parallel_sbm
|
mysqltest: At line 85: Seconds_Behind_Master did not increase after sleeping, but should have
|
And the following patch reproduces this consistently
diff --git a/mysql-test/suite/rpl/t/rpl_parallel_sbm.test b/mysql-test/suite/rpl/t/rpl_parallel_sbm.test
|
index 58c0db15e47..5baf6a56487 100644
|
--- a/mysql-test/suite/rpl/t/rpl_parallel_sbm.test
|
+++ b/mysql-test/suite/rpl/t/rpl_parallel_sbm.test
|
@@ -77,6 +77,10 @@ if (`SELECT $sbm_trx1_arrive > ($seconds_since_idling + 1)`)
|
--echo # Sleeping 1s to increment SBM
|
sleep 1;
|
|
+--disable_query_log
|
+sleep 4;
|
+--enable_query_log
|
+
|
--echo # Ensuring Seconds_Behind_Master increases after sleeping..
|
--let $sbm_trx1_after_1s_sleep= query_get_value(SHOW SLAVE STATUS, Seconds_Behind_Master, 1)
|
if (`SELECT $sbm_trx1_after_1s_sleep <= $sbm_trx1_arrive`)
|
Attachments
Issue Links
- is caused by
-
-
- Closed
-
- is duplicated by
-
-
- Closed
-
- relates to
-
-
- Open
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Link |
This issue is caused by |
| Link |
This issue is duplicated by |
| Description |
In an addition to test rpl.rpl_parallel_sbm added by |
In an addition to test rpl.rpl_parallel_sbm added by The test failure resembles the following: {noformat} rpl.rpl_parallel_sbm 'mix' w20 [ fail ] Test ended at 2024-02-20 10:27:35 CURRENT_TEST: rpl.rpl_parallel_sbm mysqltest: At line 85: Seconds_Behind_Master did not increase after sleeping, but should have {noformat} And the following patch reproduces this consistently {noformat} diff --git a/mysql-test/suite/rpl/t/rpl_parallel_sbm.test b/mysql-test/suite/rpl/t/rpl_parallel_sbm.test index 58c0db15e47..5baf6a56487 100644 --- a/mysql-test/suite/rpl/t/rpl_parallel_sbm.test +++ b/mysql-test/suite/rpl/t/rpl_parallel_sbm.test @@ -77,6 +77,10 @@ if (`SELECT $sbm_trx1_arrive > ($seconds_since_idling + 1)`) --echo # Sleeping 1s to increment SBM sleep 1; +--disable_query_log +sleep 4; +--enable_query_log + --echo # Ensuring Seconds_Behind_Master increases after sleeping.. --let $sbm_trx1_after_1s_sleep= query_get_value(SHOW SLAVE STATUS, Seconds_Behind_Master, 1) if (`SELECT $sbm_trx1_after_1s_sleep <= $sbm_trx1_arrive`) {noformat} |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| issue.field.resolutiondate | 2024-02-20 16:48:23.0 | 2024-02-20 16:48:23.452 |
| Fix Version/s | 10.5.25 [ 29626 ] | |
| Fix Version/s | 10.5 [ 23123 ] | |
| Resolution | Fixed [ 1 ] | |
| Status | In Progress [ 3 ] | Closed [ 6 ] |
| Fix Version/s | 10.6.18 [ 29627 ] | |
| Fix Version/s | 10.11.8 [ 29630 ] | |
| Fix Version/s | 11.0.6 [ 29628 ] | |
| Fix Version/s | 11.1.5 [ 29629 ] | |
| Fix Version/s | 11.2.4 [ 29631 ] |
Reopening, as marko noted on MDEV-33499 that this test can still fail.
rpl.rpl_parallel_sbm 'mix' w24 [ fail ]
|
Test ended at 2024-09-06 11:43:50
|
|
|
CURRENT_TEST: rpl.rpl_parallel_sbm
|
mysqltest: At line 92: Seconds_Behind_Master did not increase after sleeping, but should have
|
|
|
The result from queries just before the failure was:
|
< snip >
|
# Lock t1 on slave to ensure the event can't finish (and thereby update
|
# Seconds_Behind_Master) so slow running servers don't accidentally
|
# catch up to the master before checking SBM.
|
connection server_2;
|
LOCK TABLES t1 WRITE;
|
include/start_slave.inc
|
connection slave;
|
# Waiting for replica to get blocked by the table lock
|
Timeout in wait_condition.inc for SELECT count(*) FROM information_schema.processlist WHERE state LIKE 'Waiting for table metadata lock';
|
Id User Host db Command Time State Info Progress
|
5 root localhost:51970 test Sleep 31 NULL 0.000
|
10 root localhost:51980 test Query 0 starting show full processlist 0.000
|
11 root localhost:51986 test Sleep 71 NULL 0.000
|
16 system user NULL Slave_IO 31 Waiting for master to send event NULL 0.000
|
18 system user NULL Slave_worker 31 Waiting for work from SQL thread NULL 0.000
|
19 system user NULL Slave_worker 31 Waiting for work from SQL thread NULL 0.000
|
17 system user NULL Slave_SQL 31 Slave has read all relay log; waiting for more updates NULL 0.000
|
# Sleeping 1s to increment SBM
|
# Ensuring Seconds_Behind_Master increas
|
| Resolution | Fixed [ 1 ] | |
| Status | Closed [ 6 ] | Stalled [ 10000 ] |
| Assignee | Brandon Nesterenko [ JIRAUSER48702 ] | Andrei Elkin [ elkin ] |
| Status | Stalled [ 10000 ] | In Review [ 10002 ] |
| Assignee | Andrei Elkin [ elkin ] | Brandon Nesterenko [ JIRAUSER48702 ] |
| Status | In Review [ 10002 ] | Stalled [ 10000 ] |
| Fix Version/s | 10.5 [ 23123 ] | |
| Fix Version/s | 10.6 [ 24028 ] | |
| Fix Version/s | 10.11 [ 27614 ] | |
| Fix Version/s | 11.2 [ 28603 ] | |
| Fix Version/s | 10.5.25 [ 29626 ] | |
| Fix Version/s | 10.6.18 [ 29627 ] | |
| Fix Version/s | 11.0.6 [ 29628 ] | |
| Fix Version/s | 11.1.5 [ 29629 ] | |
| Fix Version/s | 10.11.8 [ 29630 ] | |
| Fix Version/s | 11.2.4 [ 29631 ] |
Pushed second fix into 10.5 as 68938d2b424
There is a merge conflict in 11.4 with a fix in branch bb-11.4-MDEV-33500-v2-mergefix
| issue.field.resolutiondate | 2024-09-17 14:52:03.0 | 2024-09-17 14:52:02.695 |
| Fix Version/s | 10.5.27 [ 29902 ] | |
| Fix Version/s | 10.5 [ 23123 ] | |
| Fix Version/s | 10.6 [ 24028 ] | |
| Fix Version/s | 10.11 [ 27614 ] | |
| Fix Version/s | 11.2 [ 28603 ] | |
| Resolution | Fixed [ 1 ] | |
| Status | Stalled [ 10000 ] | Closed [ 6 ] |
| Fix Version/s | 10.6.20 [ 29903 ] | |
| Fix Version/s | 10.11.10 [ 29904 ] | |
| Fix Version/s | 11.2.6 [ 29906 ] | |
| Fix Version/s | 11.4.4 [ 29907 ] |
The second iteration of fixes needed additional fixes in 11.6 for rpl.rpl_parallel_sbm.
MDEV-33856 added a check for Master_Slave_time_diff in rpl.rpl_parallel_sbm in 11.6, which relied on a 3 second master_delay. The second iteration fix for MDEV-33500 (68938d2b42474a6ff1fced3b1495ec45de2f5c47) replaced the time based master_delay in rpl.rpl_parallel_sbm with debug_sync, thus removing the expected 3 seconds of execution time, triggering an assertion.
The 11.6 merge fixes the test by making the assertion consistent with the MDEV-33500 debug_sync master_delay changes, i.e. by removing the 3 second delay from the assertion calculation.
| Link | This issue relates to MDEV-35858 [ MDEV-35858 ] |
Pushed into in 10.5 as b04c8575