Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-33469

Server incorrectly describes known variables as UNKNOWN if invalid values are specified at startup

Details

    Description

      MariaDB gives a misleading error message if you specify an invalid value for a known system variable on the command line.

      Take innodb-log-file-size as an example variable:

      Known variable, legal value:

      $ sql/mariadbd ... --innodb-log-file-size=1000000
      		 
      ...
      		 
      2024-02-15 13:05:18 0 [Note] sql/mariadbd: ready for connections.

      Known variable, invalid values:

      $ sql/mariadbd ... --innodb-log-file-size=-123                             # <- Not legal because negative
      		 
      ...
      		 
      2024-02-15 13:06:25 0 [ERROR] sql/mariadbd: unknown variable 'innodb-log-file-size=-123'
      		 

      $ sql/mariadbd ... --innodb-log-file-size=999999999999999999999999999      # <- Not legal because it's too large
      		 
      ...
      		 
      2024-02-15 13:06:59 0 [ERROR] sql/mariadbd: unknown variable 'innodb-log-file-size=999999999999999999999999999'

      Solution

      Instead of reporting this as an "unknown variable", it should be reported as an "invalid value."
      The code that produces this misleading error message is at https://github.com/MariaDB/server/blob/e71aecfd308d6093fd693044253518a872994394/mysys/my_getopt.c#L389

      Attachments

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. MDEV-25386 MDEV-22219 Followup: small inconsistency in option handling

          • Major - Major loss of function.
          • Confirmed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-26923 MariaDB will abort server startup if it finds an invalid parameter, but won't check for other invalid params

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            dlenski Daniel Lenski (Inactive) created issue -
            dlenski Daniel Lenski (Inactive) made changes -
            Field Original Value New Value
            dlenski Daniel Lenski (Inactive) made changes -
            Description MariaDB gives a misleading error message if you specify an invalid value for a known system variable on the command line.

            Take {{innodb-log-file-size}} as an example variable:

            h1. Known variable, legal value:
            {noformat}$ sql/mariadbd ... --innodb-log-file-size=1000000
            ...
            2024-02-15 13:05:18 0 [Note] sql/mariadbd: ready for connections.{noformat}

            Known variable, invalid values:
            {noformat}$ sql/mariadbd ... --innodb-log-file-size=-123 # <- Not legal because negative
            ...
            2024-02-15 13:06:25 0 [ERROR] sql/mariadbd: unknown variable 'innodb-log-file-size=-123'{noformat}

            {noformat}$ sql/mariadbd ... --innodb-log-file-size=999999999999999999999999999 # <- Not legal because it's too large
            ...
            2024-02-15 13:06:59 0 [ERROR] sql/mariadbd: unknown variable 'innodb-log-file-size=999999999999999999999999999'{noformat}

            Instead of reporting this as an "unknown variable", it should be reported as an "invalid value."
            The code that produces this misleading error message is at https://github.com/MariaDB/server/blob/e71aecfd308d6093fd693044253518a872994394/mysys/my_getopt.c#L389             		MariaDB gives a misleading error message if you specify an invalid value for a known system variable on the command line.

            Take {{innodb-log-file-size}} as an example variable:

            h1. Known variable, legal value:
            {noformat}$ sql/mariadbd ... --innodb-log-file-size=1000000
            ...
            2024-02-15 13:05:18 0 [Note] sql/mariadbd: ready for connections.{noformat}

            h1. Known variable, invalid values:
            {noformat}$ sql/mariadbd ... --innodb-log-file-size=-123 # <- Not legal because negative
            ...
            2024-02-15 13:06:25 0 [ERROR] sql/mariadbd: unknown variable 'innodb-log-file-size=-123'{noformat}

            {noformat}$ sql/mariadbd ... --innodb-log-file-size=999999999999999999999999999 # <- Not legal because it's too large
            ...
            2024-02-15 13:06:59 0 [ERROR] sql/mariadbd: unknown variable 'innodb-log-file-size=999999999999999999999999999'{noformat}

            h1. Solution
            Instead of reporting this as an "unknown variable", it should be reported as an "invalid value."
            The code that produces this misleading error message is at https://github.com/MariaDB/server/blob/e71aecfd308d6093fd693044253518a872994394/mysys/my_getopt.c#L389
            dlenski Daniel Lenski (Inactive) made changes -
            Labels beginner-friendly
            tonychen Tony Chen made changes -
            tonychen Tony Chen made changes -
            tonychen Tony Chen made changes -
            TheLinuxJedi Andrew Hutchings (Inactive) made changes -
            Assignee Andrew Hutchings [ JIRAUSER52179 ]
            TheLinuxJedi Andrew Hutchings (Inactive) made changes -
            Fix Version/s 10.5.25 [ 29626 ]
            TheLinuxJedi Andrew Hutchings (Inactive) made changes -
            Fix Version/s 10.5 [ 23123 ]
            Fix Version/s 10.5.25 [ 29626 ]
            TheLinuxJedi Andrew Hutchings (Inactive) made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            TheLinuxJedi Andrew Hutchings (Inactive) made changes -
            Status In Progress [ 3 ] In Review [ 10002 ]
            danblack Daniel Black made changes -
            Component/s Server [ 13907 ]
            Fix Version/s 10.5.25 [ 29626 ]
            Fix Version/s 10.5 [ 23123 ]
            Resolution Fixed [ 1 ]
            Status In Review [ 10002 ] Closed [ 6 ]
            JIraAutomate JiraAutomate made changes -
            Fix Version/s 10.6.18 [ 29627 ]
            Fix Version/s 10.11.8 [ 29630 ]
            Fix Version/s 11.0.6 [ 29628 ]
            Fix Version/s 11.1.5 [ 29629 ]
            Fix Version/s 11.2.4 [ 29631 ]

            People

              TheLinuxJedi Andrew Hutchings (Inactive)
              dlenski Daniel Lenski (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.