Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-33469

Server incorrectly describes known variables as UNKNOWN if invalid values are specified at startup

Details

    Description

      MariaDB gives a misleading error message if you specify an invalid value for a known system variable on the command line.

      Take innodb-log-file-size as an example variable:

      Known variable, legal value:

      $ sql/mariadbd ... --innodb-log-file-size=1000000
      		 
      ...
      		 
      2024-02-15 13:05:18 0 [Note] sql/mariadbd: ready for connections.

      Known variable, invalid values:

      $ sql/mariadbd ... --innodb-log-file-size=-123                             # <- Not legal because negative
      		 
      ...
      		 
      2024-02-15 13:06:25 0 [ERROR] sql/mariadbd: unknown variable 'innodb-log-file-size=-123'
      		 

      $ sql/mariadbd ... --innodb-log-file-size=999999999999999999999999999      # <- Not legal because it's too large
      		 
      ...
      		 
      2024-02-15 13:06:59 0 [ERROR] sql/mariadbd: unknown variable 'innodb-log-file-size=999999999999999999999999999'

      Solution

      Instead of reporting this as an "unknown variable", it should be reported as an "invalid value."
      The code that produces this misleading error message is at https://github.com/MariaDB/server/blob/e71aecfd308d6093fd693044253518a872994394/mysys/my_getopt.c#L389

      Attachments

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. MDEV-25386 MDEV-22219 Followup: small inconsistency in option handling

          • Major - Major loss of function.
          • Confirmed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-26923 MariaDB will abort server startup if it finds an invalid parameter, but won't check for other invalid params

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            dlenski Daniel Lenski (Inactive) added a comment -

            There is one code path that specifically deals with incorrectly-specified values (https://github.com/MariaDB/server/blob/e71aecfd308d6093fd693044253518a872994394/mysys/my_getopt.c#L484-L487), but it's only for boolean-valued variables.

            dlenski Daniel Lenski (Inactive) added a comment - There is one code path that specifically deals with incorrectly-specified values ( https://github.com/MariaDB/server/blob/e71aecfd308d6093fd693044253518a872994394/mysys/my_getopt.c#L484-L487 ), but it's only for boolean-valued variables.
            danblack Daniel Black added a comment -

            10.6 changed negative (MDEV-22219)

            For 10.11 

            $  rlocal  --innodb-log-file-size=-123 
            rr: Saving execution to trace directory `/home/dan/.local/share/rr/mariadbd-85'.
            		 
            2024-02-16 13:21:22 0 [Note] Starting MariaDB 10.11.8-MariaDB source revision 64cce8d5bff353ce92284aa7fed8dc9d915b639f as process 880515
            		 
            2024-02-16 13:21:22 0 [ERROR] Incorrect unsigned value: '-123' for innodb-log-file-size
            		 
            2024-02-16 13:21:22 0 [Warning] option 'innodb-log-file-size': unsigned value 0 adjusted to 4194304
            		 
            2024-02-16 13:21:22 0 [ERROR] sql/mariadbd: Error while setting value '-123' to 'innodb-log-file-size'
            		 
            2024-02-16 13:21:22 0 [ERROR] Parsing options for plugin 'InnoDB' failed.
            		 
            2024-02-16 13:21:22 0 [Note] Plugin 'FEEDBACK' is disabled.
            		 
            2024-02-16 13:21:22 0 [ERROR] sql/mariadbd: unknown variable 'innodb-log-file-size=-123'
            		 
            2024-02-16 13:21:22 0 [ERROR] Aborting

            Bit messy I agree.

            In 10.11 is appears to be that the option isn't found explaining the message.

            10.11

            		 
            0x0000000000db98fa in findopt (optpat=0x7ffc7330c99a "innodb-log-file-size=", '9' <repeats 27 times>, length=20, opt_res=<optimized out>, ffname=<optimized out>)
            		 
                at /home/dan/repos/mariadb-server-10.11/mysys/my_getopt.c:975
            		 
            975	  if (count == 1)
            		 
            (rr) p count
            		 
            $10 = 0
            		 
            (rr) bt
            		 
            #0  0x0000000000db98fa in findopt (optpat=0x7ffc7330c99a "innodb-log-file-size=", '9' <repeats 27 times>, length=20, opt_res=<optimized out>, ffname=<optimized out>)
            		 
                at /home/dan/repos/mariadb-server-10.11/mysys/my_getopt.c:975
            		 
            #1  handle_options (argc=0x17889f0 <remaining_argc>, argv=0x17889f8 <remaining_argv>, longopts=0x7ffc73308ce0, 
                get_one_option=0x6568d0 <mysqld_get_one_option(my_option const*, char const*, char const*)>) at /home/dan/repos/mariadb-server-10.11/mysys/my_getopt.c:311
            		 
            #2  0x0000000000654056 in init_server_components () at /home/dan/repos/mariadb-server-10.11/sql/mysqld.cc:5354
            		 
            #3  0x0000000000650d13 in mysqld_main (argc=9, argv=0x37ddcf8) at /home/dan/repos/mariadb-server-10.11/sql/mysqld.cc:5856
            		 
            #4  0x00007fe5f444614a in __libc_start_call_main () from /lib64/libc.so.6
            		 
            #5  0x00007fe5f444620b in __libc_start_main_impl () from /lib64/libc.so.6
            		 
            #6  0x000000000064df05 in _start ()

            danblack Daniel Black added a comment - 10.6 changed negative ( MDEV-22219 ) For 10.11 $ rlocal --innodb-log-file-size=-123 rr: Saving execution to trace directory `/home/dan/.local/share/rr/mariadbd-85'. 2024-02-16 13:21:22 0 [Note] Starting MariaDB 10.11.8-MariaDB source revision 64cce8d5bff353ce92284aa7fed8dc9d915b639f as process 880515 2024-02-16 13:21:22 0 [ERROR] Incorrect unsigned value: '-123' for innodb-log-file-size 2024-02-16 13:21:22 0 [Warning] option 'innodb-log-file-size': unsigned value 0 adjusted to 4194304 2024-02-16 13:21:22 0 [ERROR] sql/mariadbd: Error while setting value '-123' to 'innodb-log-file-size' 2024-02-16 13:21:22 0 [ERROR] Parsing options for plugin 'InnoDB' failed. 2024-02-16 13:21:22 0 [Note] Plugin 'FEEDBACK' is disabled. 2024-02-16 13:21:22 0 [ERROR] sql/mariadbd: unknown variable 'innodb-log-file-size=-123' 2024-02-16 13:21:22 0 [ERROR] Aborting Bit messy I agree. In 10.11 is appears to be that the option isn't found explaining the message. 10.11 0x0000000000db98fa in findopt (optpat=0x7ffc7330c99a "innodb-log-file-size=", '9' <repeats 27 times>, length=20, opt_res=<optimized out>, ffname=<optimized out>) at /home/dan/repos/mariadb-server-10.11/mysys/my_getopt.c:975 975 if (count == 1) (rr) p count $10 = 0 (rr) bt #0 0x0000000000db98fa in findopt (optpat=0x7ffc7330c99a "innodb-log-file-size=", '9' <repeats 27 times>, length=20, opt_res=<optimized out>, ffname=<optimized out>) at /home/dan/repos/mariadb-server-10.11/mysys/my_getopt.c:975 #1 handle_options (argc=0x17889f0 <remaining_argc>, argv=0x17889f8 <remaining_argv>, longopts=0x7ffc73308ce0, get_one_option=0x6568d0 <mysqld_get_one_option(my_option const*, char const*, char const*)>) at /home/dan/repos/mariadb-server-10.11/mysys/my_getopt.c:311 #2 0x0000000000654056 in init_server_components () at /home/dan/repos/mariadb-server-10.11/sql/mysqld.cc:5354 #3 0x0000000000650d13 in mysqld_main (argc=9, argv=0x37ddcf8) at /home/dan/repos/mariadb-server-10.11/sql/mysqld.cc:5856 #4 0x00007fe5f444614a in __libc_start_call_main () from /lib64/libc.so.6 #5 0x00007fe5f444620b in __libc_start_main_impl () from /lib64/libc.so.6 #6 0x000000000064df05 in _start ()
            heyingquan Yingquan He added a comment -

            Can I be allowed to fix this issue? But I'm not sure which versions should be fixed.

            heyingquan Yingquan He added a comment - Can I be allowed to fix this issue? But I'm not sure which versions should be fixed.
            tonychen Tony Chen added a comment - - edited

            I'm already working on related fixes for MDEV-26923 in open PR #2935, and plan to address this issue as well.

            tonychen Tony Chen added a comment - - edited I'm already working on related fixes for MDEV-26923 in open PR #2935, and plan to address this issue as well.
            tonychen Tony Chen added a comment - - edited

            As mentioned above, MDEV-22219 which was fixed for 10.6 and above, made it so that negative values no longer equate to the maximum value.

            Thus this issue only affects versions 10.6+. MariaDB versions below 10.6 are not affected by this issue since negative values still default to the maximum allowed value.

            EDIT:
            The nature of this problem exists in versions <10.6 as-well. This same problem happens if you pass in an invalid data type for the argument (e.g. specifying characters for a numeric argument) or if you pass in a value that can't be represented with the argument type (e.g. a number that cannot be represented with 64 bits).

            tonychen Tony Chen added a comment - - edited As mentioned above, MDEV-22219 which was fixed for 10.6 and above, made it so that negative values no longer equate to the maximum value. Thus this issue only affects versions 10.6+ . MariaDB versions below 10.6 are not affected by this issue since negative values still default to the maximum allowed value. EDIT: The nature of this problem exists in versions <10.6 as-well. This same problem happens if you pass in an invalid data type for the argument (e.g. specifying characters for a numeric argument) or if you pass in a value that can't be represented with the argument type (e.g. a number that cannot be represented with 64 bits).
            tonychen Tony Chen added a comment - - edited

            Update
            I have a working solution to address this issue but it depends on https://github.com/MariaDB/server/pull/2935 to be merged first.

            https://github.com/MariaDB/server/pull/3120

            tonychen Tony Chen added a comment - - edited Update I have a working solution to address this issue but it depends on https://github.com/MariaDB/server/pull/2935 to be merged first. https://github.com/MariaDB/server/pull/3120

            People

              TheLinuxJedi Andrew Hutchings (Inactive)
              dlenski Daniel Lenski (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.