Details
-
Task
-
Status: Closed (View Workflow)
-
Blocker
-
Resolution: Fixed
-
None
Description
Make s3_debug dynamic to allow users to enable debug logging of the S3 communication without having to restart mariadbd.
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Fix Version/s | 10.6.17 [ 29518 ] |
| Assignee | Michael Widenius [ monty ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Fix Version/s | 10.6 [ 24028 ] | |
| Fix Version/s | 10.11 [ 27614 ] | |
| Fix Version/s | 11.0 [ 28320 ] | |
| Fix Version/s | 11.1 [ 28549 ] | |
| Fix Version/s | 10.6.17 [ 29518 ] |
| Link | This issue blocks MENT-2001 [ MENT-2001 ] |
Fix was easy, but I also had fix a bug in libmarias3, which took some extra time
| issue.field.resolutiondate | 2023-11-30 17:58:54.0 | 2023-11-30 17:58:53.869 |
| Component/s | Storage Engine - S3 [ 15100 ] | |
| Fix Version/s | 10.6.17 [ 29518 ] | |
| Fix Version/s | 10.6 [ 24028 ] | |
| Fix Version/s | 10.11 [ 27614 ] | |
| Fix Version/s | 11.0 [ 28320 ] | |
| Fix Version/s | 11.1 [ 28549 ] | |
| Resolution | Fixed [ 1 ] | |
| Status | In Progress [ 3 ] | Closed [ 6 ] |
| Resolution | Fixed [ 1 ] | |
| Status | Closed [ 6 ] | Stalled [ 10000 ] |
| Priority | Major [ 3 ] | Blocker [ 1 ] |
| Assignee | Michael Widenius [ monty ] | Andrew Hutchings [ JIRAUSER52179 ] |
Full details for my pull request:
Monty's update pulled two years of updates for libmarias3 so that he could get the latest commit. This included a bunch of other bug fixes. It was found a long time ago that the API call in libmarias3 that s3_protocol_version used wasn't actually doing anything, this was fixed in libmarias3 but MariaDB Server hadn't picked up that fix.
Now with the update the fix has been picked up and anyone who might be using "Original" with AWS might find their installation no longer works (and a test will fail), there are exceptions to this, these are us-east-1 which still allows a legacy access method or by using the AWS region in the domain (such as s3.us-east-2.amazonaws.com).
As "Original" never really worked before, my patch now makes this the same as "Amazon", just in case someone is using it. It adds "Legacy" for the protocol v1 to keep it close to the naming conventions. It also adds "Path" and "Domain" which are really what v1 and v2 are under the hood, a future version should remove the "Legacy", "Original" and "Amazon" options.
Finally, my patch fixes the the tests around the S3 engine.
Monty has reviewed and approved already. Assigned to Daniel for second review.
| Assignee | Andrew Hutchings [ JIRAUSER52179 ] | Daniel Black [ danblack ] |
| Status | Stalled [ 10000 ] | In Review [ 10002 ] |
I wasn't subscribed to this thread and hence didn't notice the need for the second reviewer's confirmation.
| Link | This issue relates to MENT-2001 [ MENT-2001 ] |
| Link | This issue blocks MENT-2001 [ MENT-2001 ] |
| Resolution | Fixed [ 1 ] | |
| Status | In Review [ 10002 ] | Closed [ 6 ] |
| Assignee | Daniel Black [ danblack ] | Michael Widenius [ monty ] |
| Zendesk Related Tickets | 201534 | |
| Zendesk active tickets | 201534 |
Patch ready for 10.6, just need to get other patches in 10.6 approved so that I can push all at once.