Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-32175

page_align() or page_offset() may cost some performance

Details

    Description

      In MDEV-29445, I wanted to remove the data member buf_page_t::frame, because there is a simple 1:1 mapping between page frame addresses and block descriptor addresses. That is, the data member would be replaced with a member function buf_page_t::frame(). Because I anticipated the member function calls to cause some performance regression, I thought that it would make sense to remove as many references to buf_page_t::frame as possible.

      I just tested this change on top of the latest 10.6. In my quick test (Sysbench oltp_write_only), the performance difference is at most 2%, sometimes showing a regression, sometimes an improvement.

      I think that it would be useful to run more tests and refine this patch, to revert parts that are not helpful (causing extra calls to page_align() or page_offset()). The outcome of this might be that it is better to retain the redundant data member buf_page_t::frame in MDEV-29445.

      Attachments

        Issue Links

          Activity

            Transition Time In Source Status Execution Times
            Marko Mäkelä made transition -
            Open In Progress
            2h 26m 1
            JiraAutomate made transition -
            In Progress Stalled
            187d 1h 55m 3
            Marko Mäkelä made transition -
            Stalled In Progress
            205d 1h 28m 4
            Marko Mäkelä made transition -
            In Progress In Review
            19d 10h 13m 2
            Vladislav Lesin made transition -
            In Review Stalled
            15d 9h 54m 2
            Marko Mäkelä made transition -
            Stalled Closed
            5d 22h 47m 1

            People

              marko Marko Mäkelä
              marko Marko Mäkelä
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.