Sprint:
Server 12.1 dev sprint
There is quite a lot of technical debt within the ACL code. Some of it can be fixed in stable versions as it involves minimal logic changes.
This task covers all the cleanups and related refactorings, in preparation for DENIES.
Vicențiu Ciorbaru
made changes -
2023-07-19 08:15
Field
Original Value
New Value
Assignee
Vicențiu Ciorbaru
[ cvicentiu
]
Vicențiu Ciorbaru
made changes -
2023-07-19 08:16
Status
Open
[ 1
]
In Progress
[ 3
]
Vicențiu Ciorbaru
made changes -
2023-07-19 08:16
Status
In Progress
[ 3
]
Stalled
[ 10000
]
Vicențiu Ciorbaru
made changes -
2023-07-19 08:16
Status
Stalled
[ 10000
]
In Progress
[ 3
]
Vicențiu Ciorbaru
made changes -
2023-07-19 08:17
Assignee
Vicențiu Ciorbaru
[ cvicentiu
]
Oleksandr Byelkin
[ sanja
]
Status
In Progress
[ 3
]
In Review
[ 10002
]
Ralf Gebhardt
made changes -
2023-07-27 09:35
Fix Version/s
11.3
[ 28565
]
Fix Version/s
10.11
[ 27614
]
Ralf Gebhardt
made changes -
2023-08-09 14:21
Assignee
Oleksandr Byelkin
[ sanja
]
Sergei Golubchik
[ serg
]
Ralf Gebhardt
made changes -
2023-08-09 14:21
Priority
Major
[ 3
]
Critical
[ 2
]
Ralf Gebhardt
made changes -
2023-09-20 05:14
Fix Version/s
11.4
[ 29301
]
Fix Version/s
11.3
[ 28565
]
Sergei Golubchik
made changes -
2023-11-11 13:52
Assignee
Sergei Golubchik
[ serg
]
Vicențiu Ciorbaru
[ cvicentiu
]
Status
In Review
[ 10002
]
Stalled
[ 10000
]
Sergei Golubchik
made changes -
2023-12-22 17:46
Fix Version/s
11.5
[ 29506
]
Fix Version/s
11.4
[ 29301
]
Ralf Gebhardt
made changes -
2024-02-27 13:37
Fix Version/s
11.6
[ 29515
]
Fix Version/s
11.5
[ 29506
]
Sergei Golubchik
made changes -
2024-06-04 15:39
Fix Version/s
11.7
[ 29815
]
Fix Version/s
11.6
[ 29515
]
Sergei Golubchik
made changes -
2024-08-27 14:18
Fix Version/s
11.8
[ 29921
]
Fix Version/s
11.7
[ 29815
]
Ralf Gebhardt
made changes -
2024-10-24 16:03
Assignee
Vicențiu Ciorbaru
[ cvicentiu
]
Ralf Gebhardt
made changes -
2024-10-24 16:03
Fix Version/s
11.9
[ 29945
]
Fix Version/s
11.8
[ 29921
]
Julien Fritsch
made changes -
2025-01-24 11:42
Assignee
Vicențiu Ciorbaru
[ cvicentiu
]
Sergei Golubchik
made changes -
2025-01-24 12:53
Assignee
Vicențiu Ciorbaru
[ cvicentiu
]
Sergei Golubchik
made changes -
2025-01-28 13:38
Assignee
Alexander Barkov
[ bar
]
Oleksandr Byelkin
made changes -
2025-02-20 10:50
Assignee
Alexander Barkov
[ bar
]
Vladislav Vaintroub
[ wlad
]
Sergei Golubchik
made changes -
2025-03-18 15:44
Fix Version/s
12.1
[ 29992
]
Fix Version/s
12.0
[ 29945
]
{"report":{"fcp":1179.1999998092651,"ttfb":276.30000019073486,"pageVisibility":"visible","entityId":123559,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"29bb7a62-5647-43e3-a646-9e63dbf537ae","navigationType":0,"readyForUser":1242.6000003814697,"redirectCount":0,"resourceLoadedEnd":1377.5,"resourceLoadedStart":281.5,"resourceTiming":[{"duration":95.60000038146973,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":281.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":281.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":377.1000003814697,"responseStart":0,"secureConnectionStart":0},{"duration":95.60000038146973,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/2bf333562ca6724060a9d5f1535471f6/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":281.80000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":281.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":377.4000005722046,"responseStart":0,"secureConnectionStart":0},{"duration":157,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":282,"connectEnd":282,"connectStart":282,"domainLookupEnd":282,"domainLookupStart":282,"fetchStart":282,"redirectEnd":0,"redirectStart":0,"requestStart":282,"responseEnd":439,"responseStart":439,"secureConnectionStart":282},{"duration":563.1000003814697,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/2bf333562ca6724060a9d5f1535471f6/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":282.19999980926514,"connectEnd":282.19999980926514,"connectStart":282.19999980926514,"domainLookupEnd":282.19999980926514,"domainLookupStart":282.19999980926514,"fetchStart":282.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":282.19999980926514,"responseEnd":845.3000001907349,"responseStart":845.3000001907349,"secureConnectionStart":282.19999980926514},{"duration":566.7999992370605,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":282.4000005722046,"connectEnd":282.4000005722046,"connectStart":282.4000005722046,"domainLookupEnd":282.4000005722046,"domainLookupStart":282.4000005722046,"fetchStart":282.4000005722046,"redirectEnd":0,"redirectStart":0,"requestStart":282.4000005722046,"responseEnd":849.1999998092651,"responseStart":849.1999998092651,"secureConnectionStart":282.4000005722046},{"duration":567.1999998092651,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":282.6000003814697,"connectEnd":282.6000003814697,"connectStart":282.6000003814697,"domainLookupEnd":282.6000003814697,"domainLookupStart":282.6000003814697,"fetchStart":282.6000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":282.6000003814697,"responseEnd":849.8000001907349,"responseStart":849.8000001907349,"secureConnectionStart":282.6000003814697},{"duration":567.3999996185303,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":282.80000019073486,"connectEnd":282.80000019073486,"connectStart":282.80000019073486,"domainLookupEnd":282.80000019073486,"domainLookupStart":282.80000019073486,"fetchStart":282.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":282.80000019073486,"responseEnd":850.1999998092651,"responseStart":850.1999998092651,"secureConnectionStart":282.80000019073486},{"duration":568.1000003814697,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":283,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":283,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":851.1000003814697,"responseStart":0,"secureConnectionStart":0},{"duration":567.4000005722046,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":283.19999980926514,"connectEnd":283.19999980926514,"connectStart":283.19999980926514,"domainLookupEnd":283.19999980926514,"domainLookupStart":283.19999980926514,"fetchStart":283.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":283.19999980926514,"responseEnd":850.6000003814697,"responseStart":850.6000003814697,"secureConnectionStart":283.19999980926514},{"duration":568,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":283.30000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":283.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":851.3000001907349,"responseStart":0,"secureConnectionStart":0},{"duration":567.5999994277954,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":283.6000003814697,"connectEnd":283.6000003814697,"connectStart":283.6000003814697,"domainLookupEnd":283.6000003814697,"domainLookupStart":283.6000003814697,"fetchStart":283.6000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":283.6000003814697,"responseEnd":851.1999998092651,"responseStart":851.1999998092651,"secureConnectionStart":283.6000003814697},{"duration":1061.0999994277954,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":289.1000003814697,"connectEnd":289.1000003814697,"connectStart":289.1000003814697,"domainLookupEnd":289.1000003814697,"domainLookupStart":289.1000003814697,"fetchStart":289.1000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":289.1000003814697,"responseEnd":1350.1999998092651,"responseStart":1350.1000003814697,"secureConnectionStart":289.1000003814697},{"duration":1059.6000003814697,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":291,"connectEnd":291,"connectStart":291,"domainLookupEnd":291,"domainLookupStart":291,"fetchStart":291,"redirectEnd":0,"redirectStart":0,"requestStart":291,"responseEnd":1350.6000003814697,"responseStart":1350.6000003814697,"secureConnectionStart":291},{"duration":517.4000005722046,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":591.1999998092651,"connectEnd":591.1999998092651,"connectStart":591.1999998092651,"domainLookupEnd":591.1999998092651,"domainLookupStart":591.1999998092651,"fetchStart":591.1999998092651,"redirectEnd":0,"redirectStart":0,"requestStart":591.1999998092651,"responseEnd":1108.6000003814697,"responseStart":1108.6000003814697,"secureConnectionStart":591.1999998092651},{"duration":257.0999994277954,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":1120.4000005722046,"connectEnd":1120.4000005722046,"connectStart":1120.4000005722046,"domainLookupEnd":1120.4000005722046,"domainLookupStart":1120.4000005722046,"fetchStart":1120.4000005722046,"redirectEnd":0,"redirectStart":0,"requestStart":1120.4000005722046,"responseEnd":1377.5,"responseStart":1377.5,"secureConnectionStart":1120.4000005722046},{"duration":267.69999980926514,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":1173.1000003814697,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1173.1000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1440.8000001907349,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":64,"responseStart":276,"responseEnd":291,"domLoading":279,"domInteractive":1386,"domContentLoadedEventStart":1386,"domContentLoadedEventEnd":1435,"domComplete":1653,"loadEventStart":1653,"loadEventEnd":1653,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1354.4000005722046},{"name":"bigPipe.sidebar-id.end","time":1355.1000003814697},{"name":"bigPipe.activity-panel-pipe-id.start","time":1355.3000001907349},{"name":"bigPipe.activity-panel-pipe-id.end","time":1360.5},{"name":"activityTabFullyLoaded","time":1456.1000003814697}],"measures":[],"correlationId":"30e170c58843ac","effectiveType":"4g","downlink":9.1,"rtt":0,"serverDuration":156,"dbReadsTimeInMs":32,"dbConnsTimeInMs":41,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
Hi Sanja!
Let's get denies review going by first merging all my cleanup commits. Please review
https://github.com/MariaDB/server/pull/2704
cleanup: labeled commits should be very safe.
refactor: labeled commits have the potential to introduce regressions so should be examined more closely.
bugfix: labeled commits are just bug fixes that I discovered while coding.