[MDEV-31636] Memory leak in Sys_var_gtid_binlog_state::do_check() - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Critical
Resolution: Fixed
Affects Version/s: 10.11.4, 10.4(EOL), 10.5, 10.6, 10.7(EOL), 10.8(EOL), 10.9(EOL), 10.11, 11.0(EOL), 11.1(EOL), 11.2(EOL)
Fix Version/s: 10.5.27, 10.6.20, 10.11.10, 11.2.6, 11.4.4
Component/s: Replication, Variables
Labels:
None

Description

--source include/have_log_bin.inc

RESET MASTER;

--error ER_WRONG_VALUE_FOR_VAR

SET

  @@global.gtid_binlog_state='1-1-101,2-1-2002',

  @@global.slave_parallel_mode=x;

SELECT @@global.gtid_binlog_state;

***Warnings generated in error logs during shutdown after running tests: main.AAA

Warning: Memory not freed: 224

Warning:   40 bytes lost at 0x45fa260, allocated by T@0 at sql/sys_vars.cc:2120, sql/set_var.cc:246, sql/set_var.cc:810, sql/set_var.cc:738, sql/sql_parse.cc:5040, sql/sql_parse.cc:8023, sql/sql_parse.cc:1896, sql/sql_parse.cc:1407

Warning:  184 bytes lost at 0x7f71481b7790, allocated by T@0 at mysys/my_malloc.c:143, sql/rpl_gtid.cc:1359, sql/sys_vars.cc:2114, sql/set_var.cc:246, sql/set_var.cc:810, sql/set_var.cc:738, sql/sql_parse.cc:5040, sql/sql_parse.cc:8023

Warning:  152 bytes lost at 0x409c760, allocated by T@0 at mysys/array.c:73, mysys/hash.c:99, sql/sql_hset.h:37, sql/debug_sync.cc:90, sql/debug_sync.cc:166, sql/debug_sync.cc:1808, ??:0, csu/libc-start.c:268

Warning:   40 bytes lost at 0x45fa260, allocated by T@0 at sql/sys_vars.cc:2120, sql/set_var.cc:246, sql/set_var.cc:810, sql/set_var.cc:738, sql/sql_parse.cc:5040, sql/sql_parse.cc:8023, sql/sql_parse.cc:1896, sql/sql_parse.cc:1407

Warning:  184 bytes lost at 0x7f71481b7790, allocated by T@0 at mysys/my_malloc.c:143, sql/rpl_gtid.cc:1359, sql/sys_vars.cc:2114, sql/set_var.cc:246, sql/set_var.cc:810, sql/set_var.cc:738, sql/sql_parse.cc:5040, sql/sql_parse.cc:8023

The leaked memory is allocated in Sys_var_gtid_binlog_state::do_check() in this code:

  if (!(data= (gtid_binlog_state_data *)my_malloc(PSI_INSTRUMENT_ME,

                                                  sizeof(*data), MYF(0))))

The problem happens because:

The @@global.gtid_binlog_state='1-1-101,2-1-2002' part of the statement allocated memory and assigns it to var->save_result.ptr
The @@global.slave_parallel_mode=x part fails on an error (wrong value)
The entire statement fails
The allocated value in var->save_result.ptr is never freed during the statement cleanup

Attachments

Activity

Ascending order - Click to sort in descending order

Alexander Barkov created issue - 2023-07-06 07:55

Alexander Barkov made changes - 2023-07-06 07:57

Field	Original Value	New Value
Description	{code:sql} --source include/have_log_bin.inc RESET MASTER; --error ER_WRONG_VALUE_FOR_VAR SET @@global.gtid_binlog_state='1-1-101,2-1-2002', @@global.slave_parallel_mode=x; SELECT @@global.gtid_binlog_state; {code} {noformat} **Warnings generated in error logs during shutdown after running tests: main.AAA Warning: Memory not freed: 224 Warning: 40 bytes lost at 0x45fa260, allocated by T@0 at sql/sys_vars.cc:2120, sql/set_var.cc:246, sql/set_var.cc:810, sql/set_var.cc:738, sql/sql_parse.cc:5040, sql/sql_parse.cc:8023, sql/sql_parse.cc:1896, sql/sql_parse.cc:1407 Warning: 184 bytes lost at 0x7f71481b7790, allocated by T@0 at mysys/my_malloc.c:143, sql/rpl_gtid.cc:1359, sql/sys_vars.cc:2114, sql/set_var.cc:246, sql/set_var.cc:810, sql/set_var.cc:738, sql/sql_parse.cc:5040, sql/sql_parse.cc:8023 Warning: 152 bytes lost at 0x409c760, allocated by T@0 at mysys/array.c:73, mysys/hash.c:99, sql/sql_hset.h:37, sql/debug_sync.cc:90, sql/debug_sync.cc:166, sql/debug_sync.cc:1808, ??:0, csu/libc-start.c:268 Warning: 40 bytes lost at 0x45fa260, allocated by T@0 at sql/sys_vars.cc:2120, sql/set_var.cc:246, sql/set_var.cc:810, sql/set_var.cc:738, sql/sql_parse.cc:5040, sql/sql_parse.cc:8023, sql/sql_parse.cc:1896, sql/sql_parse.cc:1407 Warning: 184 bytes lost at 0x7f71481b7790, allocated by T@0 at mysys/my_malloc.c:143, sql/rpl_gtid.cc:1359, sql/sys_vars.cc:2114, sql/set_var.cc:246, sql/set_var.cc:810, sql/set_var.cc:738, sql/sql_parse.cc:5040, sql/sql_parse.cc:8023 {noformat} The leaked memory is allocated in Sys_var_gtid_binlog_state::do_check() in this code: {code:spp} if (!(data= (gtid_binlog_state_data )my_malloc(PSI_INSTRUMENT_ME, sizeof(*data), MYF(0)))) { {code}	{code:sql} --source include/have_log_bin.inc RESET MASTER; --error ER_WRONG_VALUE_FOR_VAR SET @@global.gtid_binlog_state='1-1-101,2-1-2002', @@global.slave_parallel_mode=x; SELECT @@global.gtid_binlog_state; {code} {noformat} **Warnings generated in error logs during shutdown after running tests: main.AAA Warning: Memory not freed: 224 Warning: 40 bytes lost at 0x45fa260, allocated by T@0 at sql/sys_vars.cc:2120, sql/set_var.cc:246, sql/set_var.cc:810, sql/set_var.cc:738, sql/sql_parse.cc:5040, sql/sql_parse.cc:8023, sql/sql_parse.cc:1896, sql/sql_parse.cc:1407 Warning: 184 bytes lost at 0x7f71481b7790, allocated by T@0 at mysys/my_malloc.c:143, sql/rpl_gtid.cc:1359, sql/sys_vars.cc:2114, sql/set_var.cc:246, sql/set_var.cc:810, sql/set_var.cc:738, sql/sql_parse.cc:5040, sql/sql_parse.cc:8023 Warning: 152 bytes lost at 0x409c760, allocated by T@0 at mysys/array.c:73, mysys/hash.c:99, sql/sql_hset.h:37, sql/debug_sync.cc:90, sql/debug_sync.cc:166, sql/debug_sync.cc:1808, ??:0, csu/libc-start.c:268 Warning: 40 bytes lost at 0x45fa260, allocated by T@0 at sql/sys_vars.cc:2120, sql/set_var.cc:246, sql/set_var.cc:810, sql/set_var.cc:738, sql/sql_parse.cc:5040, sql/sql_parse.cc:8023, sql/sql_parse.cc:1896, sql/sql_parse.cc:1407 Warning: 184 bytes lost at 0x7f71481b7790, allocated by T@0 at mysys/my_malloc.c:143, sql/rpl_gtid.cc:1359, sql/sys_vars.cc:2114, sql/set_var.cc:246, sql/set_var.cc:810, sql/set_var.cc:738, sql/sql_parse.cc:5040, sql/sql_parse.cc:8023 {noformat} The leaked memory is allocated in Sys_var_gtid_binlog_state::do_check() in this code: {code:spp} if (!(data= (gtid_binlog_state_data )my_malloc(PSI_INSTRUMENT_ME, sizeof(*data), MYF(0)))) { {code} The problem happens because: - The {{@@global.gtid_binlog_state='1-1-101,2-1-2002'}} part of the statement allocated memory and assigns it to var->save_result.ptr - The {{@@global.slave_parallel_mode=x}} part fails on an error (wrong value) - The entire statement fails - The allocated value in var->save_result.ptr is never freed during the statement cleanup

Alexander Barkov made changes - 2023-07-06 07:58

Affects Version/s		10.11.4 [ 28918 ]
Affects Version/s		10.4 [ 22408 ]
Affects Version/s		10.5 [ 23123 ]
Affects Version/s		10.6 [ 24028 ]
Affects Version/s		10.7 [ 24805 ]
Affects Version/s		10.8 [ 26121 ]
Affects Version/s		10.9 [ 26905 ]
Affects Version/s		11.0 [ 28320 ]
Affects Version/s		11.1 [ 28549 ]
Affects Version/s		11.2 [ 28603 ]

Alexander Barkov made changes - 2023-07-06 07:59

Fix Version/s		10.4 [ 22408 ]
Fix Version/s		10.5 [ 23123 ]
Fix Version/s		10.6 [ 24028 ]
Fix Version/s		10.7 [ 24805 ]
Fix Version/s		10.9 [ 26905 ]
Fix Version/s		11.0 [ 28320 ]
Fix Version/s		11.1 [ 28549 ]
Fix Version/s		11.2 [ 28603 ]

Alexander Barkov made changes - 2023-07-06 07:59

Priority

Major [ 3 ]

Critical [ 2 ]

Alexander Barkov made changes - 2023-07-06 08:02

Link

This issue blocks ~~MDEV-30164~~ [ ~~MDEV-30164~~ ]

Alexander Barkov added a comment - 2023-07-06 08:02 - edited

For the new system variable @@character_set_collations we'll need to allocate a temporary value to pass it between do_check() and session_update()/global_update(), similar to how it is done in @@gtid_binlog_state. So @@gtid_binlog_state should be fixed first.

Alexander Barkov added a comment - 2023-07-06 08:02 - edited For the new system variable @@character_set_collations we'll need to allocate a temporary value to pass it between do_check() and session_update() / global_update() , similar to how it is done in @@gtid_binlog_state . So @@gtid_binlog_state should be fixed first.

Alexander Barkov made changes - 2023-07-06 08:23

Assignee

Alexander Barkov [ bar ]

Alexander Barkov made changes - 2023-07-06 10:15

Link

This issue blocks ~~MDEV-30164~~ [ ~~MDEV-30164~~ ]

Alexander Barkov added a comment - 2023-07-06 10:15

A possible solution would be to allocate the structure on THD::mem_root instead of using my_malloc.

Alexander Barkov added a comment - 2023-07-06 10:15 A possible solution would be to allocate the structure on THD::mem_root instead of using my_malloc.

Alexander Barkov made changes - 2023-07-06 10:16

Assignee

Alexander Barkov [ bar ]

Andrei Elkin [ elkin ]

Julien Fritsch made changes - 2023-07-18 07:21

Fix Version/s

10.7 [ 24805 ]

Julien Fritsch made changes - 2023-11-28 10:21

Fix Version/s

10.9 [ 26905 ]

Andrei Elkin made changes - 2024-02-20 18:57

Assignee

Andrei Elkin [ elkin ]

Brandon Nesterenko [ JIRAUSER48702 ]

Brandon Nesterenko made changes - 2024-04-16 21:37

Status

Open [ 1 ]

In Progress [ 3 ]

Julien Fritsch made changes - 2024-05-03 14:41

Fix Version/s

11.0 [ 28320 ]

JiraAutomate made changes - 2024-06-16 16:21

Status

In Progress [ 3 ]

Stalled [ 10000 ]

Brandon Nesterenko made changes - 2024-07-08 13:36

Assignee

Brandon Nesterenko [ JIRAUSER48702 ]

Dave Gosselin [ JIRAUSER52216 ]

Julien Fritsch made changes - 2024-09-10 14:56

Fix Version/s

10.4 [ 22408 ]

Julien Fritsch made changes - 2024-09-10 15:25

Fix Version/s

11.1 [ 28549 ]

Dave Gosselin made changes - 2024-09-13 16:45

Status

Stalled [ 10000 ]

In Progress [ 3 ]

Dave Gosselin made changes - 2024-09-17 15:27

Assignee	Dave Gosselin [ JIRAUSER52216 ]	Andrei Elkin [ elkin ]
Status	In Progress [ 3 ]	In Review [ 10002 ]

Andrei Elkin added a comment - 2024-09-18 17:29

A note on github is made to resolve.

Andrei Elkin added a comment - 2024-09-18 17:29 A note on github is made to resolve.

Andrei Elkin made changes - 2024-09-18 17:29

Assignee	Andrei Elkin [ elkin ]	Dave Gosselin [ JIRAUSER52216 ]
Status	In Review [ 10002 ]	Stalled [ 10000 ]

Dave Gosselin made changes - 2024-09-18 18:14

Status

Stalled [ 10000 ]

In Progress [ 3 ]

Dave Gosselin made changes - 2024-09-18 21:42

Assignee	Dave Gosselin [ JIRAUSER52216 ]	Andrei Elkin [ elkin ]
Status	In Progress [ 3 ]	In Review [ 10002 ]

Dave Gosselin made changes - 2024-09-25 18:18

Fix Version/s		10.5.27 [ 29902 ]
Fix Version/s	10.5 [ 23123 ]
Fix Version/s	10.6 [ 24028 ]
Fix Version/s	10.11 [ 27614 ]
Fix Version/s	11.2 [ 28603 ]
Resolution		Fixed [ 1 ]
Status	In Review [ 10002 ]	Closed [ 6 ]

JiraAutomate made changes - 2024-09-25 18:18

Fix Version/s		10.6.20 [ 29903 ]
Fix Version/s		10.11.10 [ 29904 ]
Fix Version/s		11.2.6 [ 29906 ]
Fix Version/s		11.4.4 [ 29907 ]

People

Assignee:: Andrei Elkin

Reporter:: Alexander Barkov

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 2023-07-06 07:55

Updated:: 2024-09-25 18:18

Resolved:: 2024-09-25 18:18

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server

Details

Description

Attachments

Activity

People

Dates

Git Integration