When mariabackup 10.6.13 communicates with an older mariadbd (e.g. 10.6.12), it does not get the aria_log_dir_path from the server. It will stay NULL. This causes an opendir(NULL) down the road.
Log:
2023-05-12 08:21:47.129 - DEBUG - [00] 2023-05-12 08:21:47 Finished backing up non-InnoDB tables and files
|
2023-05-12 08:21:47.130 - DEBUG - 230512 8:21:47 [ERROR] mysqld got signal 11 ;
|
2023-05-12 08:21:47.130 - DEBUG - This could be because you hit a bug. It is also possible that this binary
|
2023-05-12 08:21:47.130 - DEBUG - or one of the libraries it was linked against is corrupt, improperly built,
|
2023-05-12 08:21:47.130 - DEBUG - or misconfigured. This error can also be caused by malfunctioning hardware.
|
2023-05-12 08:21:47.131 - DEBUG -
|
2023-05-12 08:21:47.131 - DEBUG - To report this bug, see https://mariadb.com/kb/en/reporting-bugs
|
2023-05-12 08:21:47.131 - DEBUG -
|
2023-05-12 08:21:47.131 - DEBUG - We will try our best to scrape up some info that will hopefully help
|
2023-05-12 08:21:47.131 - DEBUG - diagnose the problem, but since we have already crashed,
|
2023-05-12 08:21:47.131 - DEBUG - something is definitely wrong and this may fail.
|
2023-05-12 08:21:47.131 - DEBUG -
|
2023-05-12 08:21:47.131 - DEBUG - Server version: 10.6.13-MariaDB-1:10.6.13+maria~ubu2004 source revision: a24f2bb50ba4a0dd4127455f7fcdfed584937f36
|
2023-05-12 08:21:47.131 - DEBUG - key_buffer_size=0
|
2023-05-12 08:21:47.131 - DEBUG - read_buffer_size=131072
|
2023-05-12 08:21:47.131 - DEBUG - max_used_connections=0
|
2023-05-12 08:21:47.131 - DEBUG - max_threads=1
|
2023-05-12 08:21:47.131 - DEBUG - thread_count=0
|
2023-05-12 08:21:47.131 - DEBUG - It is possible that mysqld could use up to
|
2023-05-12 08:21:47.131 - DEBUG - key_buffer_size + (read_buffer_size + sort_buffer_size)*max_threads = 6145 K bytes of memory
|
2023-05-12 08:21:47.131 - DEBUG - Hope that's ok; if not, decrease some variables in the equation.
|
2023-05-12 08:21:47.131 - DEBUG -
|
2023-05-12 08:21:47.132 - DEBUG - Thread pointer: 0x0
|
2023-05-12 08:21:47.132 - DEBUG - Attempting backtrace. You can use the following information to find out
|
2023-05-12 08:21:47.132 - DEBUG - where mysqld died. If you see no messages after this, something went
|
2023-05-12 08:21:47.132 - DEBUG - terribly wrong...
|
2023-05-12 08:21:47.132 - DEBUG - stack_bottom = 0x0 thread_stack 0x49000
|
2023-05-12 08:21:47.134 - DEBUG - Printing to addr2line failed
|
2023-05-12 08:21:47.134 - DEBUG - /usr/bin/mariabackup(my_print_stacktrace+0x32)[0x560ffe2e6f82]
|
2023-05-12 08:21:47.135 - DEBUG - /usr/bin/mariabackup(handle_fatal_signal+0x485)[0x560ffde1c025]
|
2023-05-12 08:21:47.136 - DEBUG - /lib/x86_64-linux-gnu/libpthread.so.0(+0x14420)[0x7f0c4f0d6420]
|
2023-05-12 08:21:47.138 - DEBUG - /lib/x86_64-linux-gnu/libc.so.6(opendir+0x24)[0x7f0c4ec74ea4]
|
2023-05-12 08:21:47.140 - DEBUG - /usr/bin/mariabackup(+0x7101e4)[0x560ffda771e4]
|
2023-05-12 08:21:47.140 - DEBUG - /usr/bin/mariabackup(_Z12backup_startP7ds_ctxtS0_R14CorruptedPages+0x10b)[0x560ffda7a9bb]
|
2023-05-12 08:21:47.141 - DEBUG - /usr/bin/mariabackup(+0x6fbc04)[0x560ffda62c04]
|
2023-05-12 08:21:47.141 - DEBUG - /usr/bin/mariabackup(main+0x182)[0x560ffda0a122]
|
2023-05-12 08:21:47.143 - DEBUG - /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf3)[0x7f0c4ebbb083]
|
2023-05-12 08:21:47.144 - DEBUG - /usr/bin/mariabackup(_start+0x2e)[0x560ffda4ea1e]
|
The problem is caused by:
https://github.com/MariaDB/server/commit/9f98a2acd71dcfbdb32a08e72a4737359ed9be40
Specifically this:
https://github.com/MariaDB/server/commit/9f98a2acd71dcfbdb32a08e72a4737359ed9be40#diff-a1b3373388d92a9bf267ea6336564fe8da01b98d1d8c59ed3758c252872a632eR1506-R1508
There we do:
if (!backup_files_from_datadir(ds_data, fil_path_to_mysql_datadir,
|
"aws-kms-key") ||
|
!backup_files_from_datadir(ds_data,
|
aria_log_dir_path,
|
"aria_log")) {
|
return false;
|
}
|
But if aria_log_dir_path is NULL, we go down to:
https://github.com/MariaDB/server/blob/0474466bc2c3e05a160677f1dbabea374e942736/extra/mariabackup/backup_copy.cc#L2270-L2274
Calling opendir(NULL), causing a segfault in libc.
Possible fix:
diff --git a/extra/mariabackup/backup_copy.cc b/extra/mariabackup/backup_copy.cc
|
index dbf12cedd68..33ebf55f45f 100644
|
--- a/extra/mariabackup/backup_copy.cc
|
+++ b/extra/mariabackup/backup_copy.cc
|
@@ -1439,9 +1439,9 @@ bool backup_start(ds_ctxt *ds_data, ds_ctxt *ds_meta,
|
|
if (!backup_files_from_datadir(ds_data, fil_path_to_mysql_datadir,
|
"aws-kms-key") ||
|
- !backup_files_from_datadir(ds_data,
|
+ (aria_log_dir_path && !backup_files_from_datadir(ds_data,
|
aria_log_dir_path,
|
- "aria_log")) {
|
+ "aria_log"))) {
|
return false;
|
}
|
|
Or, a workaround for callers:
--- a/mariadb-backup.py
|
+++ b/mariadb-backup.py
|
@@ -43,6 +43,7 @@ MARIABACKUP_THREADS = (MARIABACKUP_THREADS, 1)[MARIABACKUP_THREADS < 1]
|
MARIABACKUP_BASEARGS = (
|
'--defaults-file={}'.format(CNFFILE),
|
'--backup',
|
+ '--aria-log-dir-path=.', # see: MDEV-31251
|
'--parallel={}'.format(MARIABACKUP_THREADS))
|
|
INSTANCE_HASH = '<gets_set_in_main>'
|
Cheers,
Walter Doekes
OSSO B.V.
{"report":{"fcp":875.7999999523163,"ttfb":154.79999995231628,"pageVisibility":"visible","entityId":121798,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"95feb5a2-0f3e-462c-91f1-77a12e952399","navigationType":0,"readyForUser":970.0999999046326,"redirectCount":0,"resourceLoadedEnd":979.7000000476837,"resourceLoadedStart":159.5,"resourceTiming":[{"duration":128.79999995231628,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":159.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":159.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":288.2999999523163,"responseStart":0,"secureConnectionStart":0},{"duration":128.69999980926514,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":159.70000004768372,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":159.70000004768372,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":288.39999985694885,"responseStart":0,"secureConnectionStart":0},{"duration":137.30000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/fbf975c0cce4b1abf04784eeae9ba1f4-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":159.89999985694885,"connectEnd":159.89999985694885,"connectStart":159.89999985694885,"domainLookupEnd":159.89999985694885,"domainLookupStart":159.89999985694885,"fetchStart":159.89999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":159.89999985694885,"responseEnd":297.2000000476837,"responseStart":297.2000000476837,"secureConnectionStart":159.89999985694885},{"duration":354.59999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/099b33461394b8015fc36c0a4b96e19f-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":160,"connectEnd":160,"connectStart":160,"domainLookupEnd":160,"domainLookupStart":160,"fetchStart":160,"redirectEnd":0,"redirectStart":0,"requestStart":160,"responseEnd":514.5999999046326,"responseStart":514.5999999046326,"secureConnectionStart":160},{"duration":358.2000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/94c15bff32baef80f4096a08aceae8bc-CDN/lu2bu7/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":160.09999990463257,"connectEnd":160.09999990463257,"connectStart":160.09999990463257,"domainLookupEnd":160.09999990463257,"domainLookupStart":160.09999990463257,"fetchStart":160.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":160.09999990463257,"responseEnd":518.2999999523163,"responseStart":518.2999999523163,"secureConnectionStart":160.09999990463257},{"duration":358.39999985694885,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":160.20000004768372,"connectEnd":160.20000004768372,"connectStart":160.20000004768372,"domainLookupEnd":160.20000004768372,"domainLookupStart":160.20000004768372,"fetchStart":160.20000004768372,"redirectEnd":0,"redirectStart":0,"requestStart":160.20000004768372,"responseEnd":518.5999999046326,"responseStart":518.5999999046326,"secureConnectionStart":160.20000004768372},{"duration":359,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":160.29999995231628,"connectEnd":160.29999995231628,"connectStart":160.29999995231628,"domainLookupEnd":160.29999995231628,"domainLookupStart":160.29999995231628,"fetchStart":160.29999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":160.29999995231628,"responseEnd":519.2999999523163,"responseStart":519.2999999523163,"secureConnectionStart":160.29999995231628},{"duration":359.30000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bu7/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":160.39999985694885,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":160.39999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":519.7000000476837,"responseStart":0,"secureConnectionStart":0},{"duration":359.59999990463257,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":160.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":160.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":520.0999999046326,"responseStart":0,"secureConnectionStart":0},{"duration":359.2000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":160.5,"connectEnd":160.5,"connectStart":160.5,"domainLookupEnd":160.5,"domainLookupStart":160.5,"fetchStart":160.5,"redirectEnd":0,"redirectStart":0,"requestStart":160.5,"responseEnd":519.7000000476837,"responseStart":519.7000000476837,"secureConnectionStart":160.5},{"duration":359.7000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/3339d87fa2538a859872f2df449bf8d0-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":160.59999990463257,"connectEnd":160.59999990463257,"connectStart":160.59999990463257,"domainLookupEnd":160.59999990463257,"domainLookupStart":160.59999990463257,"fetchStart":160.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":160.59999990463257,"responseEnd":520.2999999523163,"responseStart":520.2999999523163,"secureConnectionStart":160.59999990463257},{"duration":554.2999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":173.70000004768372,"connectEnd":173.70000004768372,"connectStart":173.70000004768372,"domainLookupEnd":173.70000004768372,"domainLookupStart":173.70000004768372,"fetchStart":173.70000004768372,"redirectEnd":0,"redirectStart":0,"requestStart":173.70000004768372,"responseEnd":728,"responseStart":728,"secureConnectionStart":173.70000004768372},{"duration":701.2999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":174.70000004768372,"connectEnd":174.70000004768372,"connectStart":174.70000004768372,"domainLookupEnd":174.70000004768372,"domainLookupStart":174.70000004768372,"fetchStart":174.70000004768372,"redirectEnd":0,"redirectStart":0,"requestStart":174.70000004768372,"responseEnd":876,"responseStart":876,"secureConnectionStart":174.70000004768372},{"duration":282.59999990463257,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":444.5,"connectEnd":444.5,"connectStart":444.5,"domainLookupEnd":444.5,"domainLookupStart":444.5,"fetchStart":444.5,"redirectEnd":0,"redirectStart":0,"requestStart":444.5,"responseEnd":727.0999999046326,"responseStart":727.0999999046326,"secureConnectionStart":444.5},{"duration":96,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2bu7/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":780.5999999046326,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":780.5999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":876.5999999046326,"responseStart":0,"secureConnectionStart":0},{"duration":193.59999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":781.2999999523163,"connectEnd":781.2999999523163,"connectStart":781.2999999523163,"domainLookupEnd":781.2999999523163,"domainLookupStart":781.2999999523163,"fetchStart":781.2999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":781.2999999523163,"responseEnd":974.8999998569489,"responseStart":974.8999998569489,"secureConnectionStart":781.2999999523163},{"duration":198,"initiatorType":"script","name":"https://jira.mariadb.org/s/f51ef5507eea4c158f257c66c93b2a3f-CDN/lu2bu7/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/js/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":781.7000000476837,"connectEnd":781.7000000476837,"connectStart":781.7000000476837,"domainLookupEnd":781.7000000476837,"domainLookupStart":781.7000000476837,"fetchStart":781.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":781.7000000476837,"responseEnd":979.7000000476837,"responseStart":979.7000000476837,"secureConnectionStart":781.7000000476837},{"duration":128.69999980926514,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":869.2000000476837,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":869.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":997.8999998569489,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":19,"responseStart":155,"responseEnd":175,"domLoading":158,"domInteractive":1047,"domContentLoadedEventStart":1047,"domContentLoadedEventEnd":1104,"domComplete":1878,"loadEventStart":1878,"loadEventEnd":1880,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1017.8999998569489},{"name":"bigPipe.sidebar-id.end","time":1018.7000000476837},{"name":"bigPipe.activity-panel-pipe-id.start","time":1018.7999999523163},{"name":"bigPipe.activity-panel-pipe-id.end","time":1021.2999999523163},{"name":"activityTabFullyLoaded","time":1111.2000000476837}],"measures":[],"correlationId":"1629ac71733c18","effectiveType":"4g","downlink":9.5,"rtt":0,"serverDuration":76,"dbReadsTimeInMs":14,"dbConnsTimeInMs":21,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
MDEV-30968 mariadb-backup does not copy Aria logs if aria_log_dir_path is used
MDEV-30971 Add a new system variable aria_data_home_dir