Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-30370

mariadbd hangs when running with --wsrep-recover and --plugin-load-add=ha_spider.so

Details

    Description

      When running mariadbd with --wsrep-recover, it is expected to exit. But with --plugin-load-add=ha_spider.so, it does not exit.

      Given mariadbd is called with --wsrep-recover indirectly as part of the ExecStartPre in the systemd service, this can cause a hang on systemd [re]start.

      Attachments

        Issue Links

          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. MDEV-27912 --source include/restart_mysqld.inc fails in Spider test suite

          • Major - Major loss of function.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-20179 Server hangs on shutdown during installation of Spider

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-22979 "mysqld --bootstrap" / mysql_install_db hangs when Spider is installed

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-27233 Server hangs when using --init-file which loads Spider and creates a Spider table

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            View 13 older comments
            ycp Yuchen Pei added a comment - - edited

            I tested this patch for MDEV-22979 in 10.5 (eeb8ebb1520), and it still hangs there. However, it works for the present issue in 10.5. I will test this patch for a few more versions.

            ycp Yuchen Pei added a comment - - edited I tested this patch for MDEV-22979 in 10.5 (eeb8ebb1520), and it still hangs there. However, it works for the present issue in 10.5. I will test this patch for a few more versions.
            holyfoot Alexey Botchkov added a comment -

            The abovementioned Kentoku's patch looks ok to push.

            holyfoot Alexey Botchkov added a comment - The abovementioned Kentoku's patch looks ok to push.
            ycp Yuchen Pei added a comment - - edited

            Thanks holyfoot for the review.

            I have done tests and can confirm the patch fixes the present issue for 10.6-11.0.

            Pushing this patch is currently blocked by MDEV-27912, as the test for MDEV-29904 in the patch fails with "[ERROR] Server shutdown in progress" when the patch is applied to 10.8 a5b30158d4d, and I believe an MDEV-27912 patch for restart_mysqld.inc would fix that.

            ycp Yuchen Pei added a comment - - edited Thanks holyfoot for the review. I have done tests and can confirm the patch fixes the present issue for 10.6-11.0. Pushing this patch is currently blocked by MDEV-27912 , as the test for MDEV-29904 in the patch fails with " [ERROR] Server shutdown in progress" when the patch is applied to 10.8 a5b30158d4d, and I believe an MDEV-27912 patch for restart_mysqld.inc would fix that.
            ycp Yuchen Pei added a comment - - edited

            Pushed 284810b3e89. I removed the test for MDEV-29904 in the commit so that it does not block the push. I also tested MDEV-29904 in a testcase placed in the main suite:

            mysql-test/main/mdev_29904.test

            		 
            --echo #
            		 
            --echo # MDEV-29904 SPIDER plugin initialization fails upon startup
            		 
            --echo #
            		 
             
            		 
            --let $restart_parameters=--plugin-load-add=ha_spider
            		 
            --source include/restart_mysqld.inc

            ycp Yuchen Pei added a comment - - edited Pushed 284810b3e89. I removed the test for MDEV-29904 in the commit so that it does not block the push. I also tested MDEV-29904 in a testcase placed in the main suite: mysql-test/main/mdev_29904.test --echo # --echo # MDEV-29904 SPIDER plugin initialization fails upon startup --echo #   --let $restart_parameters=--plugin-load-add=ha_spider --source include/restart_mysqld.inc
            ycp Yuchen Pei added a comment -

            Pushed a trivial fix to the test to 10.4 https://github.com/MariaDB/server/commit/428c7964a23

            ycp Yuchen Pei added a comment - Pushed a trivial fix to the test to 10.4 https://github.com/MariaDB/server/commit/428c7964a23

            People

              ycp Yuchen Pei
              ycp Yuchen Pei
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.