[MDEV-30140] Some wsrep provider options only validate the first character of the value when setting it dynamically. - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Critical
Resolution: Fixed
Affects Version/s: 11.0.0, 10.4(EOL), 10.5, 10.6, 10.7(EOL), 10.8(EOL), 10.9(EOL), 10.10(EOL), 10.11
Fix Version/s: 10.11.3, 10.4.29, 10.5.20, 10.6.13, 10.8.8, 10.9.6, 10.10.4
Component/s: Galera
Labels:
None

Description

Some wsrep provider options only validate the first character of the value when setting it dynamically. This causes the wsrep options to be set to an invalid value and those options in wsrep_provider_options to have a truncated value.

node2:root@localhost> SET GLOBAL WSREP_PROVIDER_EVS_CAUSAL_KEEPALIVE_PERIOD=Panyvalue;

Query OK, 0 rows affected (0.000 sec)

node2:root@localhost>

node2:root@localhost> SELECT @@WSREP_PROVIDER_EVS_CAUSAL_KEEPALIVE_PERIOD;

+----------------------------------------------+

| @@WSREP_PROVIDER_EVS_CAUSAL_KEEPALIVE_PERIOD |

+----------------------------------------------+

| Panyvalue                                    |

+----------------------------------------------+

1 row in set (0.013 sec)

node2:root@localhost>

node2:root@localhost> SET GLOBAL WSREP_PROVIDER_EVS_CAUSAL_KEEPALIVE_PERIOD=anyvalue;

ERROR 1231 (42000): Variable 'evs_causal_keepalive_period' can't be set to the value of 'anyvalue'

node2:root@localhost>

WSREP_PROVIDER_EVS_CAUSAL_KEEPALIVE_PERIOD will have a truncated value in wsrep_provider_options.

node2:root@localhost> select @@wsrep_provider_options\G

*************************** 1. row ***************************

@@wsrep_provider_options: base_dir = /test/mtest/GAL_MD281122-mariadb-10.11.2-linux-x86_64-dbg/node2/; base_host = 127.0.0.1; base_port = 11842; cert.log_conflicts = no; cert.optimistic_pa = yes; debug = no; evs.auto_evict = 0; evs.causal_keepalive_period = P; [..]

node2:root@localhost> SET GLOBAL WSREP_PROVIDER_EVS_DELAYED_KEEP_PERIOD=Pdummy;

Query OK, 0 rows affected (0.001 sec)

node2:root@localhost> select @@WSREP_PROVIDER_EVS_DELAYED_KEEP_PERIOD;

+------------------------------------------+

| @@WSREP_PROVIDER_EVS_DELAYED_KEEP_PERIOD |

+------------------------------------------+

| Pdummy                                   |

+------------------------------------------+

1 row in set (0.000 sec)

node2:root@localhost> SET GLOBAL WSREP_PROVIDER_EVS_DELAYED_KEEP_PERIOD=dummy;

ERROR 1231 (42000): Variable 'evs_delayed_keep_period' can't be set to the value of 'dummy'

node2:root@localhost>

node2:root@localhost> SET GLOBAL WSREP_PROVIDER_EVS_DEBUG_LOG_MASK='1dummy';

Query OK, 0 rows affected (0.000 sec)

node2:root@localhost> select @@WSREP_PROVIDER_EVS_DEBUG_LOG_MASK;

+-------------------------------------+

| @@WSREP_PROVIDER_EVS_DEBUG_LOG_MASK |

+-------------------------------------+

| 1dummy                              |

+-------------------------------------+

1 row in set (0.031 sec)

node2:root@localhost> SET GLOBAL WSREP_PROVIDER_EVS_DEBUG_LOG_MASK='dummy';

Query OK, 0 rows affected (0.000 sec)

node2:root@localhost> select @@WSREP_PROVIDER_EVS_DEBUG_LOG_MASK;

+-------------------------------------+

| @@WSREP_PROVIDER_EVS_DEBUG_LOG_MASK |

+-------------------------------------+

| dummy                               |

+-------------------------------------+

1 row in set (0.000 sec)

node2:root@localhost>

node2:root@localhost> SET GLOBAL WSREP_PROVIDER_EVS_DEBUG_LOG_MASK='ummy';

ERROR 1231 (42000): Variable 'evs_debug_log_mask' can't be set to the value of 'ummy'

node2:root@localhost>

These are the variables that have this issue.

WSREP_PROVIDER_EVS_CAUSAL_KEEPALIVE_PERIOD

WSREP_PROVIDER_EVS_DEBUG_LOG_MASK

WSREP_PROVIDER_EVS_DELAYED_KEEP_PERIOD

WSREP_PROVIDER_EVS_DELAY_MARGIN

WSREP_PROVIDER_EVS_INACTIVE_CHECK_PERIOD

WSREP_PROVIDER_EVS_INACTIVE_TIMEOUT

WSREP_PROVIDER_EVS_INFO_LOG_MASK

WSREP_PROVIDER_EVS_INSTALL_TIMEOUT

WSREP_PROVIDER_EVS_JOIN_RETRANS_PERIOD

WSREP_PROVIDER_EVS_KEEPALIVE_PERIOD

WSREP_PROVIDER_EVS_STATS_REPORT_PERIOD

WSREP_PROVIDER_EVS_SUSPECT_TIMEOUT

WSREP_PROVIDER_REPL_CAUSAL_READ_TIMEOUT

Attachments

Issue Links

relates to

MDEV-22570 Split wsrep_provider_options in several options

Closed

Activity

Ascending order - Click to sort in descending order

Ramesh Sivaraman created issue - 2022-12-01 09:41

Ramesh Sivaraman made changes - 2022-12-01 09:42

Field	Original Value	New Value
Link		This issue relates to ~~MDEV-22570~~ [ ~~MDEV-22570~~ ]

Ramesh Sivaraman added a comment - 2022-12-02 04:34

Similarly WSREP_PROVIDER GCS_FC_LIMIT does not allow setting value in kilobyte format.

node1:root@localhost> set global WSREP_PROVIDER_GCS_FC_LIMIT=1K;

ERROR 1232 (42000): Incorrect argument type to variable 'wsrep_provider_gcs_fc_limit'

node1:root@localhost>

It was permissible to set the value through wsrep_provider_options

10.9.5-opt>SET GLOBAL wsrep_provider_options="gcs.fc_limit=1K";

Query OK, 0 rows affected (0.000 sec)

10.9.5-opt>select @@wsrep_provider_options\G

*************************** 1. row ***************************

@@wsrep_provider_options: [..]gcs.fc_debug = 0; gcs.fc_factor = 1.0; gcs.fc_limit = 1K; gcs.fc_master_slave = no;[..]

1 row in set (0.000 sec)

10.9.5-opt>

Ramesh Sivaraman added a comment - 2022-12-02 04:34 Similarly WSREP_PROVIDER GCS_FC_LIMIT does not allow setting value in kilobyte format. node1:root@localhost> set global WSREP_PROVIDER_GCS_FC_LIMIT=1K; ERROR 1232 (42000): Incorrect argument type to variable 'wsrep_provider_gcs_fc_limit' node1:root@localhost> It was permissible to set the value through wsrep_provider_options 10.9.5-opt> SET GLOBAL wsrep_provider_options= "gcs.fc_limit=1K" ; Query OK, 0 rows affected (0.000 sec) 10.9.5-opt> select @@wsrep_provider_options\G *************************** 1. row *************************** @@wsrep_provider_options: [..]gcs.fc_debug = 0; gcs.fc_factor = 1.0; gcs.fc_limit = 1K; gcs.fc_master_slave = no ;[..] 1 row in set (0.000 sec) 10.9.5-opt>

Jan Lindström (Inactive) made changes - 2022-12-02 11:49

Assignee

Jan Lindström [ jplindst ]

Daniele Sciascia [ sciascid ]

Daniele Sciascia added a comment - 2022-12-07 09:55

This bug is not caused by ~~MDEV-22570~~. It is already present in current version and can be reproduced using wsrep_provider_options variable:

SET GLOBAL wsrep_provider_options="evs.causal_keepalive_period=Panyvalue";

SHOW VARIABLES LIKE 'wsrep_provider_options';

results in:

WSREP_PROVIDER_OPTIONS [...] evs.causal_keepalive_period = P; [...]

The source of the issue has been tracked down in galera library: https://github.com/codership/galera/issues/630

Daniele Sciascia added a comment - 2022-12-07 09:55 This bug is not caused by MDEV-22570 . It is already present in current version and can be reproduced using wsrep_provider_options variable: SET GLOBAL wsrep_provider_options="evs.causal_keepalive_period=Panyvalue"; SHOW VARIABLES LIKE 'wsrep_provider_options'; results in: WSREP_PROVIDER_OPTIONS [...] evs.causal_keepalive_period = P; [...] The source of the issue has been tracked down in galera library: https://github.com/codership/galera/issues/630

Sergei Golubchik made changes - 2023-01-23 10:20

Affects Version/s		11.0.0 [ 28500 ]
Affects Version/s	10.11 [ 27614 ]

Sergei Golubchik made changes - 2023-01-23 10:20

Fix Version/s		11.0 [ 28320 ]
Fix Version/s	10.11 [ 27614 ]

Ralf Gebhardt made changes - 2023-01-23 10:34

Link

This issue is caused by ~~MDEV-22570~~ [ ~~MDEV-22570~~ ]

Ralf Gebhardt made changes - 2023-01-23 10:34

Link

This issue relates to ~~MDEV-22570~~ [ ~~MDEV-22570~~ ]

Ralf Gebhardt made changes - 2023-01-23 10:36

Link

This issue relates to ~~MDEV-22570~~ [ ~~MDEV-22570~~ ]

Ralf Gebhardt made changes - 2023-01-23 10:36

Link

This issue is caused by ~~MDEV-22570~~ [ ~~MDEV-22570~~ ]

Ramesh Sivaraman made changes - 2023-02-09 11:30

Affects Version/s		10.4 [ 22408 ]
Affects Version/s		10.5 [ 23123 ]
Affects Version/s		10.6 [ 24028 ]
Affects Version/s		10.7 [ 24805 ]
Affects Version/s		10.8 [ 26121 ]
Affects Version/s		10.9 [ 26905 ]
Affects Version/s		10.10 [ 27530 ]
Affects Version/s		10.11 [ 27614 ]

Ramesh Sivaraman made changes - 2023-02-09 11:31

Fix Version/s		10.4 [ 22408 ]
Fix Version/s		10.5 [ 23123 ]
Fix Version/s		10.6 [ 24028 ]
Fix Version/s		10.7 [ 24805 ]
Fix Version/s		10.8 [ 26121 ]
Fix Version/s		10.9 [ 26905 ]
Fix Version/s		10.10 [ 27530 ]
Fix Version/s		10.11 [ 27614 ]

Ramesh Sivaraman added a comment - 2023-02-09 11:34

This issue is fixed in the latest Galera revision

10.6.12-dbg>SET GLOBAL wsrep_provider_options="evs.causal_keepalive_period=Panyvalue";

ERROR 1210 (HY000): Incorrect arguments to SET

10.6.12-dbg>

Commit info

-------------------

commit 06a0c28592fb5c7b21413d922b1671cc070ab4c6 (grafted, HEAD -> mariadb-4.x, origin/mariadb-4.x)

Author: Jan Lindström <jan.lindstrom@mariadb.com>

Date:   Fri Jan 27 07:46:18 2023 +0200

    Merge branch wsrep/4.ee into mariadb-4.x

Ramesh Sivaraman added a comment - 2023-02-09 11:34 This issue is fixed in the latest Galera revision 10.6.12-dbg> SET GLOBAL wsrep_provider_options= "evs.causal_keepalive_period=Panyvalue" ; ERROR 1210 (HY000): Incorrect arguments to SET 10.6.12-dbg> Commit info ------------------- commit 06a0c28592fb5c7b21413d922b1671cc070ab4c6 (grafted, HEAD -> mariadb-4.x, origin/mariadb-4.x) Author: Jan Lindström <jan.lindstrom@mariadb.com> Date : Fri Jan 27 07:46:18 2023 +0200 Merge branch wsrep/4.ee into mariadb-4.x

Julien Fritsch made changes - 2023-03-03 17:33

Fix Version/s

10.7 [ 24805 ]

Ralf Gebhardt made changes - 2023-03-08 13:42

Assignee

Daniele Sciascia [ sciascid ]

Julius Goryavsky [ sysprg ]

Jan Lindström added a comment - 2023-03-23 10:23

ralf.gebhardt This fix is released on Galera library 26.4.14. In my understanding it is not fixed on 25.3.x.

Jan Lindström added a comment - 2023-03-23 10:23 ralf.gebhardt This fix is released on Galera library 26.4.14. In my understanding it is not fixed on 25.3.x.

Julius Goryavsky added a comment - 2023-03-28 12:30

Already fixed with Galera 26.4.14 and current wsrep-lib

Julius Goryavsky added a comment - 2023-03-28 12:30 Already fixed with Galera 26.4.14 and current wsrep-lib

Julius Goryavsky made changes - 2023-03-28 12:30

Fix Version/s		10.4.29 [ 28510 ]
Fix Version/s		10.5.20 [ 28512 ]
Fix Version/s		10.6.13 [ 28514 ]
Fix Version/s		10.8.8 [ 28518 ]
Fix Version/s		10.9.6 [ 28520 ]
Fix Version/s		10.10.4 [ 28522 ]
Fix Version/s		10.11.3 [ 28524 ]
Fix Version/s	10.4 [ 22408 ]
Fix Version/s	10.5 [ 23123 ]
Fix Version/s	10.6 [ 24028 ]
Fix Version/s	10.8 [ 26121 ]
Fix Version/s	10.9 [ 26905 ]
Fix Version/s	10.10 [ 27530 ]
Fix Version/s	10.11 [ 27614 ]
Fix Version/s	11.0 [ 28320 ]
Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Closed [ 6 ]

People

Assignee:: Julius Goryavsky

Reporter:: Ramesh Sivaraman

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 2022-12-01 09:41

Updated:: 2023-03-28 12:30

Resolved:: 2023-03-28 12:30

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server

Details

Description

Attachments

Issue Links

Activity

People

Dates

Git Integration