After MDEV-21743 the SUPER privilege was split into many fine-grained privileges. But still, according to MDEV-21743
The SUPER privilege as such should still remain as an alias for all these smaller privileges
For example, to set a binlog format one needs either BINLOG ADMIN or SUPER privilege.
This task is about removing SUPER privilege check from all these actions that have a dedicated privilege. For example, one will need to have BINLOG ADMIN to change the binlog format, SUPER will not be sufficient anymore.
When upgrading from an older version everyone having SUPER should automatically get (for example) BINLOG ADMIN.
A small cosmetic note:
Consider preserving "--echo # Start of X.Y tests" lines, in this patch and generally.
Alexander Barkov
added a comment - Hi serg . The patch https://github.com/MariaDB/server/commit/ae4101eb7359f148938e604634685dcf2de93135 is OK to push.
A small cosmetic note:
Consider preserving "--echo # Start of X.Y tests" lines, in this patch and generally.
People
Sergei Golubchik
Sergei Golubchik
Votes:
0Vote for this issue
Watchers:
6Start watching this issue
Dates
Created:
Updated:
Resolved:
Git Integration
Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.
{"report":{"fcp":1120.6999998092651,"ttfb":222.69999980926514,"pageVisibility":"visible","entityId":115067,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"195b5eb4-4de2-41ee-8091-30c13ae74477","navigationType":0,"readyForUser":1196.5,"redirectCount":0,"resourceLoadedEnd":1151.6999998092651,"resourceLoadedStart":227.69999980926514,"resourceTiming":[{"duration":351.19999980926514,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":227.69999980926514,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":227.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":578.8999996185303,"responseStart":0,"secureConnectionStart":0},{"duration":351.30000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":227.89999961853027,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":227.89999961853027,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":579.1999998092651,"responseStart":0,"secureConnectionStart":0},{"duration":360.40000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":228.09999990463257,"connectEnd":228.09999990463257,"connectStart":228.09999990463257,"domainLookupEnd":228.09999990463257,"domainLookupStart":228.09999990463257,"fetchStart":228.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":228.09999990463257,"responseEnd":588.5,"responseStart":588.5,"secureConnectionStart":228.09999990463257},{"duration":438.40000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":228.2999997138977,"connectEnd":228.2999997138977,"connectStart":228.2999997138977,"domainLookupEnd":228.2999997138977,"domainLookupStart":228.2999997138977,"fetchStart":228.2999997138977,"redirectEnd":0,"redirectStart":0,"requestStart":228.2999997138977,"responseEnd":666.6999998092651,"responseStart":666.6999998092651,"secureConnectionStart":228.2999997138977},{"duration":443.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":228.5,"connectEnd":228.5,"connectStart":228.5,"domainLookupEnd":228.5,"domainLookupStart":228.5,"fetchStart":228.5,"redirectEnd":0,"redirectStart":0,"requestStart":228.5,"responseEnd":671.5999999046326,"responseStart":671.5999999046326,"secureConnectionStart":228.5},{"duration":443.30000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":228.69999980926514,"connectEnd":228.69999980926514,"connectStart":228.69999980926514,"domainLookupEnd":228.69999980926514,"domainLookupStart":228.69999980926514,"fetchStart":228.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":228.69999980926514,"responseEnd":672,"responseStart":672,"secureConnectionStart":228.69999980926514},{"duration":443.2999997138977,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":229,"connectEnd":229,"connectStart":229,"domainLookupEnd":229,"domainLookupStart":229,"fetchStart":229,"redirectEnd":0,"redirectStart":0,"requestStart":229,"responseEnd":672.2999997138977,"responseStart":672.2999997138977,"secureConnectionStart":229},{"duration":503.7999997138977,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":229.09999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":229.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":732.8999996185303,"responseStart":0,"secureConnectionStart":0},{"duration":443.59999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":229.19999980926514,"connectEnd":229.19999980926514,"connectStart":229.19999980926514,"domainLookupEnd":229.19999980926514,"domainLookupStart":229.19999980926514,"fetchStart":229.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":229.19999980926514,"responseEnd":672.7999997138977,"responseStart":672.7999997138977,"secureConnectionStart":229.19999980926514},{"duration":503.7000002861023,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":229.39999961853027,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":229.39999961853027,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":733.0999999046326,"responseStart":0,"secureConnectionStart":0},{"duration":443.90000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":229.59999990463257,"connectEnd":229.59999990463257,"connectStart":229.59999990463257,"domainLookupEnd":229.59999990463257,"domainLookupStart":229.59999990463257,"fetchStart":229.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":229.59999990463257,"responseEnd":673.5,"responseStart":673.5,"secureConnectionStart":229.59999990463257},{"duration":694.9000000953674,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":234.89999961853027,"connectEnd":234.89999961853027,"connectStart":234.89999961853027,"domainLookupEnd":234.89999961853027,"domainLookupStart":234.89999961853027,"fetchStart":234.89999961853027,"redirectEnd":0,"redirectStart":0,"requestStart":234.89999961853027,"responseEnd":929.7999997138977,"responseStart":929.7999997138977,"secureConnectionStart":234.89999961853027},{"duration":916.4000000953674,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":235.2999997138977,"connectEnd":235.2999997138977,"connectStart":235.2999997138977,"domainLookupEnd":235.2999997138977,"domainLookupStart":235.2999997138977,"fetchStart":235.2999997138977,"redirectEnd":0,"redirectStart":0,"requestStart":235.2999997138977,"responseEnd":1151.6999998092651,"responseStart":1151.6999998092651,"secureConnectionStart":235.2999997138977},{"duration":185,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":745.1999998092651,"connectEnd":745.1999998092651,"connectStart":745.1999998092651,"domainLookupEnd":745.1999998092651,"domainLookupStart":745.1999998092651,"fetchStart":745.1999998092651,"redirectEnd":0,"redirectStart":0,"requestStart":745.1999998092651,"responseEnd":930.1999998092651,"responseStart":930.1999998092651,"secureConnectionStart":745.1999998092651}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":56,"responseStart":223,"responseEnd":232,"domLoading":226,"domInteractive":1256,"domContentLoadedEventStart":1256,"domContentLoadedEventEnd":1298,"domComplete":1967,"loadEventStart":1967,"loadEventEnd":1967,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1237.7999997138977},{"name":"bigPipe.sidebar-id.end","time":1238.8999996185303},{"name":"bigPipe.activity-panel-pipe-id.start","time":1239.0999999046326},{"name":"bigPipe.activity-panel-pipe-id.end","time":1240.2999997138977},{"name":"activityTabFullyLoaded","time":1313.6999998092651}],"measures":[],"correlationId":"732781edbf2778","effectiveType":"4g","downlink":9.7,"rtt":0,"serverDuration":113,"dbReadsTimeInMs":13,"dbConnsTimeInMs":22,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
It is ok to push it to the main branch