Details
Description
While analysing MDEV-29190, marko voiced concerns over tpool::cache thread safety, mainly over the use of std::vector methods push_back(), pop_back(), and size()
It was not apparent by reading the code that the cache does not grow, and the vector is not getting reallocated (this does not happen, because push_back() should only be applied to prevously pop_back()ed element)
Also, there was a complaint that it is hard to impossible to debug the elements that were "borrowed" from cache, and there is not much comments for the class.
Attachments
Issue Links
- causes
-
MDEV-32861 InnoDB hangs when running out of I/O slots
-
- Closed
-
Activity
Field | Original Value | New Value |
---|---|---|
Component/s | OTHER [ 10125 ] | |
Fix Version/s | 10.6.10 [ 28407 ] | |
Fix Version/s | 10.7.6 [ 28408 ] | |
Fix Version/s | 10.8.5 [ 28308 ] | |
Fix Version/s | 10.9.3 [ 28409 ] | |
Fix Version/s | 10.10.2 [ 28410 ] | |
Resolution | Fixed [ 1 ] | |
Status | Open [ 1 ] | Closed [ 6 ] |
Link |
This issue causes |