While analysing MDEV-29190, marko voiced concerns over tpool::cache thread safety, mainly over the use of std::vector methods push_back(), pop_back(), and size()
It was not apparent by reading the code that the cache does not grow, and the vector is not getting reallocated (this does not happen, because push_back() should only be applied to prevously pop_back()ed element)
Also, there was a complaint that it is hard to impossible to debug the elements that were "borrowed" from cache, and there is not much comments for the class.
- causes
-
MDEV-32861
InnoDB hangs when running out of I/O slots
-
-
Closed
{"report":{"fcp":1138.8000001907349,"ttfb":190,"pageVisibility":"visible","entityId":114099,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":32,"apdex":0.5,"journeyId":"7ea262d4-e1be-40b3-9267-f9ffd45b055c","navigationType":0,"readyForUser":1209.6999998092651,"redirectCount":0,"resourceLoadedEnd":1293.1999998092651,"resourceLoadedStart":200.10000038146973,"resourceTiming":[{"duration":378.69999980926514,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":200.10000038146973,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":200.10000038146973,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":578.8000001907349,"responseStart":0,"secureConnectionStart":0},{"duration":378.80000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/2bf333562ca6724060a9d5f1535471f6/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":200.30000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":200.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":579.1000003814697,"responseStart":0,"secureConnectionStart":0},{"duration":392.69999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":200.5,"connectEnd":200.5,"connectStart":200.5,"domainLookupEnd":200.5,"domainLookupStart":200.5,"fetchStart":200.5,"redirectEnd":0,"redirectStart":0,"requestStart":200.5,"responseEnd":593.1999998092651,"responseStart":593.1999998092651,"secureConnectionStart":200.5},{"duration":420.9000005722046,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/2bf333562ca6724060a9d5f1535471f6/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":200.69999980926514,"connectEnd":200.69999980926514,"connectStart":200.69999980926514,"domainLookupEnd":200.69999980926514,"domainLookupStart":200.69999980926514,"fetchStart":200.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":200.69999980926514,"responseEnd":621.6000003814697,"responseStart":621.6000003814697,"secureConnectionStart":200.69999980926514},{"duration":423.80000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":201,"connectEnd":201,"connectStart":201,"domainLookupEnd":201,"domainLookupStart":201,"fetchStart":201,"redirectEnd":0,"redirectStart":0,"requestStart":201,"responseEnd":624.8000001907349,"responseStart":624.8000001907349,"secureConnectionStart":201},{"duration":424.1000003814697,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":201.19999980926514,"connectEnd":201.19999980926514,"connectStart":201.19999980926514,"domainLookupEnd":201.19999980926514,"domainLookupStart":201.19999980926514,"fetchStart":201.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":201.19999980926514,"responseEnd":625.3000001907349,"responseStart":625.3000001907349,"secureConnectionStart":201.19999980926514},{"duration":424.5999994277954,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":201.30000019073486,"connectEnd":201.30000019073486,"connectStart":201.30000019073486,"domainLookupEnd":201.30000019073486,"domainLookupStart":201.30000019073486,"fetchStart":201.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":201.30000019073486,"responseEnd":625.8999996185303,"responseStart":625.8999996185303,"secureConnectionStart":201.30000019073486},{"duration":425.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":201.39999961853027,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":201.39999961853027,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":626.8999996185303,"responseStart":0,"secureConnectionStart":0},{"duration":424.80000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":201.5,"connectEnd":201.5,"connectStart":201.5,"domainLookupEnd":201.5,"domainLookupStart":201.5,"fetchStart":201.5,"redirectEnd":0,"redirectStart":0,"requestStart":201.5,"responseEnd":626.3000001907349,"responseStart":626.3000001907349,"secureConnectionStart":201.5},{"duration":429.80000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":201.69999980926514,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":201.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":631.5,"responseStart":0,"secureConnectionStart":0},{"duration":425.1000003814697,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":201.89999961853027,"connectEnd":201.89999961853027,"connectStart":201.89999961853027,"domainLookupEnd":201.89999961853027,"domainLookupStart":201.89999961853027,"fetchStart":201.89999961853027,"redirectEnd":0,"redirectStart":0,"requestStart":201.89999961853027,"responseEnd":627,"responseStart":627,"secureConnectionStart":201.89999961853027},{"duration":692.6000003814697,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":202.69999980926514,"connectEnd":202.69999980926514,"connectStart":202.69999980926514,"domainLookupEnd":202.69999980926514,"domainLookupStart":202.69999980926514,"fetchStart":202.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":202.69999980926514,"responseEnd":895.3000001907349,"responseStart":895.3000001907349,"secureConnectionStart":202.69999980926514},{"duration":1090.3999996185303,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":202.80000019073486,"connectEnd":202.80000019073486,"connectStart":202.80000019073486,"domainLookupEnd":202.80000019073486,"domainLookupStart":202.80000019073486,"fetchStart":202.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":202.80000019073486,"responseEnd":1293.1999998092651,"responseStart":1293.1999998092651,"secureConnectionStart":202.80000019073486},{"duration":433,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":847.3000001907349,"connectEnd":847.3000001907349,"connectStart":847.3000001907349,"domainLookupEnd":847.3000001907349,"domainLookupStart":847.3000001907349,"fetchStart":847.3000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":847.3000001907349,"responseEnd":1280.3000001907349,"responseStart":1280.3000001907349,"secureConnectionStart":847.3000001907349}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":48,"responseStart":190,"responseEnd":198,"domLoading":198,"domInteractive":1319,"domContentLoadedEventStart":1319,"domContentLoadedEventEnd":1385,"domComplete":2523,"loadEventStart":2523,"loadEventEnd":2525,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1295.8000001907349},{"name":"bigPipe.sidebar-id.end","time":1296.6999998092651},{"name":"bigPipe.activity-panel-pipe-id.start","time":1296.8999996185303},{"name":"bigPipe.activity-panel-pipe-id.end","time":1299.1999998092651},{"name":"activityTabFullyLoaded","time":1395.5}],"measures":[],"correlationId":"dc66f074e14b0b","effectiveType":"4g","downlink":9.7,"rtt":0,"serverDuration":90,"dbReadsTimeInMs":11,"dbConnsTimeInMs":18,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}