Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-28854

Disallow INSERT DELAYED on Spider table

Details

    Description

      Spider supports (or at least allows) INSERT DELAYED but the documentation says the following:

      INSERT DELAYED works only with MyISAM, MEMORY, ARCHIVE, and BLACKHOLE tables. If you execute INSERT DELAYED with another storage engine, you will get an error like this: ERROR 1616 (HY000): DELAYED option not supported for table 'tab_name'

      https://mariadb.com/kb/en/insert-delayed/

      Moreover, a Spider table can be considered to be transactional at least when it is backed by a transactional table (e.g., InnoDB table). It doesn't make sense for a transactional storage engine to support INSERT DELAYED.

      Based on the two facts above, we conclude that allowing INSERT DELAYED on Spider tables is a bug. Disallow INSERT DELAYED. More precisely, remove HA_CAN_INSERT_DELAYED from Spider's table flag and add a test to make sure that INSERT DELAYED is correctly disallowed. Also, remove the code for handling INSERT DELAYED.

      Attachments

        Issue Links

          Activity

            Transition Time In Source Status Execution Times
            Nayuta Yanagisawa (Inactive) made transition -
            Open In Progress
            9d 22h 52m 1
            Nayuta Yanagisawa (Inactive) made transition -
            In Progress In Review
            12s 1
            Nayuta Yanagisawa (Inactive) made transition -
            In Review Closed
            1d 16h 18m 1

            People

              nayuta-yanagisawa Nayuta Yanagisawa (Inactive)
              nayuta-yanagisawa Nayuta Yanagisawa (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.