Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-28762

recursive call of some json functions without stack control

Details

    Description

      do_merge() (sql/item_jsonfunc.c) has recursive calls but do not have check_stack_overrun

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-33209 Stack overflow in main.json_debug_nonembedded due to incorrect debug injection

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            Descending order - Click to sort in ascending order
            marko Marko Mäkelä added a comment -

            The debug instrumentation was optimized away by clang-15 but not GCC 12, so I improved with it a call to a non-inline function.

            marko Marko Mäkelä added a comment - The debug instrumentation was optimized away by clang-15 but not GCC 12, so I improved with it a call to a non-inline function .
            sanja Oleksandr Byelkin added a comment -

            OK to push

            sanja Oleksandr Byelkin added a comment - OK to push
            rucha174 Rucha Deodhar added a comment - - edited

            Patch:
            10.3: https://github.com/MariaDB/server/commit/dbe39f14fede0f5fbe0ce7470ae4fde21767842c
            10.6: https://github.com/MariaDB/server/commit/0ea221e12bb4b298b728cd0e0f2651173cbe2347
            10.9:
            https://github.com/MariaDB/server/commit/5ad14ab272e7770a52f3cf20369e7ab7b14b51d6

            rucha174 Rucha Deodhar added a comment - - edited Patch: 10.3: https://github.com/MariaDB/server/commit/dbe39f14fede0f5fbe0ce7470ae4fde21767842c 10.6: https://github.com/MariaDB/server/commit/0ea221e12bb4b298b728cd0e0f2651173cbe2347 10.9: https://github.com/MariaDB/server/commit/5ad14ab272e7770a52f3cf20369e7ab7b14b51d6

            People

              rucha174 Rucha Deodhar
              sanja Oleksandr Byelkin
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.