[MDEV-28747] Possible problem with ha_innobase::build_template - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Affects Version/s: 10.4(EOL), 10.5, 10.6, 10.7(EOL), 10.8(EOL), 10.9(EOL)
Fix Version/s: 10.4.26, 10.5.17, 10.6.9, 10.7.5, 10.8.4, 10.9.2
Component/s: Storage Engine - InnoDB
Labels:
None

Description

While working on MDEV-27366 a potentially problematic piece of code was found in /storage/innobase/handler/ha_innodb.cc:

             if ((active_index != MAX_KEY

	            && active_index == pushed_idx_cond_keyno)

	            || (pushed_rowid_filter && rowid_filter_is_active)) {

		       /* Push down an index condition or an end_range check. */

...

		if (active_index == pushed_idx_cond_keyno) {

			m_prebuilt->idx_cond = this;

The last condition satisfies when

active_index == pushed_idx_cond_keyno == MAX_KEY

which doesn't look correct. After fixing MDEV-27366 there is no test case to reproduce this scenario.

Attachments

Issue Links

relates to

MDEV-27366 SIGSEGV in handler_index_cond_check on SELECT in connection with rowid_filter setting

In Review

Activity

Ascending order - Click to sort in descending order

Oleg Smirnov created issue - 2022-06-04 05:05

Oleg Smirnov made changes - 2022-06-04 05:07

Field	Original Value	New Value
Fix Version/s		10.4 [ 22408 ]
Fix Version/s		10.5 [ 23123 ]
Fix Version/s		10.6 [ 24028 ]
Fix Version/s		10.7 [ 24805 ]
Fix Version/s		10.8 [ 26121 ]
Fix Version/s		10.9 [ 26905 ]

Oleg Smirnov made changes - 2022-06-04 05:07

Status

Open [ 1 ]

In Progress [ 3 ]

Oleg Smirnov made changes - 2022-06-04 05:36

Description

While working on MDEV-27366 a potentially problematic piece of code was found in /storage/innobase/handler/ha_innodb.cc:
{code}
if (active_index == pushed_idx_cond_keyno) {
m_prebuilt->idx_cond = this;
}
{code}

This condition satisfies when {code}active_index == pushed_idx_cond_keyno == MAX_KEY{code} which doesn't look correct. After fixing MDEV-27366 there is no test case to reproduce this scenario.

While working on MDEV-27366 a potentially problematic piece of code was found in /storage/innobase/handler/ha_innodb.cc:
{code}
if ((active_index != MAX_KEY
&& active_index == pushed_idx_cond_keyno)

|| (pushed_rowid_filter && rowid_filter_is_active)) {

/* Push down an index condition or an end_range check. */

...

if (active_index == pushed_idx_cond_keyno) {

m_prebuilt->idx_cond = this;

}

}

{code}

This condition satisfies when {code}active_index == pushed_idx_cond_keyno == MAX_KEY{code} which doesn't look correct. After fixing MDEV-27366 there is no test case to reproduce this scenario.

Oleg Smirnov made changes - 2022-06-04 05:38

Description

While working on MDEV-27366 a potentially problematic piece of code was found in /storage/innobase/handler/ha_innodb.cc:
{code}
if ((active_index != MAX_KEY
&& active_index == pushed_idx_cond_keyno)
|| (pushed_rowid_filter && rowid_filter_is_active)) {
/* Push down an index condition or an end_range check. */
...
if (active_index == pushed_idx_cond_keyno) {
m_prebuilt->idx_cond = this;
}
}
{code}

The last condition satisfies when {code}active_index == pushed_idx_cond_keyno == MAX_KEY{code} which doesn't look correct. After fixing MDEV-27366 there is no test case to reproduce this scenario.

Oleg Smirnov made changes - 2022-06-04 06:32

Assignee	Oleg Smirnov [ JIRAUSER50405 ]	Marko Mäkelä [ marko ]
Status	In Progress [ 3 ]	In Review [ 10002 ]

Roel Van de Paar made changes - 2022-06-05 22:00

Link

This issue relates to MDEV-27366 [ MDEV-27366 ]

Marko Mäkelä made changes - 2022-06-06 05:58

Assignee	Marko Mäkelä [ marko ]	Oleg Smirnov [ JIRAUSER50405 ]
Status	In Review [ 10002 ]	Stalled [ 10000 ]

Oleg Smirnov made changes - 2022-06-08 16:49

Component/s		Storage Engine - InnoDB [ 10129 ]
Fix Version/s		10.4.26 [ 27511 ]
Fix Version/s		10.5.17 [ 27509 ]
Fix Version/s		10.6.9 [ 27507 ]
Fix Version/s		10.7.5 [ 27505 ]
Fix Version/s		10.8.4 [ 27503 ]
Fix Version/s		10.9.2 [ 27115 ]
Fix Version/s	10.4 [ 22408 ]
Fix Version/s	10.5 [ 23123 ]
Fix Version/s	10.6 [ 24028 ]
Fix Version/s	10.7 [ 24805 ]
Fix Version/s	10.8 [ 26121 ]
Fix Version/s	10.9 [ 26905 ]
Resolution		Fixed [ 1 ]
Status	Stalled [ 10000 ]	Closed [ 6 ]

People

Assignee:: Oleg Smirnov

Reporter:: Oleg Smirnov

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 2022-06-04 05:05

Updated:: 2022-06-08 16:49

Resolved:: 2022-06-08 16:49

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server

Details

Description

Attachments

Issue Links

Activity

People

Dates

Git Integration