Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-27721

rpl.rpl_relay_max_extension test is not FreeBSD-compatible

Details

    Description

      $ perl ./mtr rpl.rpl_relay_max_extension --mem
       
      sed: 1: "/usr/home/ec2-user/mari ...": extra characters at the end of h command
      mysqltest: At line 52: exec of 'sed -i "s/slave-relay-bin.000002/slave-relay-bin.999997/g" /usr/home/ec2-user/mariadb-server/mysql-test/var/mysqld.2/data//relay-log.info' failed, error: 256, status: 1, errno: 22
      

      In FreeBSD, -i requires an argument, which is apparently why things go wrong.
      Something like this may fix the immediate problem

      sed -i='' ...
      

      and Linux seems to accept it too, but I don't know how much more portable it is, and anyway it looks hack-ish. Maybe it makes more sense to get rid of inline altogether, especially since it's apparently the only test that does it.
      Or disable the test for freebsd if you so prefer.

      Attachments

        Activity

          elenst Elena Stepanova created issue -
          elenst Elena Stepanova made changes -
          Field Original Value New Value
          Component/s Platform FreeBSD [ 10139 ]
          Elkin Andrei Elkin added a comment -

          The latter option of the description is taken virtually harmlessly for a bug the test was
          written for. Thanks elenst for spelling out the cause and suggestions!

          Elkin Andrei Elkin added a comment - The latter option of the description is taken virtually harmlessly for a bug the test was written for. Thanks elenst for spelling out the cause and suggestions!
          Elkin Andrei Elkin made changes -
          Fix Version/s 10.2.42 [ 26803 ]
          Fix Version/s 10.3.33 [ 26805 ]
          Fix Version/s 10.4.23 [ 26807 ]
          Fix Version/s 10.5.14 [ 26809 ]
          Fix Version/s 10.6.6 [ 26811 ]
          Fix Version/s 10.7.2 [ 26813 ]
          Fix Version/s 10.8.1 [ 26815 ]
          Fix Version/s 10.2 [ 14601 ]
          Fix Version/s 10.3 [ 22126 ]
          Fix Version/s 10.4 [ 22408 ]
          Fix Version/s 10.5 [ 23123 ]
          Fix Version/s 10.6 [ 24028 ]
          Fix Version/s 10.7 [ 24805 ]
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Closed [ 6 ]
          Elkin Andrei Elkin made changes -
          Fix Version/s 10.2.43 [ 26804 ]
          Fix Version/s 10.3.34 [ 26806 ]
          Fix Version/s 10.4.24 [ 26808 ]
          Fix Version/s 10.5.15 [ 26810 ]
          Fix Version/s 10.6.7 [ 26812 ]
          Fix Version/s 10.7.3 [ 26814 ]
          Fix Version/s 10.8.2 [ 26816 ]
          Fix Version/s 10.2.42 [ 26803 ]
          Fix Version/s 10.3.33 [ 26805 ]
          Fix Version/s 10.4.23 [ 26807 ]
          Fix Version/s 10.5.14 [ 26809 ]
          Fix Version/s 10.6.6 [ 26811 ]
          Fix Version/s 10.7.2 [ 26813 ]
          Fix Version/s 10.8.1 [ 26815 ]

          People

            Elkin Andrei Elkin
            elenst Elena Stepanova
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.