Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-27474

Spider: remove #WITH_PARTITION_STORAGE_ENGINE

Details

    Description

      #ifdef WITH_PARTITION_STORAGE_ENGINE ... #endif appears frequently in the Spider code base. However, Spider is disabled if the partitioning engine is disabled. So, there is no need to maintain such #ifdefs.

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. MDEV-26178 Spider: remove unnecessary #ifdef and dead code in #ifdef

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) created issue -
            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) made changes -
            Field Original Value New Value
            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) made changes -
            Summary Disable Spider if partitioning is disabled Disable Spider too if partitioning is disabled
            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) made changes -
            Summary Disable Spider too if partitioning is disabled Spider: remove #WITH_PARTITION_STORAGE_ENGINE
            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) made changes -
            Description {{#ifdef WITH_PARTITION_STORAGE_ENGINE ... #endif}} appears frequently in the Spider code base. However, I don't think that the Spider is well-tested without the partitioning engine and it is likely not to work in the configuration. So, by CMakeList.txt, disable Spider if the partitioning engine is disabled. And then, remove all the occurrence of {{WITH_PARTITION_STORAGE_ENGINE}}. {{#ifdef WITH_PARTITION_STORAGE_ENGINE ... #endif}} appears frequently in the Spider code base. However, Spider is disabled if the partitioning engine is disabled. So, there is no need to maintain such #ifdefs.
            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) added a comment -

            https://github.com/MariaDB/server/commit/9d1af70a690d71dc2c30c3dbb34100bcdbee0e39

            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) added a comment - https://github.com/MariaDB/server/commit/9d1af70a690d71dc2c30c3dbb34100bcdbee0e39
            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) made changes -
            Assignee Nayuta Yanagisawa [ JIRAUSER47117 ] Alexey Botchkov [ holyfoot ]
            Status In Progress [ 3 ] In Review [ 10002 ]
            holyfoot Alexey Botchkov added a comment -

            Ok to push.

            holyfoot Alexey Botchkov added a comment - Ok to push.
            holyfoot Alexey Botchkov made changes -
            Assignee Alexey Botchkov [ holyfoot ] Nayuta Yanagisawa [ JIRAUSER47117 ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) made changes -
            Fix Version/s 10.9.1 [ 27114 ]
            Fix Version/s 10.9 [ 26905 ]
            Resolution Done [ 10200 ]
            Status Stalled [ 10000 ] Closed [ 6 ]

            People

              nayuta-yanagisawa Nayuta Yanagisawa (Inactive)
              nayuta-yanagisawa Nayuta Yanagisawa (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.