Hi, developers, thank you for your checking. It seems there is a (potential) deadlock bug in the below code. The function extract_worker_thread_func is not thread-safe, because there is a cyclic acquisition order between the ctxt->mutex and entry->mutex.
{color:#DE350B}extract_worker_thread_func(void *arg)
|
{
|
|
while (1) {
|
pthread_mutex_lock(ctxt->mutex);
|
...;
|
|
pthread_mutex_lock(&entry->mutex); //ctxt->mutex-->entry->mutex
|
|
pthread_mutex_unlock(ctxt->mutex);
|
...;
|
|
if (chunk.type == XB_CHUNK_TYPE_EOF) {
|
pthread_mutex_lock(ctxt->mutex); // entry->mutex-> ctxt->mutex
|
pthread_mutex_unlock(&entry->mutex);
|
my_hash_delete(ctxt->filehash, (uchar *) entry);
|
pthread_mutex_unlock(ctxt->mutex);
|
|
continue;
|
}
|
...;
|
pthread_mutex_unlock(&entry->mutex);
|
}
|
}{color}
|
https://github.com/MariaDB/server/blob/76f4a78ba2639b5abd01a88b24a3c509c11530ce/extra/mariabackup/xbstream.cc#L381-L478
{"report":{"fcp":810.8999996185303,"ttfb":194.79999923706055,"pageVisibility":"visible","entityId":102567,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"62008257-f3f4-4514-a195-c9dbff22ff65","navigationType":0,"readyForUser":895.8999996185303,"redirectCount":0,"resourceLoadedEnd":721.3999996185303,"resourceLoadedStart":200.39999961853027,"resourceTiming":[{"duration":68.80000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":200.39999961853027,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":200.39999961853027,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":269.19999980926514,"responseStart":0,"secureConnectionStart":0},{"duration":69,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/2bf333562ca6724060a9d5f1535471f6/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":200.69999980926514,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":200.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":269.69999980926514,"responseStart":0,"secureConnectionStart":0},{"duration":78.39999961853027,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":200.89999961853027,"connectEnd":200.89999961853027,"connectStart":200.89999961853027,"domainLookupEnd":200.89999961853027,"domainLookupStart":200.89999961853027,"fetchStart":200.89999961853027,"redirectEnd":0,"redirectStart":0,"requestStart":200.89999961853027,"responseEnd":279.29999923706055,"responseStart":279.29999923706055,"secureConnectionStart":200.89999961853027},{"duration":164.69999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/2bf333562ca6724060a9d5f1535471f6/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":201.0999994277954,"connectEnd":201.0999994277954,"connectStart":201.0999994277954,"domainLookupEnd":201.0999994277954,"domainLookupStart":201.0999994277954,"fetchStart":201.0999994277954,"redirectEnd":0,"redirectStart":0,"requestStart":201.0999994277954,"responseEnd":365.79999923706055,"responseStart":365.79999923706055,"secureConnectionStart":201.0999994277954},{"duration":168.30000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":201.29999923706055,"connectEnd":201.29999923706055,"connectStart":201.29999923706055,"domainLookupEnd":201.29999923706055,"domainLookupStart":201.29999923706055,"fetchStart":201.29999923706055,"redirectEnd":0,"redirectStart":0,"requestStart":201.29999923706055,"responseEnd":369.5999994277954,"responseStart":369.5999994277954,"secureConnectionStart":201.29999923706055},{"duration":168.5999994277954,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":201.5,"connectEnd":201.5,"connectStart":201.5,"domainLookupEnd":201.5,"domainLookupStart":201.5,"fetchStart":201.5,"redirectEnd":0,"redirectStart":0,"requestStart":201.5,"responseEnd":370.0999994277954,"responseStart":370.0999994277954,"secureConnectionStart":201.5},{"duration":168.80000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":201.69999980926514,"connectEnd":201.69999980926514,"connectStart":201.69999980926514,"domainLookupEnd":201.69999980926514,"domainLookupStart":201.69999980926514,"fetchStart":201.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":201.69999980926514,"responseEnd":370.5,"responseStart":370.5,"secureConnectionStart":201.69999980926514},{"duration":225.80000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":201.89999961853027,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":201.89999961853027,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":427.69999980926514,"responseStart":0,"secureConnectionStart":0},{"duration":168.9000005722046,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":202.0999994277954,"connectEnd":202.0999994277954,"connectStart":202.0999994277954,"domainLookupEnd":202.0999994277954,"domainLookupStart":202.0999994277954,"fetchStart":202.0999994277954,"redirectEnd":0,"redirectStart":0,"requestStart":202.0999994277954,"responseEnd":371,"responseStart":371,"secureConnectionStart":202.0999994277954},{"duration":225.5999994277954,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":202.19999980926514,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":202.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":427.79999923706055,"responseStart":0,"secureConnectionStart":0},{"duration":169.10000038146973,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":202.39999961853027,"connectEnd":202.39999961853027,"connectStart":202.39999961853027,"domainLookupEnd":202.39999961853027,"domainLookupStart":202.39999961853027,"fetchStart":202.39999961853027,"redirectEnd":0,"redirectStart":0,"requestStart":202.39999961853027,"responseEnd":371.5,"responseStart":371.5,"secureConnectionStart":202.39999961853027},{"duration":315.5999994277954,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":203.19999980926514,"connectEnd":203.19999980926514,"connectStart":203.19999980926514,"domainLookupEnd":203.19999980926514,"domainLookupStart":203.19999980926514,"fetchStart":203.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":203.19999980926514,"responseEnd":518.7999992370605,"responseStart":518.7999992370605,"secureConnectionStart":203.19999980926514},{"duration":316.19999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":203.19999980926514,"connectEnd":203.19999980926514,"connectStart":203.19999980926514,"domainLookupEnd":203.19999980926514,"domainLookupStart":203.19999980926514,"fetchStart":203.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":203.19999980926514,"responseEnd":519.3999996185303,"responseStart":519.3999996185303,"secureConnectionStart":203.19999980926514},{"duration":33.5,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":442.5999994277954,"connectEnd":442.5999994277954,"connectStart":442.5999994277954,"domainLookupEnd":442.5999994277954,"domainLookupStart":442.5999994277954,"fetchStart":442.5999994277954,"redirectEnd":0,"redirectStart":0,"requestStart":442.5999994277954,"responseEnd":476.0999994277954,"responseStart":476.0999994277954,"secureConnectionStart":442.5999994277954},{"duration":233.69999980926514,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":487.69999980926514,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":487.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":721.3999996185303,"responseStart":0,"secureConnectionStart":0},{"duration":526.0999994277954,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":488.69999980926514,"connectEnd":488.69999980926514,"connectStart":488.69999980926514,"domainLookupEnd":488.69999980926514,"domainLookupStart":488.69999980926514,"fetchStart":488.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":488.69999980926514,"responseEnd":1014.7999992370605,"responseStart":1014.7999992370605,"secureConnectionStart":488.69999980926514}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":39,"responseStart":195,"responseEnd":197,"domLoading":198,"domInteractive":951,"domContentLoadedEventStart":951,"domContentLoadedEventEnd":993,"domComplete":1097,"loadEventStart":1097,"loadEventEnd":1098,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":934},{"name":"bigPipe.sidebar-id.end","time":934.8999996185303},{"name":"bigPipe.activity-panel-pipe-id.start","time":935.0999994277954},{"name":"bigPipe.activity-panel-pipe-id.end","time":936},{"name":"activityTabFullyLoaded","time":1020.1999998092651}],"measures":[],"correlationId":"5138546e163edc","effectiveType":"4g","downlink":9,"rtt":0,"serverDuration":95,"dbReadsTimeInMs":10,"dbConnsTimeInMs":18,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
Merged Ryan's contribution from github.