Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-25759

wsrep_sst_rsync.sh is_local_ip function can come to incorrect conclusion

Details

    Description

      The is_local_ip function now incorrectly identifies ip-addresses falling under the "127.0.0.0/8" netmask as non-local, although they certainly belong to the loopback interface. This problem was discovered and discussed in detail in the description of the MENT-1170 issue, however, this bug needs to be fixed for CS editions as well (because from my point of view, this is just an error in the script, and not a feature request for ES editions).

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          sysprg Julius Goryavsky created issue -
          sysprg Julius Goryavsky made changes -
          Field Original Value New Value
          sysprg Julius Goryavsky made changes -
          Assignee Julius Goryavsky [ sysprg ]
          sysprg Julius Goryavsky made changes -
          Status Open [ 1 ] Confirmed [ 10101 ]
          sysprg Julius Goryavsky made changes -
          Status Confirmed [ 10101 ] In Progress [ 3 ]
          sysprg Julius Goryavsky added a comment -

          Since SST scripts were heavily reworked by me, I also corrected this flaw (this task is identical to MENT-1170 - only this one is for CS):

          https://github.com/MariaDB/server/commit/d80d7f6f1229ff3c3d29cf045816c17a82bfbb26

          sysprg Julius Goryavsky added a comment - Since SST scripts were heavily reworked by me, I also corrected this flaw (this task is identical to MENT-1170 - only this one is for CS): https://github.com/MariaDB/server/commit/d80d7f6f1229ff3c3d29cf045816c17a82bfbb26
          sysprg Julius Goryavsky made changes -
          Assignee Julius Goryavsky [ sysprg ] Jan Lindström [ jplindst ]
          Status In Progress [ 3 ] In Review [ 10002 ]
          jplindst Jan Lindström (Inactive) added a comment -

          ok to push

          jplindst Jan Lindström (Inactive) added a comment - ok to push
          jplindst Jan Lindström (Inactive) made changes -
          Assignee Jan Lindström [ jplindst ] Julius Goryavsky [ sysprg ]
          Status In Review [ 10002 ] Stalled [ 10000 ]
          sysprg Julius Goryavsky added a comment -

          Fixed, https://github.com/MariaDB/server/commit/c88e9342f37fff6d7757e4f7c6dcc5a7c44e2217

          sysprg Julius Goryavsky added a comment - Fixed, https://github.com/MariaDB/server/commit/c88e9342f37fff6d7757e4f7c6dcc5a7c44e2217
          sysprg Julius Goryavsky made changes -
          issue.field.resolutiondate 2021-05-23 17:21:17.0 2021-05-23 17:21:17.657
          sysprg Julius Goryavsky made changes -
          Fix Version/s 10.6.2 [ 25800 ]
          Fix Version/s 10.2.39 [ 25731 ]
          Fix Version/s 10.3.30 [ 25732 ]
          Fix Version/s 10.4.20 [ 25733 ]
          Fix Version/s 10.5.11 [ 25734 ]
          Fix Version/s 10.2 [ 14601 ]
          Fix Version/s 10.3 [ 22126 ]
          Fix Version/s 10.4 [ 22408 ]
          Fix Version/s 10.5 [ 23123 ]
          Fix Version/s 10.6 [ 24028 ]
          Resolution Fixed [ 1 ]
          Status Stalled [ 10000 ] Closed [ 6 ]
          serg Sergei Golubchik made changes -
          Workflow MariaDB v3 [ 122086 ] MariaDB v4 [ 159327 ]
          mariadb-jira-automation Jira Automation (IT) made changes -
          Zendesk Related Tickets 129370

          People

            sysprg Julius Goryavsky
            sysprg Julius Goryavsky
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.