Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-25456

MariaBackup logs "[ERROR]" on Invalid log block checksum despite retrying and succeeding later. Could this be changed to "[Warning]" unless it can no longer retry?

Details

    Description

      2020-12-15 20:38:03 0 [ERROR] InnoDB: Invalid log block checksum. block: 811904837 checkpoint no: 10978 expected: 3929835436 found: 881240600
      

      This causes user confusion because it is a transient error that can be retried and overcome. Per Marko: {
      --backup will invoke the function in a loop:

      for (int retries= 0; retries < 100; retries++) {
          if (log_sys.log.read_log_seg(&lsn, end_lsn)
          || lsn != start_lsn) {
              break;
          }
          msg("Retrying read of log at LSN=" LSN_PF, lsn);
          my_sleep(1000);
      }
      

      If the function log_t::files::read_log_seg() fails, it will display the message:

      ib::error() << "Invalid log block checksum."
      << " block: " << block_number
      << " checkpoint no: "
      << log_block_get_checkpoint_no(buf)
      << " expected: " << crc
      << " found: " << cksum;
      

      If you are also seeing the "Retrying read of log" message, there should be nothing to worry about. Due to the inter-process communication via the file system, Mariabackup must be prepared to retry reading data pages (innodb_page_size bytes) or log blocks (512 bytes) that appear corrupted.
      }

      So could this be changed to a [Warning] until it stops retrying?

      Attachments

        Activity

          juan.vera Juan created issue -
          julien.fritsch Julien Fritsch made changes -
          Field Original Value New Value
          Assignee Vladislav Vaintroub [ wlad ]
          julien.fritsch Julien Fritsch made changes -
          Priority Minor [ 4 ] Major [ 3 ]
          julien.fritsch Julien Fritsch made changes -
          Priority Major [ 3 ] Critical [ 2 ]
          wlad Vladislav Vaintroub made changes -
          Affects Version/s 10.2 [ 14601 ]
          Affects Version/s 10.3 [ 22126 ]
          Affects Version/s 10.4 [ 22408 ]
          Affects Version/s 10.5 [ 23123 ]
          Affects Version/s 10.6 [ 24028 ]
          wlad Vladislav Vaintroub made changes -
          issue.field.resolutiondate 2021-04-23 05:57:57.0 2021-04-23 05:57:57.696
          wlad Vladislav Vaintroub made changes -
          Fix Version/s 10.2.38 [ 25207 ]
          Fix Version/s 10.3.29 [ 25206 ]
          Fix Version/s 10.4.19 [ 25205 ]
          Fix Version/s 10.5.10 [ 25204 ]
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Closed [ 6 ]
          serg Sergei Golubchik made changes -
          Workflow MariaDB v3 [ 121171 ] MariaDB v4 [ 159163 ]
          mariadb-jira-automation Jira Automation (IT) made changes -
          Zendesk Related Tickets 191524

          People

            wlad Vladislav Vaintroub
            juan.vera Juan
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.