[MDEV-25328] --innodb command line option causes mariabackup to fail - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Blocker
Resolution: Fixed
Affects Version/s: 10.2(EOL), 10.3(EOL), 10.4(EOL), 10.5
Fix Version/s: 10.2.38, 10.3.29, 10.4.19, 10.5.10, 10.6.0
Component/s: Galera SST, mariabackup, Storage Engine - InnoDB
Labels:
None

Description

After ~~MDEV-24197~~, all mtr tests for Galera failed during SST because mariabackup fails with the following diagnostic:

Info: Using unique option prefix 'innodb' is error-prone and can break in the future. Please use the full name 'innodb-force-recovery' instead.

210402 03:24:30 innobackupex: Starting the backup operation

There new option added by ~~MDEV-24197~~ is the only argumentin the list (in "innobackupex.cc") that starts with "--innodb" prefix. As a result, get_opt treats any argument starting with "--innodb-" as shorthand for "--innodb-force-recovery".
And we get a non-zero xtrabackup_innodb_force_recovery value due to the parser's erroneous interpretation of some other argument (some other option with the "--innodb-" prefix) supposedly as "--innodb-force-recovery".
In particular, this has to do with the bootstrap process when starting mtr - it's from /mysql-test/t/bootstrap_innodb.test:

exec $MYSQLD_BOOTSTRAP_CMD --datadir=$datadir --innodb < $MYSQLTEST_VARDIR/tmp/bootstrap_test.sql >> $MYSQLTEST_VARDIR/tmp/bootstrap.log 2>&1;

Attachments

Issue Links

is caused by

MDEV-24197 Prepare step of backup failing on large backup

Closed

split to

MDEV-25356 SST scripts should use the new mariabackup interface

Closed

Activity

Ascending order - Click to sort in descending order

Julius Goryavsky created issue - 2021-04-02 02:02

Julius Goryavsky made changes - 2021-04-02 02:02

Field	Original Value	New Value
Link		This issue is caused by ~~MDEV-24197~~ [ ~~MDEV-24197~~ ]

Julius Goryavsky made changes - 2021-04-02 02:08

Summary

--innodb command line option causes mariabackup crash

--innodb command line option causes mariabackup to fail

Julius Goryavsky made changes - 2021-04-02 02:16

Assignee

Julius Goryavsky [ sysprg ]

Julius Goryavsky made changes - 2021-04-02 02:16

Status

Open [ 1 ]

Confirmed [ 10101 ]

Julius Goryavsky made changes - 2021-04-02 02:16

Status

Confirmed [ 10101 ]

In Progress [ 3 ]

Julius Goryavsky made changes - 2021-04-02 02:18

Assignee	Julius Goryavsky [ sysprg ]	Marko Mäkelä [ marko ]
Status	In Progress [ 3 ]	In Review [ 10002 ]

Sergei Golubchik added a comment - 2021-04-02 11:15

No, this is yet another hack on top of all other hacks.
As discussed on slack, it's safer to disable prefix matching for command line options completely.

Sergei Golubchik added a comment - 2021-04-02 11:15 No, this is yet another hack on top of all other hacks. As discussed on slack, it's safer to disable prefix matching for command line options completely.

Sergei Golubchik made changes - 2021-04-02 11:15

Assignee

Marko Mäkelä [ marko ]

Sergei Golubchik [ serg ]

Sergei Golubchik made changes - 2021-04-02 11:15

Assignee	Sergei Golubchik [ serg ]	Julius Goryavsky [ sysprg ]
Status	In Review [ 10002 ]	Stalled [ 10000 ]

Julius Goryavsky made changes - 2021-04-06 12:14

Status

Stalled [ 10000 ]

In Progress [ 3 ]

Julius Goryavsky added a comment - 2021-04-06 23:05

1) Fixed my_getopt;
2) Added a filter to the SST script;
3) Removed usage of the outdated --innobackupex interface;
4) Ffixed tests that depended on the old parser behavior;
5) Fixed the problem with passing the password through the environment.

https://github.com/MariaDB/server/commit/57d5fe737e2baf7fcb6fe48595a8d35b79305938
http://buildbot.askmonty.org/buildbot/grid?category=main&branch=bb-10.2-MDEV-25328-v2

Julius Goryavsky added a comment - 2021-04-06 23:05 1) Fixed my_getopt; 2) Added a filter to the SST script; 3) Removed usage of the outdated --innobackupex interface; 4) Ffixed tests that depended on the old parser behavior; 5) Fixed the problem with passing the password through the environment. https://github.com/MariaDB/server/commit/57d5fe737e2baf7fcb6fe48595a8d35b79305938 http://buildbot.askmonty.org/buildbot/grid?category=main&branch=bb-10.2-MDEV-25328-v2

Julius Goryavsky made changes - 2021-04-06 23:05

Assignee	Julius Goryavsky [ sysprg ]	Vladislav Vaintroub [ wlad ]
Status	In Progress [ 3 ]	In Review [ 10002 ]

Julius Goryavsky made changes - 2021-04-07 12:38

Assignee

Vladislav Vaintroub [ wlad ]

Julius Goryavsky [ sysprg ]

Julius Goryavsky added a comment - 2021-04-07 12:39 - edited

As discussed with Sergei, it was decided to split patch into a simple fix here and a separate task of transferring SST scripts to a new interface.

Julius Goryavsky added a comment - 2021-04-07 12:39 - edited As discussed with Sergei, it was decided to split patch into a simple fix here and a separate task of transferring SST scripts to a new interface.

Julius Goryavsky made changes - 2021-04-07 12:39

Status

In Review [ 10002 ]

Stalled [ 10000 ]

Julius Goryavsky made changes - 2021-04-07 12:41

Status

Stalled [ 10000 ]

In Progress [ 3 ]

Julius Goryavsky added a comment - 2021-04-07 12:46

Simple one-line fix plus minor cosmetic changes to the previous patch (which caused problems) to get rid of unnecessary spaces on the command line + corrected tests that could hypothetically cause problems in the future due to abbreviations for option names:

http://buildbot.askmonty.org/buildbot/grid?category=main&branch=bb-10.2-MDEV-25328-v3
https://github.com/MariaDB/server/commit/40d63d6099c1a522dba8120368de6c3acd8c80e4

Julius Goryavsky added a comment - 2021-04-07 12:46 Simple one-line fix plus minor cosmetic changes to the previous patch (which caused problems) to get rid of unnecessary spaces on the command line + corrected tests that could hypothetically cause problems in the future due to abbreviations for option names: http://buildbot.askmonty.org/buildbot/grid?category=main&branch=bb-10.2-MDEV-25328-v3 https://github.com/MariaDB/server/commit/40d63d6099c1a522dba8120368de6c3acd8c80e4

Julius Goryavsky made changes - 2021-04-07 12:46

Assignee	Julius Goryavsky [ sysprg ]	Marko Mäkelä [ marko ]
Status	In Progress [ 3 ]	In Review [ 10002 ]

Julius Goryavsky made changes - 2021-04-07 12:56

Link

This issue split to ~~MDEV-25356~~ [ ~~MDEV-25356~~ ]

Julius Goryavsky added a comment - 2021-04-07 13:10

Everything else has been moved into a separate task: https://jira.mariadb.org/browse/MDEV-25356

Julius Goryavsky added a comment - 2021-04-07 13:10 Everything else has been moved into a separate task: https://jira.mariadb.org/browse/MDEV-25356

Sergei Golubchik made changes - 2021-04-07 14:26

Fix Version/s

10.6 [ 24028 ]

Sergei Golubchik made changes - 2021-04-07 14:26

Affects Version/s

10.6 [ 24028 ]

Marko Mäkelä made changes - 2021-04-07 14:44

Assignee

Marko Mäkelä [ marko ]

Sergei Golubchik [ serg ]

Julius Goryavsky added a comment - 2021-04-07 14:59

It's the same in three different commits (just split):
https://github.com/MariaDB/server/commit/e14d1b35cff2d33f5bdcf578511c73b04245b372
https://github.com/MariaDB/server/commit/1b140716e40d8d46ba8daee296a5e2189056f554
https://github.com/MariaDB/server/commit/b767adb3ca3f718f6aafd53754253c585f23ec24

Julius Goryavsky added a comment - 2021-04-07 14:59 It's the same in three different commits (just split): https://github.com/MariaDB/server/commit/e14d1b35cff2d33f5bdcf578511c73b04245b372 https://github.com/MariaDB/server/commit/1b140716e40d8d46ba8daee296a5e2189056f554 https://github.com/MariaDB/server/commit/b767adb3ca3f718f6aafd53754253c585f23ec24

Sergei Golubchik added a comment - 2021-04-09 16:21

https://github.com/MariaDB/server/commit/e14d1b35cff2d33f5bdcf578511c73b04245b372
https://github.com/MariaDB/server/commit/1b140716e40d8d46ba8daee296a5e2189056f554
https://github.com/MariaDB/server/commit/b767adb3ca3f718f6aafd53754253c585f23ec24

are ok to push

Sergei Golubchik added a comment - 2021-04-09 16:21 https://github.com/MariaDB/server/commit/e14d1b35cff2d33f5bdcf578511c73b04245b372 https://github.com/MariaDB/server/commit/1b140716e40d8d46ba8daee296a5e2189056f554 https://github.com/MariaDB/server/commit/b767adb3ca3f718f6aafd53754253c585f23ec24 are ok to push

Sergei Golubchik made changes - 2021-04-09 16:21

Assignee	Sergei Golubchik [ serg ]	Julius Goryavsky [ sysprg ]
Status	In Review [ 10002 ]	Stalled [ 10000 ]

Julius Goryavsky made changes - 2021-04-11 11:21

Status

Stalled [ 10000 ]

In Progress [ 3 ]

Julius Goryavsky added a comment - 2021-04-11 11:23

fixed

Julius Goryavsky added a comment - 2021-04-11 11:23 fixed

Julius Goryavsky made changes - 2021-04-11 11:23

issue.field.resolutiondate

2021-04-11 11:23:32.0

2021-04-11 11:23:32.066

Julius Goryavsky made changes - 2021-04-11 11:23

Fix Version/s		10.2.38 [ 25207 ]
Fix Version/s		10.3.29 [ 25206 ]
Fix Version/s		10.4.19 [ 25205 ]
Fix Version/s		10.5.10 [ 25204 ]
Fix Version/s		10.6.0 [ 24431 ]
Fix Version/s	10.2 [ 14601 ]
Fix Version/s	10.3 [ 22126 ]
Fix Version/s	10.4 [ 22408 ]
Fix Version/s	10.5 [ 23123 ]
Resolution		Fixed [ 1 ]
Status	In Progress [ 3 ]	Closed [ 6 ]

Sergei Golubchik made changes - 2021-12-06 21:53

Workflow

MariaDB v3 [ 120703 ]

MariaDB v4 [ 159111 ]

People

Assignee:: Julius Goryavsky

Reporter:: Julius Goryavsky

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 2021-04-02 02:02

Updated:: 2021-04-13 12:03

Resolved:: 2021-04-11 11:23

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server

Details

Description

Attachments

Issue Links

Activity

People

Dates

Git Integration