The os0thread.cc module unnecessarily defines non-inlined function call wrappers for trivial operations.
os_thread_pf() simply casts the argument to a different type, and it should not exist at all.
The functions os_thread_eq() , os_thread_yield() , os_thread_get_curr_id() are better defined as macros that refer to the Microsoft Windows and POSIX interfaces.
Because os_thread_get_curr_id() is being invoked in locking code, this simplification could slightly improve performance.
made changes -
2020-11-30 09:16
Field
Original Value
New Value
issue.field.resolutiondate
2020-11-30 09:16:48.0
2020-11-30 09:16:48.074
made changes -
2020-11-30 09:16
Fix Version/s
10.5.9
[ 25109
]
Fix Version/s
10.5
[ 23123
]
Resolution
Fixed
[ 1
]
Status
Open
[ 1
]
Closed
[ 6
]
made changes -
2020-12-03 14:32
Fix Version/s
10.6.0
[ 24431
]
made changes -
2021-12-06 21:52
Workflow
MariaDB v3
[ 116254
]
MariaDB v4
[ 158630
]
{"report":{"fcp":1106.3000001907349,"ttfb":327.80000019073486,"pageVisibility":"visible","entityId":94330,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"f0e28849-f7a1-48e1-95ef-104f04e10b29","navigationType":0,"readyForUser":1158.5,"redirectCount":0,"resourceLoadedEnd":1288.9000005722046,"resourceLoadedStart":363.70000076293945,"resourceTiming":[{"duration":138.69999980926514,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bv2/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":363.70000076293945,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":363.70000076293945,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":502.4000005722046,"responseStart":0,"secureConnectionStart":0},{"duration":138.80000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bv2/820016/12ta74/2380add21a9a1006587582385952de73/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":364,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":364,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":502.80000019073486,"responseStart":0,"secureConnectionStart":0},{"duration":223,"initiatorType":"script","name":"https://jira.mariadb.org/s/e9b27a47da5fb0f74a35acd57e9847fb-CDN/lu2bv2/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":364.1000003814697,"connectEnd":364.1000003814697,"connectStart":364.1000003814697,"domainLookupEnd":364.1000003814697,"domainLookupStart":364.1000003814697,"fetchStart":364.1000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":364.1000003814697,"responseEnd":587.1000003814697,"responseStart":587.1000003814697,"secureConnectionStart":364.1000003814697},{"duration":363,"initiatorType":"script","name":"https://jira.mariadb.org/s/c32eb0da7ad9831253f8397e6cc26afd-CDN/lu2bv2/820016/12ta74/2380add21a9a1006587582385952de73/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":364.4000005722046,"connectEnd":364.4000005722046,"connectStart":364.4000005722046,"domainLookupEnd":364.4000005722046,"domainLookupStart":364.4000005722046,"fetchStart":364.4000005722046,"redirectEnd":0,"redirectStart":0,"requestStart":364.4000005722046,"responseEnd":727.4000005722046,"responseStart":727.4000005722046,"secureConnectionStart":364.4000005722046},{"duration":366.69999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/bc0bcb146314416123c992714ee00ff7-CDN/lu2bv2/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":364.6000003814697,"connectEnd":364.6000003814697,"connectStart":364.6000003814697,"domainLookupEnd":364.6000003814697,"domainLookupStart":364.6000003814697,"fetchStart":364.6000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":364.6000003814697,"responseEnd":731.3000001907349,"responseStart":731.3000001907349,"secureConnectionStart":364.6000003814697},{"duration":368.0999994277954,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":364.70000076293945,"connectEnd":364.70000076293945,"connectStart":364.70000076293945,"domainLookupEnd":364.70000076293945,"domainLookupStart":364.70000076293945,"fetchStart":364.70000076293945,"redirectEnd":0,"redirectStart":0,"requestStart":364.70000076293945,"responseEnd":732.8000001907349,"responseStart":732.8000001907349,"secureConnectionStart":364.70000076293945},{"duration":369.69999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":364.9000005722046,"connectEnd":364.9000005722046,"connectStart":364.9000005722046,"domainLookupEnd":364.9000005722046,"domainLookupStart":364.9000005722046,"fetchStart":364.9000005722046,"redirectEnd":0,"redirectStart":0,"requestStart":364.9000005722046,"responseEnd":734.6000003814697,"responseStart":734.5,"secureConnectionStart":364.9000005722046},{"duration":381.30000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bv2/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":365.1000003814697,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":365.1000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":746.4000005722046,"responseStart":0,"secureConnectionStart":0},{"duration":370.19999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":365.20000076293945,"connectEnd":365.20000076293945,"connectStart":365.20000076293945,"domainLookupEnd":365.20000076293945,"domainLookupStart":365.20000076293945,"fetchStart":365.20000076293945,"redirectEnd":0,"redirectStart":0,"requestStart":365.20000076293945,"responseEnd":735.4000005722046,"responseStart":735.4000005722046,"secureConnectionStart":365.20000076293945},{"duration":381.30000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bv2/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":365.30000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":365.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":746.6000003814697,"responseStart":0,"secureConnectionStart":0},{"duration":371.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/719848dd97ebe0663199f49a3936487a-CDN/lu2bv2/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":365.5,"connectEnd":365.5,"connectStart":365.5,"domainLookupEnd":365.5,"domainLookupStart":365.5,"fetchStart":365.5,"redirectEnd":0,"redirectStart":0,"requestStart":365.5,"responseEnd":737,"responseStart":737,"secureConnectionStart":365.5},{"duration":766.3000001907349,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":366.30000019073486,"connectEnd":366.30000019073486,"connectStart":366.30000019073486,"domainLookupEnd":366.30000019073486,"domainLookupStart":366.30000019073486,"fetchStart":366.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":366.30000019073486,"responseEnd":1132.6000003814697,"responseStart":1132.6000003814697,"secureConnectionStart":366.30000019073486},{"duration":843.3000001907349,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":370.6000003814697,"connectEnd":370.6000003814697,"connectStart":370.6000003814697,"domainLookupEnd":370.6000003814697,"domainLookupStart":370.6000003814697,"fetchStart":370.6000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":370.6000003814697,"responseEnd":1213.9000005722046,"responseStart":1213.9000005722046,"secureConnectionStart":370.6000003814697},{"duration":373.29999923706055,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":760.2000007629395,"connectEnd":760.2000007629395,"connectStart":760.2000007629395,"domainLookupEnd":760.2000007629395,"domainLookupStart":760.2000007629395,"fetchStart":760.2000007629395,"redirectEnd":0,"redirectStart":0,"requestStart":760.2000007629395,"responseEnd":1133.5,"responseStart":1133.5,"secureConnectionStart":760.2000007629395},{"duration":218.5999994277954,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":1076.9000005722046,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1076.9000005722046,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1295.5,"responseStart":0,"secureConnectionStart":0},{"duration":80.40000057220459,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2bv2/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":1208.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1208.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1288.9000005722046,"responseStart":0,"secureConnectionStart":0},{"duration":48,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":1209.5,"connectEnd":1209.5,"connectStart":1209.5,"domainLookupEnd":1209.5,"domainLookupStart":1209.5,"fetchStart":1209.5,"redirectEnd":0,"redirectStart":0,"requestStart":1209.5,"responseEnd":1257.5,"responseStart":1257.5,"secureConnectionStart":1209.5},{"duration":61.30000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/53a43b6764f587426c7bb9a150184c00-CDN/lu2bv2/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/js/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":1210.1000003814697,"connectEnd":1210.1000003814697,"connectStart":1210.1000003814697,"domainLookupEnd":1210.1000003814697,"domainLookupStart":1210.1000003814697,"fetchStart":1210.1000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":1210.1000003814697,"responseEnd":1271.4000005722046,"responseStart":1271.4000005722046,"secureConnectionStart":1210.1000003814697}],"fetchStart":1,"domainLookupStart":1,"domainLookupEnd":1,"connectStart":1,"connectEnd":1,"requestStart":141,"responseStart":328,"responseEnd":364,"domLoading":353,"domInteractive":1330,"domContentLoadedEventStart":1330,"domContentLoadedEventEnd":1387,"domComplete":1560,"loadEventStart":1560,"loadEventEnd":1561,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1303.5},{"name":"bigPipe.sidebar-id.end","time":1304.3000001907349},{"name":"bigPipe.activity-panel-pipe-id.start","time":1304.5},{"name":"bigPipe.activity-panel-pipe-id.end","time":1307.2000007629395},{"name":"activityTabFullyLoaded","time":1415.7000007629395}],"measures":[],"correlationId":"40cc01e680ba5","effectiveType":"4g","downlink":9.7,"rtt":0,"serverDuration":111,"dbReadsTimeInMs":16,"dbConnsTimeInMs":24,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
Bug
Major
For some reason, this change was causing assertion failures in the InnoDB rw_lock_t code on Windows. Hence, I restored os_thread_eq(), os_thread_yield(), os_thread_get_curr_id() as functions on Windows. Such failures were not observed in combination with
MDEV-24142.