Type:
Task
Priority:
Minor
Resolution:
Fixed
Description:
GCC supports a malloc function attribute (https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#Common-Function-Attribu ...) which tells that a function allocates a new unused memory chunk which allows compiler to do some optimizations.
According to my investigation such attribute, applied on MySQL allocation functions like my_malloc, me_realloc, my_memdump, my_str(n)dup and some others, improves performance (sysbench used).
Unfortunately the attribute is supported by GCC only (clang has similar attribute - allocator - but it is not used for optimization purposes), however MY_ATTRIBUTE macro able to handle it.
So I would like to suggest to mark all memory allocation function with the attribute.
How to repeat:
Annotate all allocation function with MY_ATTRIBUTE((malloc)) and compare sysbench results
{"report":{"fcp":852.7000000178814,"ttfb":165.30000001192093,"pageVisibility":"visible","entityId":92282,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"1a02ceb4-73c1-49cb-b885-148c2bf7667f","navigationType":0,"readyForUser":917.9000000059605,"redirectCount":0,"resourceLoadedEnd":594.4000000059605,"resourceLoadedStart":170.30000001192093,"resourceTiming":[{"duration":153.80000001192093,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bv2/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":170.30000001192093,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":170.30000001192093,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":324.10000002384186,"responseStart":0,"secureConnectionStart":0},{"duration":153.90000000596046,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bv2/820016/12ta74/2380add21a9a1006587582385952de73/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":170.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":170.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":324.40000000596046,"responseStart":0,"secureConnectionStart":0},{"duration":162.69999998807907,"initiatorType":"script","name":"https://jira.mariadb.org/s/e9b27a47da5fb0f74a35acd57e9847fb-CDN/lu2bv2/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":170.80000001192093,"connectEnd":170.80000001192093,"connectStart":170.80000001192093,"domainLookupEnd":170.80000001192093,"domainLookupStart":170.80000001192093,"fetchStart":170.80000001192093,"redirectEnd":0,"redirectStart":0,"requestStart":170.80000001192093,"responseEnd":333.5,"responseStart":333.5,"secureConnectionStart":170.80000001192093},{"duration":219.09999999403954,"initiatorType":"script","name":"https://jira.mariadb.org/s/c32eb0da7ad9831253f8397e6cc26afd-CDN/lu2bv2/820016/12ta74/2380add21a9a1006587582385952de73/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":170.90000000596046,"connectEnd":170.90000000596046,"connectStart":170.90000000596046,"domainLookupEnd":170.90000000596046,"domainLookupStart":170.90000000596046,"fetchStart":170.90000000596046,"redirectEnd":0,"redirectStart":0,"requestStart":170.90000000596046,"responseEnd":390,"responseStart":390,"secureConnectionStart":170.90000000596046},{"duration":223,"initiatorType":"script","name":"https://jira.mariadb.org/s/bc0bcb146314416123c992714ee00ff7-CDN/lu2bv2/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":171.2000000178814,"connectEnd":171.2000000178814,"connectStart":171.2000000178814,"domainLookupEnd":171.2000000178814,"domainLookupStart":171.2000000178814,"fetchStart":171.2000000178814,"redirectEnd":0,"redirectStart":0,"requestStart":171.2000000178814,"responseEnd":394.2000000178814,"responseStart":394.2000000178814,"secureConnectionStart":171.2000000178814},{"duration":223.19999998807907,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":171.30000001192093,"connectEnd":171.30000001192093,"connectStart":171.30000001192093,"domainLookupEnd":171.30000001192093,"domainLookupStart":171.30000001192093,"fetchStart":171.30000001192093,"redirectEnd":0,"redirectStart":0,"requestStart":171.30000001192093,"responseEnd":394.5,"responseStart":394.5,"secureConnectionStart":171.30000001192093},{"duration":223.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":171.5,"connectEnd":171.5,"connectStart":171.5,"domainLookupEnd":171.5,"domainLookupStart":171.5,"fetchStart":171.5,"redirectEnd":0,"redirectStart":0,"requestStart":171.5,"responseEnd":395,"responseStart":395,"secureConnectionStart":171.5},{"duration":305.89999997615814,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bv2/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":171.60000002384186,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":171.60000002384186,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":477.5,"responseStart":0,"secureConnectionStart":0},{"duration":223.59999999403954,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":171.80000001192093,"connectEnd":171.80000001192093,"connectStart":171.80000001192093,"domainLookupEnd":171.80000001192093,"domainLookupStart":171.80000001192093,"fetchStart":171.80000001192093,"redirectEnd":0,"redirectStart":0,"requestStart":171.80000001192093,"responseEnd":395.40000000596046,"responseStart":395.40000000596046,"secureConnectionStart":171.80000001192093},{"duration":305.60000002384186,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bv2/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":172,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":172,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":477.60000002384186,"responseStart":0,"secureConnectionStart":0},{"duration":223.7999999821186,"initiatorType":"script","name":"https://jira.mariadb.org/s/719848dd97ebe0663199f49a3936487a-CDN/lu2bv2/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":172.10000002384186,"connectEnd":172.10000002384186,"connectStart":172.10000002384186,"domainLookupEnd":172.10000002384186,"domainLookupStart":172.10000002384186,"fetchStart":172.10000002384186,"redirectEnd":0,"redirectStart":0,"requestStart":172.10000002384186,"responseEnd":395.90000000596046,"responseStart":395.90000000596046,"secureConnectionStart":172.10000002384186},{"duration":421,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":172.90000000596046,"connectEnd":172.90000000596046,"connectStart":172.90000000596046,"domainLookupEnd":172.90000000596046,"domainLookupStart":172.90000000596046,"fetchStart":172.90000000596046,"redirectEnd":0,"redirectStart":0,"requestStart":172.90000000596046,"responseEnd":593.9000000059605,"responseStart":593.9000000059605,"secureConnectionStart":172.90000000596046},{"duration":421.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":172.90000000596046,"connectEnd":172.90000000596046,"connectStart":172.90000000596046,"domainLookupEnd":172.90000000596046,"domainLookupStart":172.90000000596046,"fetchStart":172.90000000596046,"redirectEnd":0,"redirectStart":0,"requestStart":172.90000000596046,"responseEnd":594.4000000059605,"responseStart":594.3000000119209,"secureConnectionStart":172.90000000596046},{"duration":64.30000001192093,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":489,"connectEnd":489,"connectStart":489,"domainLookupEnd":489,"domainLookupStart":489,"fetchStart":489,"redirectEnd":0,"redirectStart":0,"requestStart":489,"responseEnd":553.3000000119209,"responseStart":553.3000000119209,"secureConnectionStart":489}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":4,"responseStart":165,"responseEnd":169,"domLoading":168,"domInteractive":963,"domContentLoadedEventStart":963,"domContentLoadedEventEnd":1008,"domComplete":1452,"loadEventStart":1452,"loadEventEnd":1454,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":944.9000000059605},{"name":"bigPipe.sidebar-id.end","time":945.8000000119209},{"name":"bigPipe.activity-panel-pipe-id.start","time":946},{"name":"bigPipe.activity-panel-pipe-id.end","time":948.5},{"name":"activityTabFullyLoaded","time":1014.1000000238419}],"measures":[],"correlationId":"8e878cac933427","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":104,"dbReadsTimeInMs":10,"dbConnsTimeInMs":19,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}