Sergei Petrunia added a comment - 2020-09-03 21:17 The S3 Storage engine part: https://github.com/MariaDB/server/commit/cd0e4f28fd45433e98f28933bc3ed103b34b64ac The libmarias3 part: https://github.com/mariadb-corporation/libmarias3/pull/91/files

Sergei Petrunia added a comment - 2020-09-03 21:21 danblack would you be able to review this?

Daniel Black added a comment - 2020-09-04 01:03 Done. minor changes pushed to S3 tree. libmarias3 looks good. Optional enhancements: Do you think detecting minio and mc in the path along should start minio from the test suite? minio server (doesn't auto daemonize) mkdir -p /tmp/shared MINIO_ACCESS_KEY=minio MINIO_SECRET_KEY=minioadmin minio server /tmp/shared/ minio client initialization / cleanup mc alias set local http://127.0.0.1:9000 minio minioadmin mc mb --ignore-existing local/storage-engine ... ... mc rm --recursive --force local/storage-engine mc admin service stop local Thanks for writing it psergey .

Sergei Petrunia added a comment - 2020-09-05 19:20 Ok, got approval for https://github.com/mariadb-corporation/libmarias3/pull/91 .

Sergei Petrunia added a comment - 2020-09-05 19:56 With the patch, I have these tests fail (both on Minio and S3) s3.no_s3 [ disabled ] Other failure s3.partition [ disabled ] Other failure s3.partition_move [ disabled ] Other failure s3.replication_mixed [ disabled ] fails s3.replication_partition [ disabled ] Crashes s3.replication_stmt [ disabled ] fails

Sergei Petrunia added a comment - 2020-09-05 20:04 bb-10.5-mdev23662

Sergei Petrunia added a comment - 2020-09-08 10:54 danblack , re starting Minio - I think starting/stopping minio is a good next step. We could also add logic to detect if it's present and/or get AWS credentials from the environment (or somewhere else?). Need to discuss this with those who run the CI systems. I think it's better to deal with this in a separate MDEV entry.

Sergei Petrunia added a comment - 2020-09-08 10:56 Pushed what we've had into 10.5