Details
-
Bug
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
10.5.4
-
None
Description
If the build environment does not support PCLMUL, then crc32_x86.c is not compiled in, and this fails to link.
Only call the functions in crc32_x86.c if they have been included.
fixes builds on older processors without PCLMUL
see: https://trac.macports.org/ticket/61063
Patch of interest dec3f8ca69e5e
Attachments
Issue Links
- is caused by
-
MDEV-22641 Provide SIMD optimized wrapper for zlib crc32()
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Link |
This issue is caused by |
| Component/s | Server [ 13907 ] | |
| Fix Version/s | 10.5.6 [ 24508 ] | |
| Affects Version/s | 10.5 [ 23123 ] | |
| Assignee | Marko Mäkelä [ marko ] | |
| Description |
If the processor does not support {{PCLMUL}}, then
{{crc32_x86.c}} is not compiled in, and this fails to link. Only call the functions in {{crc32_x86.c}} if they have been included. fixes builds on older processors without {{PCLMUL}} see: https://trac.macports.org/ticket/61063 |
If the processor does not support {{PCLMUL}}, then
{{crc32_x86.c}} is not compiled in, and this fails to link. Only call the functions in {{crc32_x86.c}} if they have been included. fixes builds on older processors without {{PCLMUL}} see: https://trac.macports.org/ticket/61063 Patch of interest [dec3f8ca69e5e|https://github.com/MariaDB/server/commit/dec3f8ca69e5eb19a4be7a175d3834874c4d880b] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Fix Version/s | 10.5 [ 23123 ] | |
| Fix Version/s | 10.5.6 [ 24508 ] | |
| Affects Version/s | 10.5.4 [ 24264 ] | |
| Affects Version/s | 10.5 [ 23123 ] | |
| Description |
If the processor does not support {{PCLMUL}}, then
{{crc32_x86.c}} is not compiled in, and this fails to link. Only call the functions in {{crc32_x86.c}} if they have been included. fixes builds on older processors without {{PCLMUL}} see: https://trac.macports.org/ticket/61063 Patch of interest [dec3f8ca69e5e|https://github.com/MariaDB/server/commit/dec3f8ca69e5eb19a4be7a175d3834874c4d880b] |
If the build environment does not support {{PCLMUL}}, then {{crc32_x86.c}} is not compiled in, and this fails to link.
Only call the functions in {{crc32_x86.c}} if they have been included. fixes builds on older processors without {{PCLMUL}} see: https://trac.macports.org/ticket/61063 Patch of interest [dec3f8ca69e5e|https://github.com/MariaDB/server/commit/dec3f8ca69e5eb19a4be7a175d3834874c4d880b] |
| issue.field.resolutiondate | 2020-08-27 06:47:24.0 | 2020-08-27 06:47:24.217 |
| Fix Version/s | 10.5.6 [ 24508 ] | |
| Fix Version/s | 10.5 [ 23123 ] | |
| Resolution | Fixed [ 1 ] | |
| Status | In Progress [ 3 ] | Closed [ 6 ] |
| Fix Version/s | 10.5.7 [ 25019 ] |
| Fix Version/s | 10.5.6 [ 24508 ] |
| Workflow | MariaDB v3 [ 112949 ] | MariaDB v4 [ 158299 ] |