Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-23473

Query_log_event::pack_info does not check flags2_inited

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 10.5
    • 10.5.7
    • Replication
    • None

    Description

      Recent MDEV-19964 patch did not check flags2_inited before
      to access flags2 itself.
      The latter may be randomly non-zero (see Query_log_event constructor) which
      eventulizes on rpl.rpl_mariadb_slave_capability with the following mismatch pattern: 

      -slave-relay-bin.000005	#	Query	#	#	BEGIN
      		 
      +slave-relay-bin.000005	#	Query	#	#	set foreign_key_checks=1, check_constraint_checks=1; BEGIN

      where the '+' extra is cause by the random flags2.

      The case should be fixed with following the pattern of first checking flags2_inited.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          Elkin Andrei Elkin created issue -
          Elkin Andrei Elkin made changes -
          Field Original Value New Value
          Assignee Andrei Elkin [ elkin ]
          Elkin Andrei Elkin made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Elkin Andrei Elkin added a comment -

          Sachin, howdy.

          Could you please access the patch.

          Cheers,

          Andrei

          Elkin Andrei Elkin added a comment - Sachin, howdy. Could you please access the patch. Cheers, Andrei
          Elkin Andrei Elkin made changes -
          Assignee Andrei Elkin [ elkin ] Sachin Setiya [ sachin.setiya.007 ]
          Status In Progress [ 3 ] In Review [ 10002 ]
          serg Sergei Golubchik made changes -
          Fix Version/s 10.5 [ 23123 ]
          Fix Version/s 10.5.6 [ 24508 ]
          Elkin Andrei Elkin added a comment -

          Closing after discussion with the reviewer and approved decision to convert the original extra check
          into an assert. As result no redundancy check in runtime but still (dbug) guarded relation between from object is ensured.

          Elkin Andrei Elkin added a comment - Closing after discussion with the reviewer and approved decision to convert the original extra check into an assert. As result no redundancy check in runtime but still (dbug) guarded relation between from object is ensured.
          Elkin Andrei Elkin made changes -
          Fix Version/s 10.5.6 [ 24508 ]
          Fix Version/s 10.5 [ 23123 ]
          Resolution Fixed [ 1 ]
          Status In Review [ 10002 ] Closed [ 6 ]
          Elkin Andrei Elkin made changes -
          Assignee Sachin Setiya [ sachin.setiya.007 ] Andrei Elkin [ elkin ]
          ralf.gebhardt Ralf Gebhardt made changes -
          Fix Version/s 10.5.7 [ 25019 ]
          ralf.gebhardt Ralf Gebhardt made changes -
          Fix Version/s 10.5.6 [ 24508 ]
          serg Sergei Golubchik made changes -
          Workflow MariaDB v3 [ 112389 ] MariaDB v4 [ 158242 ]

          People

            Elkin Andrei Elkin
            Elkin Andrei Elkin
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.