Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-23339

innodb_force_recovery=2 may still abort the rollback of recovered transactions

Details

    Description

      The fix of MDEV-21217 is incomplete. As observed in MDEV-22889, a condition in trx_rollback_resurrected() is wrongly referring to !srv_is_being_started instead of the proper condition srv_shutdown_state != SRV_SHUTDOWN_NONE. As a result, the recovered transaction would remain in its incomplete state, holding record and table locks and conflicting with any new transactions that may be started.

      The purge of transaction history is not affected by this bug, because it will be disabled by innodb_force_recovery=2.

      Attachments

        Issue Links

          Activity

            marko Marko Mäkelä created issue -
            marko Marko Mäkelä made changes -
            Field Original Value New Value
            marko Marko Mäkelä made changes -

            I was unable to repeat the problem locally. I did enable the test innodb.innodb_force_recovery_rollback but added a LIMIT 0 clause in order to work around MDEV-22889.

            marko Marko Mäkelä added a comment - I was unable to repeat the problem locally. I did enable the test innodb.innodb_force_recovery_rollback but added a LIMIT 0 clause in order to work around MDEV-22889 .
            marko Marko Mäkelä made changes -
            issue.field.resolutiondate 2020-07-30 06:43:26.0 2020-07-30 06:43:26.285
            marko Marko Mäkelä made changes -
            Fix Version/s 10.2.33 [ 24307 ]
            Fix Version/s 10.3.24 [ 24306 ]
            Fix Version/s 10.4.14 [ 24305 ]
            Fix Version/s 10.5.5 [ 24423 ]
            Fix Version/s 10.2 [ 14601 ]
            Fix Version/s 10.3 [ 22126 ]
            Fix Version/s 10.4 [ 22408 ]
            Fix Version/s 10.5 [ 23123 ]
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 111810 ] MariaDB v4 [ 158167 ]

            People

              marko Marko Mäkelä
              marko Marko Mäkelä
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.