Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-23230

wsrep files installed when built without WSREP

Details

    Description

      When building with -DWITH_WSREP=OFF -DPLUGIN_WSREP_INFO=NO, I am still finding many wsrep-related files installed in the INSTALLDIR. Specifically:

      usr/include/mysql/server/mysql/service_wsrep.h
      		 
      usr/include/mysql/server/private/wsrep*.h
      		 
      usr/share/mysql/wsrep_notify
      		 
      usr/share/doc/README-wsrep
      		 
      usr/share/man/man1/wsrep_sst_rsync_wan.1
      		 
      usr/share/man/man1/wsrep_sst_mariabackup.1
      		 
      usr/share/man/man1/wsrep_sst_mysqldump.1
      		 
      usr/share/man/man1/wsrep_sst_rsync.1
      		 
      usr/share/man/man1/wsrep_sst_common.1

      Whether or not the includes files should be installed I don't know, and the SQL in wsrep_notify and the README-wsrep could also be argued. But, certainly the man pages should not be installed as the tools are not built or installed.

      I would suggest that none of these should be installed, and that the build configurtion should turn them all off if -DWITH_WSREP=OFF.

      Attachments

        Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. MDEV-30344 MTR tests fail when built without WSREP

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            View 7 older comments
            danblack Daniel Black added a comment -

            It was deceptive, all the STRING(APPEND was under Windows which has a higher CMake version threshold. We've still got cmake-ancient in rhel/cento-7.

            Glad your happy with it. Sorry it too so long. And thanks for the ping on maria-discuss.

            danblack Daniel Black added a comment - It was deceptive, all the STRING(APPEND was under Windows which has a higher CMake version threshold. We've still got cmake-ancient in rhel/cento-7. Glad your happy with it. Sorry it too so long. And thanks for the ping on maria-discuss.
            cross Chris Ross added a comment -

            Just confirmed that these files (or a very similar set) are also installed on 10.6.11 compiled with -DWITH_WSREP=OFF -DPLUGIN_WSREP_INFO=NO. Thanks. Looking forward to the fix getting into the trees.

            cross Chris Ross added a comment - Just confirmed that these files (or a very similar set) are also installed on 10.6.11 compiled with -DWITH_WSREP=OFF -DPLUGIN_WSREP_INFO=NO . Thanks. Looking forward to the fix getting into the trees.
            cross Chris Ross added a comment - - edited

            Thanks. I see this got pulled into 10.5 today, but it is noted as fixed in 10.5.20, not 10.5.19 which should be the next out. So curious for a "why" on that, and a pointer to track this getting up into 10.6 (and later) so I can plan for which 10.6 release will have it. I hope/expect to have our internal product update to 10.6.x shortly. Thank you.

            cross Chris Ross added a comment - - edited Thanks. I see this got pulled into 10.5 today, but it is noted as fixed in 10.5.20, not 10.5.19 which should be the next out. So curious for a "why" on that, and a pointer to track this getting up into 10.6 (and later) so I can plan for which 10.6 release will have it. I hope/expect to have our internal product update to 10.6.x shortly. Thank you.
            serg Sergei Golubchik added a comment -

            must've been a mistake. Thanks

            serg Sergei Golubchik added a comment - must've been a mistake. Thanks
            robinnew Robin Newhouse added a comment -

            The changes introduce failures in MTR tests when WITH_WSREP=OFF. See MDEV-30344.

            robinnew Robin Newhouse added a comment - The changes introduce failures in MTR tests when WITH_WSREP=OFF. See MDEV-30344 .

            People

              TheLinuxJedi Andrew Hutchings (Inactive)
              cross Chris Ross
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.