Details
-
Task
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
None
Description
The Protocol class has two similar virtual methods to send string data:
class Protocol |
{
|
...
|
virtual bool store(const char *from, size_t length, CHARSET_INFO *cs); |
virtual bool store(const char *from, size_t length, |
CHARSET_INFO *fromcs, CHARSET_INFO *tocs);
|
...
|
};
|
Both call store_string_aux() internally.
The first method does not need to be virtual. Let's define it to be non-virtual, as follows:
class Protocol |
{
|
...
|
bool store(const char *from, size_t length, CHARSET_INFO *cs) |
{
|
CHARSET_INFO *tocs= thd->variables.character_set_results;
|
return store(from, length, fromcs, tocs); |
}
|
virtual bool store(const char *from, size_t length, |
CHARSET_INFO *fromcs, CHARSET_INFO *tocs);
|
..
|
};
|
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Description |
The Protocol class has two similar virtual methods to send string data:
{code:cpp} class Protocol { ... virtual bool store(const char *from, size_t length, CHARSET_INFO *cs); virtual bool store(const char *from, size_t length, CHARSET_INFO *fromcs, CHARSET_INFO *tocs); ... }; {code} Both call store_string_aux() internally. The first method does not need to be virtual. Let's define it to be non-virtual, as follows: {code:cpp} class Protocol { ... bool store(const char *from, size_t length, CHARSET_INFO *cs) { CHARSET_INFO *tocs= thd->variables.character_set_results; return store(from, length, fromcs, tocs); } virtual bool store(const char *from, size_t length, CHARSET_INFO *fromcs, CHARSET_INFO *tocs); .. }; |
The Protocol class has two similar virtual methods to send string data:
{code:cpp} class Protocol { ... virtual bool store(const char *from, size_t length, CHARSET_INFO *cs); virtual bool store(const char *from, size_t length, CHARSET_INFO *fromcs, CHARSET_INFO *tocs); ... }; {code} Both call store_string_aux() internally. The first method does not need to be virtual. Let's define it to be non-virtual, as follows: {code:cpp} class Protocol { ... bool store(const char *from, size_t length, CHARSET_INFO *cs) { CHARSET_INFO *tocs= thd->variables.character_set_results; return store(from, length, fromcs, tocs); } virtual bool store(const char *from, size_t length, CHARSET_INFO *fromcs, CHARSET_INFO *tocs); .. }; {code} |
| issue.field.resolutiondate | 2020-07-14 04:00:56.0 | 2020-07-14 04:00:56.095 |
| Fix Version/s | 10.5.5 [ 24423 ] | |
| Fix Version/s | 10.5 [ 23123 ] | |
| Resolution | Fixed [ 1 ] | |
| Status | Open [ 1 ] | Closed [ 6 ] |
| Workflow | MariaDB v3 [ 111169 ] | MariaDB v4 [ 134309 ] |