Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-22166

CONVERT PARTITION: move out partition into a table

Details

    Description

      Moving a table out from a partitioned table is new quite cumbersome:
      ('archive' is here a partitioned table and 'p1' is a normal table)

      CREATE TABLE tp1 LIKE archive;
      ALTER TABLE tp1 REMOVE PARTITIONING;
      ALTER TABLE archive EXCHANGE PARTITION p1 WITH TABLE tp1;
      ALTER TABLE archive DROP PARTITION p1;

      Instead one should be able to do:

      ALTER TABLE archive CONVERT PARTITION p1 TO TABLE tp1;

      The operation crash safety must be protected by DDL logging.

      Attachments

        Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. MDEV-26767 Server crashes when rename table and alter storage engine

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          is blocked by

          Task - A task that needs to be done. MDEV-17567 Atomic DDL

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          is part of

          Task - A task that needs to be done. MDEV-22162 Make partitions more flexible to use

          • Major - Major loss of function.
          • Open
          relates to

          Task - A task that needs to be done. MDEV-17567 Atomic DDL

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Task - A task that needs to be done. MDEV-22165 CONVERT TABLE: move in partition from existing table

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-31013 CONVERT PARTITION is not documented in the KB

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. MDEV-22164 WITHOUT VALIDATION for EXCHANGE PARTITION/CONVERT IN

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. MDEV-27180 Fully atomic partitioning DDL operations

          • Critical - Crashes, loss of data, severe memory leak.
          • In Review

          Bug - A problem which impairs or prevents the functions of the product. MDEV-31014 Database privileges are insufficient for CONVERT TABLE TO PARTITION

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            monty Michael Widenius created issue -
            monty Michael Widenius made changes -
            Field Original Value New Value
            serg Sergei Golubchik made changes -
            Assignee Alexey Botchkov [ holyfoot ]
            ralf.gebhardt Ralf Gebhardt made changes -
            Fix Version/s 10.6 [ 24028 ]
            Fix Version/s 10.5 [ 23123 ]
            ralf.gebhardt Ralf Gebhardt made changes -
            Fix Version/s 10.6 [ 24028 ]
            ralf.gebhardt Ralf Gebhardt made changes -
            Assignee Alexey Botchkov [ holyfoot ]
            serg Sergei Golubchik made changes -
            Fix Version/s 10.7 [ 24805 ]
            serg Sergei Golubchik made changes -
            Assignee Oleksandr Byelkin [ sanja ]
            serg Sergei Golubchik made changes -
            Priority Major [ 3 ] Critical [ 2 ]
            ralf.gebhardt Ralf Gebhardt made changes -
            Due Date 2021-09-14
            sanja Oleksandr Byelkin made changes -
            Assignee Oleksandr Byelkin [ sanja ] Aleksey Midenkov [ midenok ]
            midenok Aleksey Midenkov made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            midenok Aleksey Midenkov made changes -
            Description Moving a table out from a partitioned table is new quite cumbersome:
            ('archive' is here a partitioned table and 'p1' is a normal table)

            CREATE TABLE p1 LIKE archive;
            ALTER TABLE p1 REMOVE PARTITIONING;
            ALTER TABLE archive EXCHANGE PARTITION p1 WITH TABLE p1;
            ALTER TABLE archive DROP PARTITION p1;

            Instead one should be able to do:

            ALTER TABLE archive EXTRACT PARTITION p1 AS TABLE p1;             		Moving a table out from a partitioned table is new quite cumbersome:
            ('archive' is here a partitioned table and 'p1' is a normal table)

            CREATE TABLE p1 LIKE archive;
            ALTER TABLE p1 REMOVE PARTITIONING;
            ALTER TABLE archive EXCHANGE PARTITION p1 WITH TABLE p1;
            ALTER TABLE archive DROP PARTITION p1;

            Instead one should be able to do:

            ALTER TABLE archive EXTRACT PARTITION p1 AS TABLE p1;

            The operation crash safety must be protected by DDL logging.
            midenok Aleksey Midenkov made changes -
            midenok Aleksey Midenkov made changes -
            Description Moving a table out from a partitioned table is new quite cumbersome:
            ('archive' is here a partitioned table and 'p1' is a normal table)

            CREATE TABLE p1 LIKE archive;
            ALTER TABLE p1 REMOVE PARTITIONING;
            ALTER TABLE archive EXCHANGE PARTITION p1 WITH TABLE p1;
            ALTER TABLE archive DROP PARTITION p1;

            Instead one should be able to do:

            ALTER TABLE archive EXTRACT PARTITION p1 AS TABLE p1;

            The operation crash safety must be protected by DDL logging.             		Moving a table out from a partitioned table is new quite cumbersome:
            ('archive' is here a partitioned table and 'p1' is a normal table)

            CREATE TABLE p1 LIKE archive;
            ALTER TABLE p1 REMOVE PARTITIONING;
            ALTER TABLE archive EXCHANGE PARTITION p1 WITH TABLE p1;
            ALTER TABLE archive DROP PARTITION p1;

            Instead one should be able to do:

            ALTER TABLE archive EXPORT PARTITION p1 AS TABLE p1;

            The operation crash safety must be protected by DDL logging.
            midenok Aleksey Midenkov made changes -
            Summary Make it easier to move out a table from a partitioned table EXPORT PARTITION: move out a table from a partitioned table
            midenok Aleksey Midenkov made changes -
            Description Moving a table out from a partitioned table is new quite cumbersome:
            ('archive' is here a partitioned table and 'p1' is a normal table)

            CREATE TABLE p1 LIKE archive;
            ALTER TABLE p1 REMOVE PARTITIONING;
            ALTER TABLE archive EXCHANGE PARTITION p1 WITH TABLE p1;
            ALTER TABLE archive DROP PARTITION p1;

            Instead one should be able to do:

            ALTER TABLE archive EXPORT PARTITION p1 AS TABLE p1;

            The operation crash safety must be protected by DDL logging.             		Moving a table out from a partitioned table is new quite cumbersome:
            ('archive' is here a partitioned table and 'p1' is a normal table)

            CREATE TABLE tp1 LIKE archive;
            ALTER TABLE tp1 REMOVE PARTITIONING;
            ALTER TABLE archive EXCHANGE PARTITION p1 WITH TABLE tp1;
            ALTER TABLE archive DROP PARTITION p1;

            Instead one should be able to do:

            ALTER TABLE archive EXPORT PARTITION p1 AS TABLE tp1;

            The operation crash safety must be protected by DDL logging.
            midenok Aleksey Midenkov added a comment -

            Should tp1 be locked under lock tables?

            LOCK TABLES t1 WRITE;
            ALTER TABLE t1 EXPORT PARTITION p1 AS TABLE tp1;
            SELECT * from tp1;
            Table 'tp1' was not locked with LOCK TABLES

            I think this is a good idea to lock tp1 as well otherwise there is no guarantee of data consistency between t1 and tp1.

            midenok Aleksey Midenkov added a comment - Should tp1 be locked under lock tables? LOCK TABLES t1 WRITE; ALTER TABLE t1 EXPORT PARTITION p1 AS TABLE tp1; SELECT * from tp1; Table 'tp1' was not locked with LOCK TABLES I think this is a good idea to lock tp1 as well otherwise there is no guarantee of data consistency between t1 and tp1.
            midenok Aleksey Midenkov made changes -
            Summary EXPORT PARTITION: move out a table from a partitioned table MIGRATE PARTITION: move out partition into a table
            midenok Aleksey Midenkov made changes -
            Description Moving a table out from a partitioned table is new quite cumbersome:
            ('archive' is here a partitioned table and 'p1' is a normal table)

            CREATE TABLE tp1 LIKE archive;
            ALTER TABLE tp1 REMOVE PARTITIONING;
            ALTER TABLE archive EXCHANGE PARTITION p1 WITH TABLE tp1;
            ALTER TABLE archive DROP PARTITION p1;

            Instead one should be able to do:

            ALTER TABLE archive EXPORT PARTITION p1 AS TABLE tp1;

            The operation crash safety must be protected by DDL logging.             		Moving a table out from a partitioned table is new quite cumbersome:
            ('archive' is here a partitioned table and 'p1' is a normal table)

            CREATE TABLE tp1 LIKE archive;
            ALTER TABLE tp1 REMOVE PARTITIONING;
            ALTER TABLE archive EXCHANGE PARTITION p1 WITH TABLE tp1;
            ALTER TABLE archive DROP PARTITION p1;

            Instead one should be able to do:

            ALTER TABLE archive MIGRATE PARTITION p1 TO [TABLE] tp1;

            The operation crash safety must be protected by DDL logging.
            midenok Aleksey Midenkov made changes -
            midenok Aleksey Midenkov added a comment -

            Please review

            bb-10.7-midenok-MDEV-22166

            midenok Aleksey Midenkov added a comment - Please review bb-10.7-midenok-MDEV-22166
            midenok Aleksey Midenkov made changes -
            Assignee Aleksey Midenkov [ midenok ] Oleksandr Byelkin [ sanja ]
            Status In Progress [ 3 ] In Review [ 10002 ]
            sanja Oleksandr Byelkin made changes -
            Assignee Oleksandr Byelkin [ sanja ] Sergei Golubchik [ serg ]
            serg Sergei Golubchik made changes -
            Assignee Sergei Golubchik [ serg ] Aleksey Midenkov [ midenok ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            midenok Aleksey Midenkov made changes -
            Assignee Aleksey Midenkov [ midenok ] Sergei Golubchik [ serg ]
            Status Stalled [ 10000 ] In Review [ 10002 ]
            monty Michael Widenius made changes -
            Assignee Sergei Golubchik [ serg ] Michael Widenius [ monty ]
            serg Sergei Golubchik made changes -
            Assignee Michael Widenius [ monty ] Sergei Golubchik [ serg ]
            serg Sergei Golubchik made changes -
            Assignee Sergei Golubchik [ serg ] Aleksey Midenkov [ midenok ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            midenok Aleksey Midenkov made changes -
            Assignee Aleksey Midenkov [ midenok ] Sergei Golubchik [ serg ]
            Status Stalled [ 10000 ] In Review [ 10002 ]
            midenok Aleksey Midenkov made changes -
            Summary MIGRATE PARTITION: move out partition into a table CONVERT PARTITION: move out partition into a table
            midenok Aleksey Midenkov made changes -
            Description Moving a table out from a partitioned table is new quite cumbersome:
            ('archive' is here a partitioned table and 'p1' is a normal table)

            CREATE TABLE tp1 LIKE archive;
            ALTER TABLE tp1 REMOVE PARTITIONING;
            ALTER TABLE archive EXCHANGE PARTITION p1 WITH TABLE tp1;
            ALTER TABLE archive DROP PARTITION p1;

            Instead one should be able to do:

            ALTER TABLE archive MIGRATE PARTITION p1 TO [TABLE] tp1;

            The operation crash safety must be protected by DDL logging.             		Moving a table out from a partitioned table is new quite cumbersome:
            ('archive' is here a partitioned table and 'p1' is a normal table)

            CREATE TABLE tp1 LIKE archive;
            ALTER TABLE tp1 REMOVE PARTITIONING;
            ALTER TABLE archive EXCHANGE PARTITION p1 WITH TABLE tp1;
            ALTER TABLE archive DROP PARTITION p1;

            Instead one should be able to do:

            ALTER TABLE archive CONVERT PARTITION p1 TO TABLE tp1;

            The operation crash safety must be protected by DDL logging.
            serg Sergei Golubchik added a comment -

            818407474d6 is mostly ok. a couple of minor comments.

            I presume logging changes are reviewed and ok'ed by Monty

            serg Sergei Golubchik added a comment - 818407474d6 is mostly ok. a couple of minor comments. I presume logging changes are reviewed and ok'ed by Monty
            serg Sergei Golubchik made changes -
            Assignee Sergei Golubchik [ serg ] Aleksey Midenkov [ midenok ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            serg Sergei Golubchik made changes -
            Assignee Aleksey Midenkov [ midenok ] Elena Stepanova [ elenst ]
            serg Sergei Golubchik made changes -
            ralf.gebhardt Ralf Gebhardt made changes -
            Due Date 2021-09-14
            elenst Elena Stepanova made changes -
            Assignee Elena Stepanova [ elenst ] Ramesh Sivaraman [ JIRAUSER48189 ]
            ramesh Ramesh Sivaraman made changes -
            serg Sergei Golubchik made changes -
            Fix Version/s 10.7.1 [ 26120 ]
            Fix Version/s 10.7 [ 24805 ]
            Assignee Ramesh Sivaraman [ JIRAUSER48189 ] Aleksey Midenkov [ midenok ]
            Resolution Fixed [ 1 ]
            Status Stalled [ 10000 ] Closed [ 6 ]
            midenok Aleksey Midenkov made changes -
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 106793 ] MariaDB v4 [ 134233 ]
            ralf.gebhardt Ralf Gebhardt made changes -
            midenok Aleksey Midenkov made changes -
            midenok Aleksey Midenkov made changes -
            midenok Aleksey Midenkov made changes -
            ralf.gebhardt Ralf Gebhardt made changes -
            Labels Preview_10.7
            elenst Elena Stepanova made changes -
            midenok Aleksey Midenkov made changes -
            serg Sergei Golubchik made changes -

            People

              midenok Aleksey Midenkov
              monty Michael Widenius
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.