[MDEV-21907] Enable -Wconversion for InnoDB and Mariabackup - Jira

XML

Word

Printable

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Affects Version/s: 5.5(EOL), 10.0(EOL), 10.1(EOL), 10.2(EOL), 10.3(EOL), 10.4(EOL), 10.5(EOL)
Fix Version/s: 10.5.2
Component/s: Storage Engine - InnoDB
Labels:
- portability
- ulong

Description

To improve code quality and to avoid surprise build failures on Windows, we should fix any -Wconversion warnings that are reported by gcc or clang.

gcc appears to be stricter than clang here; it will require explicit bitmask operations to suppress warnings about assignments to bit fields in structs.

As a first step, we should enable -Wconversion in InnoDB and Mariabackup. This will require some headers in include/ and sql/ to be fixed as well. The Mariabackup build also includes some compilation units in libmysqld.

Attachments

Issue Links

is blocked by

MDEV-21924 Clean up InnoDB GIS record comparison

Closed

relates to

MDEV-21269 Parallel merging of fts index rebuild fails

Closed

MDEV-26896 Enable -Wconversion globally

Open

MDEV-19740 Debug build of 10.3.15 FTBFS

Closed

Activity

People

Assignee:: Marko Mäkelä

Reporter:: Marko Mäkelä

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 2020-03-10 17:50

Updated:: 2021-10-25 10:02

Resolved:: 2020-03-12 18:10

Time Tracking

Estimated:

Remaining:

Logged:

4d 3h

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.