Details
-
Bug
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
5.5(EOL), 10.0(EOL), 10.1(EOL), 10.2(EOL), 10.3(EOL), 10.4(EOL), 10.5
Description
To improve code quality and to avoid surprise build failures on Windows, we should fix any -Wconversion warnings that are reported by gcc or clang.
gcc appears to be stricter than clang here; it will require explicit bitmask operations to suppress warnings about assignments to bit fields in structs.
As a first step, we should enable -Wconversion in InnoDB and Mariabackup. This will require some headers in include/ and sql/ to be fixed as well. The Mariabackup build also includes some compilation units in libmysqld.
Attachments
Issue Links
- is blocked by
-
-
- Closed
-
- relates to
-
-
- Closed
-
-
MDEV-26896 Enable -Wconversion globally
-
- Open
-
-
-
- Stalled
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Link | This issue relates to MDEV-19740 [ MDEV-19740 ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Description |
To improve code quality and to avoid surprise build failures on Windows, we should fix any {{-Wconversion}} warnings that are reported by {{gcc}} or {{clang}}.
{{gcc}} appears to be stricter than {{clang}} here; it will require explicit bitmask operations to suppress warnings about assignments to bit fields in structs. As a first step, we should enable {{-Wconversion}} in InnoDB. This will require some headers in {{include/}} and {{sql/}} to be fixed as well. |
To improve code quality and to avoid surprise build failures on Windows, we should fix any {{-Wconversion}} warnings that are reported by {{gcc}} or {{clang}}.
{{gcc}} appears to be stricter than {{clang}} here; it will require explicit bitmask operations to suppress warnings about assignments to bit fields in structs. As a first step, we should enable {{-Wconversion}} in InnoDB and Mariabackup. This will require some headers in {{include/}} and {{sql/}} to be fixed as well. The Mariabackup build also includes some compilation units in {{libmysqld}}. |
| Summary | Fix -Wconversion in InnoDB | Enable -Wconversion for InnoDB and Mariabackup |
| Link |
This issue is blocked by |
| issue.field.resolutiondate | 2020-03-12 18:10:32.0 | 2020-03-12 18:10:32.955 |
| Fix Version/s | 10.5.2 [ 24030 ] | |
| Fix Version/s | 10.5 [ 23123 ] | |
| Resolution | Fixed [ 1 ] | |
| Status | In Progress [ 3 ] | Closed [ 6 ] |
| Link |
This issue relates to |
| Labels | portability | portability ulong |
| Link | This issue relates to MDEV-26896 [ MDEV-26896 ] |
| Workflow | MariaDB v3 [ 104738 ] | MariaDB v4 [ 157411 ] |