Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-21715

Allow loading buffer pool dumps for encrypted tablespaces

Details

    Description

      loading buffer pool dumps is not working for encrypted tablespaces

      		/* JAN: TODO: As we use background page read below,
      		if tablespace is encrypted we cant use it. */
      		if (space == NULL ||
      		   (space && space->crypt_data &&
      		    space->crypt_data->encryption != FIL_ENCRYPTION_OFF &&
      		    space->crypt_data->type != CRYPT_SCHEME_UNENCRYPTED)) {
      			continue;
      		}
      

      Attachments

        Issue Links

          Activity

            jplindst Jan Lindström (Inactive) created issue -

            I suspect that the code must have been a work-around for something that had been fixed in MDEV-12610.
            In MariaDB 10.2, fil_node_open_file() computes the local variable first_time_open and will read the encryption metadata when reading the first page for other reasons. In 10.1, the code looks a bit different, but I think that the logic should be compatible.

            marko Marko Mäkelä added a comment - I suspect that the code must have been a work-around for something that had been fixed in MDEV-12610 . In MariaDB 10.2, fil_node_open_file() computes the local variable first_time_open and will read the encryption metadata when reading the first page for other reasons. In 10.1, the code looks a bit different, but I think that the logic should be compatible.
            marko Marko Mäkelä made changes -
            Field Original Value New Value
            marko Marko Mäkelä made changes -
            Fix Version/s 10.2 [ 14601 ]
            Fix Version/s 10.3 [ 22126 ]
            Fix Version/s 10.4 [ 22408 ]
            Fix Version/s 10.5 [ 23123 ]
            Affects Version/s 10.2 [ 14601 ]
            Affects Version/s 10.3 [ 22126 ]
            Affects Version/s 10.4 [ 22408 ]
            Affects Version/s 10.5 [ 23123 ]
            julien.fritsch Julien Fritsch made changes -
            Fix Version/s 10.1 [ 16100 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 103908 ] MariaDB v4 [ 141783 ]
            jplindst Jan Lindström (Inactive) made changes -
            Assignee Jan Lindström [ jplindst ] Marko Mäkelä [ marko ]
            ralf.gebhardt Ralf Gebhardt made changes -
            Fix Version/s 10.2 [ 14601 ]
            julien.fritsch Julien Fritsch made changes -
            Fix Version/s 10.3 [ 22126 ]
            julien.fritsch Julien Fritsch made changes -
            Fix Version/s 10.4 [ 22408 ]

            People

              marko Marko Mäkelä
              jplindst Jan Lindström (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.