Details
-
Technical task
-
Status: Open (View Workflow)
-
Major
-
Resolution: Unresolved
-
10.3(EOL), 10.4(EOL), 10.5
-
None
-
None
Description
A simple comment in the Code using “--” gives error while compiling the procedure if it has no spaces after the comment character!
--CONFLICT KITCHEN
Works fine when changed to MariaDB standard single line comment “#”
#--CONFLICT KITCHEN
Or adding a space after the “--” also works
– CONFLICT KITCHEN
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Labels | Compatibility |
| Link | This issue relates to MENT-743 [ MENT-743 ] |
| Affects Version/s | 10.3 [ 22126 ] | |
| Affects Version/s | 10.4 [ 22408 ] | |
| Affects Version/s | 10.5 [ 23123 ] |
| Workflow | MariaDB v3 [ 98162 ] | MariaDB v4 [ 141398 ] |
| Zendesk Related Tickets | 148001 |
The problem is that SQL standard is --, not requireing a space before starting the comment. I suggest a SQL_MODE is used for this, enabled by default in SQL_MODE=Oracle. The default, without this enabled, would be to require a space for a comment.
I am not sure if this can be fixed as the – is ambiguous
For example, this is valid SQL:
SELECT 1--1;
This is same as 1 - (-1)
I think this is better to be changed in the application as SELECT 1 – 1 will work both for Oracle and MariaDB (adding space after--) and should be trivial to do.