Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-19162 Some basic datatypes and functions in oracle compatibility mode do not work
  3. MDEV-20036

sql_mode="oracle" A simple comment in the Code using “--” gives error

Details

    • Technical task
    • Status: Open (View Workflow)
    • Major
    • Resolution: Unresolved
    • 10.3(EOL), 10.4(EOL), 10.5
    • None
    • None

    Description

      A simple comment in the Code using “--” gives error while compiling the procedure if it has no spaces after the comment character!
      --CONFLICT KITCHEN
      Works fine when changed to MariaDB standard single line comment “#”
      #--CONFLICT KITCHEN
      Or adding a space after the “--” also works
      – CONFLICT KITCHEN

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          monty Michael Widenius added a comment - - edited

          I am not sure if this can be fixed as the – is ambiguous

          For example, this is valid SQL:

          SELECT 1--1;

          This is same as 1 - (-1)

          I think this is better to be changed in the application as SELECT 1 – 1 will work both for Oracle and MariaDB (adding space after--) and should be trivial to do.

          monty Michael Widenius added a comment - - edited I am not sure if this can be fixed as the – is ambiguous For example, this is valid SQL: SELECT 1--1; This is same as 1 - (-1) I think this is better to be changed in the application as SELECT 1 – 1 will work both for Oracle and MariaDB (adding space after--) and should be trivial to do.
          karlsson Anders Karlsson added a comment -

          The problem is that SQL standard is --, not requireing a space before starting the comment. I suggest a SQL_MODE is used for this, enabled by default in SQL_MODE=Oracle. The default, without this enabled, would be to require a space for a comment.

          karlsson Anders Karlsson added a comment - The problem is that SQL standard is --, not requireing a space before starting the comment. I suggest a SQL_MODE is used for this, enabled by default in SQL_MODE=Oracle. The default, without this enabled, would be to require a space for a comment.

          People

            Unassigned Unassigned
            Faisal Faisal Saeed (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.