Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-19917

Spider doesn't remove itself from mysql.plugin upon uninstallation

Details

    Description

      When mariadb-plugin-spider package is installed, it runs install_spider.sql script which installs two plugins into mysql.plugin. Apparently, there is no reverse operation, so when the package is uninstalled and the library is removed, orphan entries remain in mysql.plugin

      +------------------+--------------+
      | name             | dl           |
      +------------------+--------------+
      | spider           | ha_spider.so |
      | spider_alloc_mem | ha_spider.so |
      +------------------+--------------+
      

      Attachments

        Issue Links

          Activity

            anel Seems it worked

            ------------------------------------------------
            mariadb-plugin-spider
            drwxr-xr-x root/root ./  
            drwxr-xr-x root/root ./etc/  
            drwxr-xr-x root/root ./etc/mysql/  
            drwxr-xr-x root/root ./etc/mysql/mariadb.conf.d/  
            -rw-r--r-- root/root ./etc/mysql/mariadb.conf.d/spider.cnf  
            drwxr-xr-x root/root ./usr/  
            drwxr-xr-x root/root ./usr/lib/  
            drwxr-xr-x root/root ./usr/lib/mysql/  
            drwxr-xr-x root/root ./usr/lib/mysql/plugin/  
            -rw-r--r-- root/root ./usr/lib/mysql/plugin/ha_spider.so  
            drwxr-xr-x root/root ./usr/share/  
            drwxr-xr-x root/root ./usr/share/doc/  
            drwxr-xr-x root/root ./usr/share/doc/mariadb-plugin-spider/  
            -rw-r--r-- root/root ./usr/share/doc/mariadb-plugin-spider/changelog.gz  
            -rw-r--r-- root/root ./usr/share/doc/mariadb-plugin-spider/copyright  
            ------------------------------------------------
            

            When you test something yourself, just build, modify and re-build, it should not be complex.

            otto Otto Kekäläinen added a comment - anel Seems it worked ------------------------------------------------ mariadb-plugin-spider drwxr-xr-x root/root ./ drwxr-xr-x root/root ./etc/ drwxr-xr-x root/root ./etc/mysql/ drwxr-xr-x root/root ./etc/mysql/mariadb.conf.d/ -rw-r--r-- root/root ./etc/mysql/mariadb.conf.d/spider.cnf drwxr-xr-x root/root ./usr/ drwxr-xr-x root/root ./usr/lib/ drwxr-xr-x root/root ./usr/lib/mysql/ drwxr-xr-x root/root ./usr/lib/mysql/plugin/ -rw-r--r-- root/root ./usr/lib/mysql/plugin/ha_spider.so drwxr-xr-x root/root ./usr/share/ drwxr-xr-x root/root ./usr/share/doc/ drwxr-xr-x root/root ./usr/share/doc/mariadb-plugin-spider/ -rw-r--r-- root/root ./usr/share/doc/mariadb-plugin-spider/changelog.gz -rw-r--r-- root/root ./usr/share/doc/mariadb-plugin-spider/copyright ------------------------------------------------ When you test something yourself, just build, modify and re-build, it should not be complex.

            Fixing commit now included in PR at https://github.com/MariaDB/server/pull/1504/commits

            otto Otto Kekäläinen added a comment - Fixing commit now included in PR at https://github.com/MariaDB/server/pull/1504/commits

            Thanks Otto, after pushing #1504 I will close this MDEV.
            In meantime, can you show me your package-foo to get mariadb-plugin-spider as above.
            I suppose you are doing this with autobake and docker?

            anel Anel Husakovic added a comment - Thanks Otto, after pushing #1504 I will close this MDEV. In meantime, can you show me your package-foo to get mariadb-plugin-spider as above. I suppose you are doing this with autobake and docker?

            anel Simply run `debian/autobake-deb.sh` to run the build just like buildbot does. Study the source of that script to see what it does. At the end there is also the part that generates a list of all files in the completed *.deb files. You can also study the contents of debian/salsa-ci.yml to see the exact commands and steps (it's basically just shell script) that the Salsa-CI system runs to build and test packages. All of that can be just copy pasted into a local environment, Docker, Vagrant or whatever you want to use.

            otto Otto Kekäläinen added a comment - anel Simply run `debian/autobake-deb.sh` to run the build just like buildbot does. Study the source of that script to see what it does. At the end there is also the part that generates a list of all files in the completed *.deb files. You can also study the contents of debian/salsa-ci.yml to see the exact commands and steps (it's basically just shell script) that the Salsa-CI system runs to build and test packages. All of that can be just copy pasted into a local environment, Docker, Vagrant or whatever you want to use.

            Pushed on 10.5 with ba4148698fa648aaf15aa3.

            anel Anel Husakovic added a comment - Pushed on 10.5 with ba4148698fa648aaf15aa3 .

            People

              anel Anel Husakovic
              elenst Elena Stepanova
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.