Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-19768

Mariabackup should write warning during backup if server does not have innodb_log_optimize_ddl=OFF set

Details

    Description

      Some DDL statements can lead to inconsistent backups unless the server has innodb_log_optimize_ddl=OFF set. See MDEV-16791 for more information.

      https://mariadb.com/kb/en/library/mariabackup-overview/#concurrent-ddl-and-backup-issues

      https://mariadb.com/kb/en/library/innodb-system-variables/#innodb_log_optimize_ddl

      Maybe Mariabackup should write a warning if a backup is taken when innodb_log_optimize_ddl=OFF is not set? i.e. something like this?:

      [Warning] The server does not have innodb_log_optimize_ddl set to OFF. If certain DDL statements are executed during the backup, then the backup can be inconsistent.

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. MDEV-19769 Mariabackup should write warning during backup if server does not have innodb_safe_truncate=ON set

          • Major - Major loss of function.
          • Open

          Task - A task that needs to be done. MDEV-16791 mariabackup : allow consistent backup, in presence of concurrent DDL, also without --lock-ddl-per-table

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-19747 Deprecate and ignore innodb_log_optimize_ddl

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            GeoffMontee Geoff Montee (Inactive) created issue -
            GeoffMontee Geoff Montee (Inactive) made changes -
            Field Original Value New Value
            GeoffMontee Geoff Montee (Inactive) made changes -
            GeoffMontee Geoff Montee (Inactive) made changes -
            GeoffMontee Geoff Montee (Inactive) made changes -
            Component/s Data Definition - Alter Table [ 10114 ]
            julien.fritsch Julien Fritsch made changes -
            Assignee Vladislav Lesin [ vlad.lesin ] Marko Mäkelä [ marko ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 97530 ] MariaDB v4 [ 131103 ]
            marko Marko Mäkelä added a comment -

            I do not think that implementing the requested warning requires any specific InnoDB knowledge.

            marko Marko Mäkelä added a comment - I do not think that implementing the requested warning requires any specific InnoDB knowledge.
            marko Marko Mäkelä made changes -
            Assignee Marko Mäkelä [ marko ] Sergei Golubchik [ serg ]
            serg Sergei Golubchik made changes -
            Assignee Sergei Golubchik [ serg ] Alexander Barkov [ bar ]
            ralf.gebhardt Ralf Gebhardt made changes -
            Fix Version/s 10.2 [ 14601 ]
            ralf.gebhardt Ralf Gebhardt made changes -
            Labels warning
            ralf.gebhardt Ralf Gebhardt made changes -
            Fix Version/s 10.3 [ 22126 ]
            Fix Version/s 10.4 [ 22408 ]
            mariadb-jira-automation Jira Automation (IT) made changes -
            Zendesk Related Tickets 120084 121606

            People

              bar Alexander Barkov
              GeoffMontee Geoff Montee (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.