Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-19753

Remove support for Percona's "LOCK TABLES FOR BACKUP" and "LOCK BINLOG FOR BACKUP" statements and --no-backup-locks option from Mariabackup

    XMLWordPrintable

    Details

      Description

      It may be a good idea to remove support for Percona's "LOCK TABLES FOR BACKUP" and "LOCK BINLOG FOR BACKUP" statements and the --no-backup-locks option from Mariabackup, now that MariaDB has its own backup locks. This separate and unused backup lock implementation may be confusing to developers and users.

      See here:

      https://github.com/MariaDB/server/blob/mariadb-10.4.5/extra/mariabackup/backup_mysql.cc#L880

      https://github.com/MariaDB/server/blob/mariadb-10.4.5/extra/mariabackup/backup_mysql.cc#L924

      https://github.com/MariaDB/server/blob/mariadb-10.4.5/extra/mariabackup/backup_mysql.cc#L360

      https://github.com/MariaDB/server/blob/mariadb-10.4.5/extra/mariabackup/backup_mysql.cc#L388

        Attachments

          Issue Links

          is caused by

          Task - A task that needs to be done. MDEV-5336 Implement BACKUP STAGE for safe external backups

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Task - A task that needs to be done. MDEV-17308 BACKUP: mariabackup support

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          relates to

          Task - A task that needs to be done. MDEV-8436 Implement "Backup Locks" such as "LOCK TABLES FOR BACKUP" and "LOCK BINLOG FOR BACKUP"

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Task - A task that needs to be done. MDEV-12031 BACKUP LOCKS

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-14746 mariabackup doesn't read [mariabackup] option group in configuration file

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-18347 mariabackup doesn't read all server option groups from configuration files

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-18405 Add Mariabackup option to set gtid_slave_pos to original server's gtid_current_pos during prepare

          • Major - Major loss of function.
          • Stalled

          Bug - A problem which impairs or prevents the functions of the product. MDEV-18917 Don't create xtrabackup_binlog_pos_innodb with Mariabackup

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-18931 Rename Mariabackup's xtrabackup_* files to mariabackup_*

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. MDEV-18985 Remove support for XtraDB's changed page bitmap from Mariabackup in 10.2+

          • Major - Major loss of function.
          • Confirmed

          Task - A task that needs to be done. MDEV-19246 Change database and table used for Mariabackup's history

          • Major - Major loss of function.
          • Open

          Task - A task that needs to be done. MDEV-19264 Better support MariaDB GTID for Mariabackup's --slave-info option

          • Major - Major loss of function.
          • Open

          Task - A task that needs to be done. MDEV-20552 Remove innobackupex mode from Mariabackup

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. MDEV-20556 Remove references to "xtrabackup" and "innobackupex" executables in mariabackup option descriptions

          • Major - Major loss of function.
          • Open

            Activity

              People

              Assignee:
              vlad.lesin Vladislav Lesin
              Reporter:
              GeoffMontee Geoff Montee
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated: