Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-19753

Remove support for Percona's "LOCK TABLES FOR BACKUP" and "LOCK BINLOG FOR BACKUP" statements and --no-backup-locks option from Mariabackup

    Details

      Description

      It may be a good idea to remove support for Percona's "LOCK TABLES FOR BACKUP" and "LOCK BINLOG FOR BACKUP" statements and the --no-backup-locks option from Mariabackup, now that MariaDB has its own backup locks. This separate and unused backup lock implementation may be confusing to developers and users.

      See here:

      https://github.com/MariaDB/server/blob/mariadb-10.4.5/extra/mariabackup/backup_mysql.cc#L880

      https://github.com/MariaDB/server/blob/mariadb-10.4.5/extra/mariabackup/backup_mysql.cc#L924

      https://github.com/MariaDB/server/blob/mariadb-10.4.5/extra/mariabackup/backup_mysql.cc#L360

      https://github.com/MariaDB/server/blob/mariadb-10.4.5/extra/mariabackup/backup_mysql.cc#L388

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                vlad.lesin Vladislav Lesin
                Reporter:
                GeoffMontee Geoff Montee
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated: