Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-19531

Add colors to mtr

Details

    Description

      Auto detected colors for [ such ] things.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-20223 Add colors to mtr in case of STDIN

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            kevg Eugene Kosov (Inactive) created issue -
            kevg Eugene Kosov (Inactive) made changes -
            Field Original Value New Value
            Fix Version/s 10.1 [ 16100 ]
            Fix Version/s 10.2 [ 14601 ]
            Fix Version/s 10.3 [ 22126 ]
            Fix Version/s 10.4 [ 22408 ]
            Fix Version/s 10.5 [ 23123 ]
            kevg Eugene Kosov (Inactive) made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            kevg Eugene Kosov (Inactive) made changes -
            Assignee Eugene Kosov [ kevg ] Sergei Golubchik [ serg ]
            Status In Progress [ 3 ] In Review [ 10002 ]
            serg Sergei Golubchik made changes -
            Priority Major [ 3 ] Minor [ 4 ]
            serg Sergei Golubchik made changes -
            Assignee Sergei Golubchik [ serg ] Eugene Kosov [ kevg ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            kevg Eugene Kosov (Inactive) made changes -
            Summary Add --color option to mtr Add colors to mtr
            kevg Eugene Kosov (Inactive) made changes -
            Description Let passing test be green and failing be red. Options is OFF by default. Auto detected colors for {{[ such ]}} things.
            kevg Eugene Kosov (Inactive) added a comment -

            I changed my patch with yours. Buildbot seems to be fine: no colours in the output http://buildbot.askmonty.org/buildbot/builders/kvm-rpm-centos6-amd64/builds/14990/steps/mtr/logs/stdio

            How can I additionally help you with that patch?

            kevg Eugene Kosov (Inactive) added a comment - I changed my patch with yours. Buildbot seems to be fine: no colours in the output http://buildbot.askmonty.org/buildbot/builders/kvm-rpm-centos6-amd64/builds/14990/steps/mtr/logs/stdio How can I additionally help you with that patch?
            kevg Eugene Kosov (Inactive) made changes -
            Assignee Eugene Kosov [ kevg ] Sergei Golubchik [ serg ]
            Status Stalled [ 10000 ] In Review [ 10002 ]
            robertbindar Robert Bindar made changes -
            Assignee Sergei Golubchik [ serg ] Robert Bindar [ robertbindar ]
            robertbindar Robert Bindar added a comment -

            Hi kevg, is there any reason not to have this in 5.5 as well?

            robertbindar Robert Bindar added a comment - Hi kevg , is there any reason not to have this in 5.5 as well?
            kevg Eugene Kosov (Inactive) added a comment -

            Hi robertbindar As I know 5.5 is only for critical fixes. No other reasons.

            kevg Eugene Kosov (Inactive) added a comment - Hi robertbindar As I know 5.5 is only for critical fixes. No other reasons.
            robertbindar Robert Bindar added a comment -

            That's my understanding as well, but I see no reason not to have this nice feature in 5.5 as well given it doesn't affect the server itself directly. I will cherry-pick it to 5.5.

            robertbindar Robert Bindar added a comment - That's my understanding as well, but I see no reason not to have this nice feature in 5.5 as well given it doesn't affect the server itself directly. I will cherry-pick it to 5.5.
            robertbindar Robert Bindar made changes -
            Fix Version/s 5.5 [ 15800 ]
            robertbindar Robert Bindar made changes -
            Fix Version/s 5.5.65 [ 23402 ]
            Fix Version/s 10.2 [ 14601 ]
            Fix Version/s 5.5 [ 15800 ]
            Fix Version/s 10.1 [ 16100 ]
            Fix Version/s 10.3 [ 22126 ]
            Fix Version/s 10.4 [ 22408 ]
            Fix Version/s 10.5 [ 23123 ]
            Resolution Fixed [ 1 ]
            Status In Review [ 10002 ] Closed [ 6 ]
            anel Anel Husakovic made changes -
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 96838 ] MariaDB v4 [ 133958 ]

            People

              robertbindar Robert Bindar
              kevg Eugene Kosov (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.