Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-19210

use environment file in systemd units for _WSREP_*

Details

    Description

      We used to run systemctl set-environment to pass _WSREP_START_POSITION. This is bad because:

      • it clutter systemd's environment (yes, pid 1) - upsets some Debian people dbz 984996
      • it requires root privileges - hence it will fix MDEV-14707, as such it cases all ExecStartPre scripts to be run as root. PermissionsStartOnly was deprecated by systemd in 2018.
      • options (like LimitNOFILE=) are not applied to ExecStartPre scripts.

      The solution is:

      Let's just create an environment file in ExecStartPre=, that is read before ExecStart= kicks in. We have _WSREP_START_POSITION around for the main process without any downsides.

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. MDEV-14707 systemd: remove PermissionsStartOnly=true (by removing environment _WSREP_START_POSITION)

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-23110 Support for Galera Multi-Instance in systemd unit file

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. MDEV-29884 Ctrl-Cing out of galera_new_cluster doesn't reset systemd environment

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. MDEV-35904 Warnings about undefined variables with systemd starting with version v254

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Confirmed

          Activity

            Transition Time In Source Status Execution Times
            Andrew Hutchings (Inactive) made transition -
            Open Closed
            		1578d 7m 1
            Andrew Hutchings (Inactive) made transition -
            Closed Stalled
            		5d 20h 50m 1
            Daniel Black made transition -
            Stalled In Review
            		41d 13h 2m 1
            Daniel Black made transition -
            In Review In Testing
            		92d 5h 44m 1
            Daniel Black made transition -
            In Testing Stalled
            		124d 13m 1
            Andrew Hutchings (Inactive) made transition -
            Stalled Closed
            		37d 54m 1

            People

              danblack Daniel Black
              anel Anel Husakovic
              Votes:
              1 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.