Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-19015

mysql_plugin doesn't read all server option groups

Details

    Description

      The mysql_plugin utility doesn't read all server option groups from the configuration file. It only reads the [mysqld] option group. This is because it executes the following:

      my_print_defaults mysqld

      Instead of the following:

      my_print_defaults --mysqld

      See the following function:

      https://github.com/MariaDB/server/blob/3a7d7e180a871c5b2b2d98812d9d7f800cf33952/client/mysql_plugin.c#L314

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-19227 mysql_plugin doesn't run bootstrap from source

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          links to

          Web Link PR#1262

          Activity

            Ascending order - Click to sort in descending order
            View 6 older comments
            anel Anel Husakovic added a comment -

            links to

            anel Anel Husakovic added a comment - links to
            GeoffMontee Geoff Montee (Inactive) added a comment -

            Hi anel,

            Your PR is for MariaDB 10.2. A bug should be fixed in the earliest branch that we want the fix in. Don't you think that a bug this simple and easy to fix should be fixed in MariaDB 10.1 too? Or maybe even as far back as MariaDB 5.5?

            GeoffMontee Geoff Montee (Inactive) added a comment - Hi anel , Your PR is for MariaDB 10.2. A bug should be fixed in the earliest branch that we want the fix in. Don't you think that a bug this simple and easy to fix should be fixed in MariaDB 10.1 too? Or maybe even as far back as MariaDB 5.5?
            anel Anel Husakovic added a comment - - edited

            Isn't 10.1 getting close to the EOL ?
            That was the reason why I used 10.2 from combination of `10.1, 10.2, 10.3, 10.4` you wrote in MDEV.
            If needed ok, we can do that on 10.1, just let me know about question above.

            anel Anel Husakovic added a comment - - edited Isn't 10.1 getting close to the EOL ? That was the reason why I used 10.2 from combination of `10.1, 10.2, 10.3, 10.4` you wrote in MDEV. If needed ok, we can do that on 10.1, just let me know about question above.
            GeoffMontee Geoff Montee (Inactive) added a comment -

            Hi anel,

            See here:

            https://mariadb.org/about/maintenance-policy/

            MariaDB 10.1 doesn't reach EOL for another 1.5 years. You might be thinking of MariaDB 10.0. That reached EOL a couple weeks ago.

            GeoffMontee Geoff Montee (Inactive) added a comment - Hi anel , See here: https://mariadb.org/about/maintenance-policy/ MariaDB 10.1 doesn't reach EOL for another 1.5 years. You might be thinking of MariaDB 10.0. That reached EOL a couple weeks ago.
            anel Anel Husakovic added a comment -

            Hi GeoffMontee
            I updated PR to `10.1`.
            Thanks

            anel Anel Husakovic added a comment - Hi GeoffMontee I updated PR to `10.1`. Thanks

            People

              serg Sergei Golubchik
              GeoffMontee Geoff Montee (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.