Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-18841

Get rid of deprecated /var/run paths

Details

    • Bug
    • Status: Closed (View Workflow)
    • Minor
    • Resolution: Fixed
    • 5.5(EOL), 10.1(EOL), 10.2(EOL), 10.3(EOL), 10.4(EOL), 10.5
    • 10.5.4
    • None

    Description

      Probably in all distros "/var/run" was migrated to "/run" but you can still find remnants of "/var/run" paths in mariadb files:

      debian/mariadb-server-10.2.postinst
      58:    # This is needed because mysql_install_db removes the pid file in /var/run
      61:    # script fails. I can't tell at this point because of the cleaned /var/run.
      67:    mysql_rundir=/var/run/mysqld
       
      debian/mariadb-server-10.2.mysql.init
      111:    test -e /var/run/mysqld || install -m 755 -o mysql -g root -d /var/run/mysqld
       
      debian/mariadb-server-10.2.logcheck.ignore.server
      2:/etc/init.d/mysql\[[0-9]+\]: Check that mysqld is running and that the socket: '/var/run/mysqld/mysqld.sock' exists\!$
       
      debian/mariadb-server-10.2.logcheck.ignore.paranoid
      1:/etc/init.d/mysql\[[0-9]+\]: Check that mysqld is running and that the socket: '/var/run/mysqld/mysqld.sock' exists\!$
      5:mysqld\[[0-9]+\]: Version: .* socket: '/var/run/mysqld/mysqld.sock'  port: 3306$
       
      debian/mariadb-server-10.2.logcheck.ignore.workstation
      2:/etc/init.d/mysql\[[0-9]+\]: Check that mysqld is running and that the socket: '/var/run/mysqld/mysqld.sock' exists\!$
       
      debian/additions/my.cnf
      20:socket		= /var/run/mysqld/mysqld.sock
      27:socket		= /var/run/mysqld/mysqld.sock
      35:pid-file	= /var/run/mysqld/mysqld.pid
      36:socket		= /var/run/mysqld/mysqld.sock
       
      debian/mariadb-server-10.2.postrm
      70:    rm -rf /var/run/mysqld # this directory is created by the init script, don't leave behind
       
      storage/maria/ma_test_force_start.pl
      57:my $server_pid_name="./var/run/master.pid";
       
      support-files/policy/apparmor/usr.sbin.mysqld
      57:  /var/run/mysqld/mysqld.pid w,
      58:  /var/run/mysqld/mysqld.sock w,
       
      libmariadb/.travis/build/Dockerfile
      66:    	&& rm -rf /var/lib/mysql && mkdir -p /var/lib/mysql /var/run/mysqld \
      67:    	&& chown -R mysql:mysql /var/lib/mysql /var/run/mysqld \
      68:    	&& chmod 777 /var/run/mysqld \
       
      cmake/systemd.cmake
      59:          SET(SYSTEMD_EXECSTARTPRE "ExecStartPre=/usr/bin/install -m 755 -o mysql -g root -d /var/run/mysqld")
       
      cmake/install_layout.cmake
      187:SET(INSTALL_UNIX_ADDRDIR_DEB            "/var/run/mysqld/mysqld.sock")
      

      It should be updated to "/run".

      Attachments

        Issue Links

          Activity

            kstreitova Kristyna Streitova created issue -
            kstreitova Kristyna Streitova made changes -
            Field Original Value New Value
            Description Probably in all distros "/var/run" was migrated to "/run" but you can still find remnants of "/var/run" paths in mariadb files:

            debian/mariadb-server-10.2.postinst
            58: # This is needed because mysql_install_db removes the pid file in /var/run
            61: # script fails. I can't tell at this point because of the cleaned /var/run.
            67: mysql_rundir=/var/run/mysqld

            debian/mariadb-server-10.2.mysql.init
            111: test -e /var/run/mysqld || install -m 755 -o mysql -g root -d /var/run/mysqld

            debian/mariadb-server-10.2.logcheck.ignore.server
            2:/etc/init.d/mysql\[[0-9]+\]: Check that mysqld is running and that the socket: '/var/run/mysqld/mysqld.sock' exists\!$

            debian/mariadb-server-10.2.logcheck.ignore.paranoid
            1:/etc/init.d/mysql\[[0-9]+\]: Check that mysqld is running and that the socket: '/var/run/mysqld/mysqld.sock' exists\!$
            5:mysqld\[[0-9]+\]: Version: .* socket: '/var/run/mysqld/mysqld.sock' port: 3306$

            debian/mariadb-server-10.2.logcheck.ignore.workstation
            2:/etc/init.d/mysql\[[0-9]+\]: Check that mysqld is running and that the socket: '/var/run/mysqld/mysqld.sock' exists\!$

            debian/additions/my.cnf
            20:socket = /var/run/mysqld/mysqld.sock
            27:socket = /var/run/mysqld/mysqld.sock
            35:pid-file = /var/run/mysqld/mysqld.pid
            36:socket = /var/run/mysqld/mysqld.sock

            debian/mariadb-server-10.2.postrm
            70: rm -rf /var/run/mysqld # this directory is created by the init script, don't leave behind

            storage/maria/ma_test_force_start.pl
            57:my $server_pid_name="./var/run/master.pid";

            support-files/policy/apparmor/usr.sbin.mysqld
            57: /var/run/mysqld/mysqld.pid w,
            58: /var/run/mysqld/mysqld.sock w,

            libmariadb/.travis/build/Dockerfile
            66: && rm -rf /var/lib/mysql && mkdir -p /var/lib/mysql /var/run/mysqld \
            67: && chown -R mysql:mysql /var/lib/mysql /var/run/mysqld \
            68: && chmod 777 /var/run/mysqld \

            cmake/systemd.cmake
            59: SET(SYSTEMD_EXECSTARTPRE "ExecStartPre=/usr/bin/install -m 755 -o mysql -g root -d /var/run/mysqld")

            cmake/install_layout.cmake
            187:SET(INSTALL_UNIX_ADDRDIR_DEB "/var/run/mysqld/mysqld.sock")


            It should be updated to "/run".
            Probably in all distros "/var/run" was migrated to "/run" but you can still find remnants of "/var/run" paths in mariadb files:

            {noformat}
            debian/mariadb-server-10.2.postinst
            58: # This is needed because mysql_install_db removes the pid file in /var/run
            61: # script fails. I can't tell at this point because of the cleaned /var/run.
            67: mysql_rundir=/var/run/mysqld

            debian/mariadb-server-10.2.mysql.init
            111: test -e /var/run/mysqld || install -m 755 -o mysql -g root -d /var/run/mysqld

            debian/mariadb-server-10.2.logcheck.ignore.server
            2:/etc/init.d/mysql\[[0-9]+\]: Check that mysqld is running and that the socket: '/var/run/mysqld/mysqld.sock' exists\!$

            debian/mariadb-server-10.2.logcheck.ignore.paranoid
            1:/etc/init.d/mysql\[[0-9]+\]: Check that mysqld is running and that the socket: '/var/run/mysqld/mysqld.sock' exists\!$
            5:mysqld\[[0-9]+\]: Version: .* socket: '/var/run/mysqld/mysqld.sock' port: 3306$

            debian/mariadb-server-10.2.logcheck.ignore.workstation
            2:/etc/init.d/mysql\[[0-9]+\]: Check that mysqld is running and that the socket: '/var/run/mysqld/mysqld.sock' exists\!$

            debian/additions/my.cnf
            20:socket = /var/run/mysqld/mysqld.sock
            27:socket = /var/run/mysqld/mysqld.sock
            35:pid-file = /var/run/mysqld/mysqld.pid
            36:socket = /var/run/mysqld/mysqld.sock

            debian/mariadb-server-10.2.postrm
            70: rm -rf /var/run/mysqld # this directory is created by the init script, don't leave behind

            storage/maria/ma_test_force_start.pl
            57:my $server_pid_name="./var/run/master.pid";

            support-files/policy/apparmor/usr.sbin.mysqld
            57: /var/run/mysqld/mysqld.pid w,
            58: /var/run/mysqld/mysqld.sock w,

            libmariadb/.travis/build/Dockerfile
            66: && rm -rf /var/lib/mysql && mkdir -p /var/lib/mysql /var/run/mysqld \
            67: && chown -R mysql:mysql /var/lib/mysql /var/run/mysqld \
            68: && chmod 777 /var/run/mysqld \

            cmake/systemd.cmake
            59: SET(SYSTEMD_EXECSTARTPRE "ExecStartPre=/usr/bin/install -m 755 -o mysql -g root -d /var/run/mysqld")

            cmake/install_layout.cmake
            187:SET(INSTALL_UNIX_ADDRDIR_DEB "/var/run/mysqld/mysqld.sock")
            {noformat}


            It should be updated to "/run".
            elenst Elena Stepanova made changes -
            Assignee Sergei Golubchik [ serg ]
            elenst Elena Stepanova made changes -
            Fix Version/s 10.2 [ 14601 ]
            serg Sergei Golubchik made changes -
            Priority Major [ 3 ] Minor [ 4 ]
            serg Sergei Golubchik made changes -
            Affects Version/s 5.5 [ 15800 ]
            Affects Version/s 10.1 [ 16100 ]
            Affects Version/s 10.3 [ 22126 ]
            Affects Version/s 10.4 [ 22408 ]
            Affects Version/s 10.5 [ 23123 ]
            serg Sergei Golubchik made changes -
            Fix Version/s 10.3 [ 22126 ]
            Fix Version/s 10.4 [ 22408 ]
            Fix Version/s 10.5 [ 23123 ]
            danblack Daniel Black made changes -
            Component/s Packaging [ 10700 ]
            Component/s Scripts & Clients [ 11002 ]
            Fix Version/s 10.5.4 [ 24264 ]
            Fix Version/s 10.2 [ 14601 ]
            Fix Version/s 10.3 [ 22126 ]
            Fix Version/s 10.4 [ 22408 ]
            Fix Version/s 10.5 [ 23123 ]
            Assignee Sergei Golubchik [ serg ] Daniel Black [ danblack ]
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Closed [ 6 ]
            danblack Daniel Black made changes -
            DBrunner Jim Dutton made changes -
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 93007 ] MariaDB v4 [ 155865 ]

            People

              danblack Daniel Black
              kstreitova Kristyna Streitova
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.