Sergei Golubchik added a comment - 2024-10-09 12:38 cc59fbfffa63 is ok to push. 236cdc78f5cd is ok, after changing "is not used for" to "is not applicable to"

Oleksandr Byelkin added a comment - 2024-10-04 07:29 - edited commit 58aa409f161e0899930054f040d19c42a933eceb (HEAD -> bb-10.5-MDEV-18151, origin/bb-10.5-MDEV-18151) Author: Oleksandr Byelkin <sanja@mariadb.com> Date: Fri Oct 4 10:15:35 2024 +0200   MDEV-18151 Skipped error returning for GRANT/SET PASSWORD Make message of error not warning.   commit e2f7e256e049b83c336b289d903e9749b1b1abe4 Author: Oleksandr Byelkin <sanja@mariadb.com> Date: Fri Oct 4 10:13:10 2024 +0200   fix grant5 test to return to the original database.   commit 778c67f7af0fc65bed94c9a03c1f07e91e6ecc7a Author: Oleksandr Byelkin <sanja@mariadb.com> Date: Fri Oct 4 09:28:46 2024 +0200   MDEV-18151 Skipped error returning for GRANT/SET PASSWORD Make error issueing for GRANT and SET PASSWORD the same. Report errors wich were skipped before.

Oleksandr Byelkin added a comment - 2024-10-02 11:16 - edited Also there is mentioning in the docs https://mariadb.com/kb/en/set-password/ so it should produse warning about using with plugin not required password 1. It does not and was not from very beginning (even reflected in the tests plugin_auth.test): --echo ## test SET PASSWORD #--error ER_SET_PASSWORD_AUTH_PLUGIN SET PASSWORD = PASSWORD('plug_dest'); (notice commented out error) 2. if warning return something should be done (password changed) if nothing is done error should be returned

Oleksandr Byelkin added a comment - 2024-10-02 10:53 But the warning still make harm: install soname 'auth_0x0100'; CREATE USER foo@localhost IDENTIFIED VIA auth_0x0100; uninstall plugin auth_0x0100;   select Priv from mysql.global_priv where User = "foo" and host="localhost" into @priv; SET PASSWORD FOR foo@localhost = "1111"; select Priv = @priv from mysql.global_priv where User = "foo" and host="localhost"; result in warning but not changing the password CREATE USER foo@localhost; GRANT FILE ON *.* TO foo@localhost IDENTIFIED VIA not_installed_plugin; ERROR HY000: Plugin 'not_installed_plugin' is not loaded DROP USER foo@localhost; CREATE USER foo@localhost IDENTIFIED VIA not_installed_plugin; ERROR HY000: Plugin 'not_installed_plugin' is not loaded install soname 'auth_0x0100'; CREATE USER foo@localhost IDENTIFIED VIA auth_0x0100; uninstall plugin auth_0x0100; select Priv from mysql.global_priv where User = "foo" and host="localhost" into @priv; Warnings: Warning 1287 '<select expression> INTO <destination>;' is deprecated and will be removed in a future release. Please use 'SELECT <select list> INTO <destination> FROM...' instead SET PASSWORD FOR foo@localhost = "1111"; Warnings: Warning 1524 Plugin 'auth_0x0100' is not loaded select Priv = @priv from mysql.global_priv where User = "foo" and host="localhost"; Priv = @priv 1 DROP USER foo@localhost;

Oleksandr Byelkin added a comment - 2024-10-02 08:20 The Original bug probably fixed by MDEV-11340 , where plugin checked before set_user_auth call and error returned (instead of warning in set_user_auth)