Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-17906

Class Binary_string

Details

    Description

      During a review for MDEV-13995 Sanja suggested to have a separate class as an output parameter for val_raw_xxx(), e.g.:

      bool val_raw_native(THD *thd, Raw *to);

      instead of:

      bool val_raw_native(THD *thd, String *to);

      Passing a String looks redundant, as val_raw_xxx() does not need a character set.

      Under terms of this task we'll:

      • Extract the character-set-unaware part of String into a new class Binary_string
      • Derive String from Binary_string and Charset

      Then, while cleaning up the patch for MDEV-13995, we'll introduce a new class Raw and also derive it from Binary_string.

      Attachments

        Issue Links

          blocks

          Bug - A problem which impairs or prevents the functions of the product. MDEV-13995 MAX(timestamp) returns a wrong result near DST change

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          is blocked by

          Task - A task that needs to be done. MDEV-17907 Class Static_binary_string

          • Major - Major loss of function.
          • Closed
          relates to

          Task - A task that needs to be done. MDEV-7063 Split String into logical components

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Stalled

          Activity

            Ascending order - Click to sort in descending order
            bar Alexander Barkov created issue -
            bar Alexander Barkov made changes -
            Field Original Value New Value
            bar Alexander Barkov made changes -
            bar Alexander Barkov made changes -
            bar Alexander Barkov made changes -
            issue.field.resolutiondate 2018-12-05 16:09:03.0 2018-12-05 16:09:03.475
            bar Alexander Barkov made changes -
            Fix Version/s 10.4.1 [ 23228 ]
            Fix Version/s 10.4 [ 22408 ]
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 91051 ] MariaDB v4 [ 133781 ]

            People

              bar Alexander Barkov
              bar Alexander Barkov
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.