Type:
Bug
Priority:
Major
Resolution:
Fixed
Affects Version/s:
5.5(EOL) , 10.0(EOL) , 10.1(EOL) , 10.2(EOL) , 10.3(EOL) , 10.4(EOL)
Exaple UB:
#define sint2korr(A) (int16) (*((int16 *) (A)))
(int16*) casts uchar* to a bigger aligned which is UB. There is not knows observable harm but this stuff makes A LOT of noise for UBSAN builds. This reason is alone enough to fix it.
One way to fix it is by using memcpy() . GCC, Clang and MSVC optimizes it away in release builds.
There is also a room for micro optimizations while preserving correctness. Here is an example from marko and me:
#define saint3korr(A) ((int32)((char)(A[2]) << 16 | (int32)(uchar)A[1] << 8 | (int32)(uchar)A[0]))
Probably it's also a good idea to replace macros with functions. This will bring a bit of type safety and will allow to put breakpoints on these functions.
{"report":{"fcp":1071.7000000476837,"ttfb":174.90000009536743,"pageVisibility":"visible","entityId":70800,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"d46ed9cb-506e-4cf5-990e-27dbcccd144f","navigationType":0,"readyForUser":1124.3000001907349,"redirectCount":0,"resourceLoadedEnd":1363.6000001430511,"resourceLoadedStart":182.40000009536743,"resourceTiming":[{"duration":174.70000004768372,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":182.40000009536743,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":182.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":357.10000014305115,"responseStart":0,"secureConnectionStart":0},{"duration":254.59999990463257,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":192.30000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":192.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":446.90000009536743,"responseStart":0,"secureConnectionStart":0},{"duration":447.2000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/fbf975c0cce4b1abf04784eeae9ba1f4-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":192.5,"connectEnd":192.5,"connectStart":192.5,"domainLookupEnd":192.5,"domainLookupStart":192.5,"fetchStart":192.5,"redirectEnd":0,"redirectStart":0,"requestStart":192.5,"responseEnd":639.7000000476837,"responseStart":639.7000000476837,"secureConnectionStart":192.5},{"duration":502.7999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/099b33461394b8015fc36c0a4b96e19f-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":192.80000019073486,"connectEnd":192.80000019073486,"connectStart":192.80000019073486,"domainLookupEnd":192.80000019073486,"domainLookupStart":192.80000019073486,"fetchStart":192.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":192.80000019073486,"responseEnd":695.6000001430511,"responseStart":695.6000001430511,"secureConnectionStart":192.80000019073486},{"duration":506.10000014305115,"initiatorType":"script","name":"https://jira.mariadb.org/s/94c15bff32baef80f4096a08aceae8bc-CDN/lu2bu7/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":193,"connectEnd":193,"connectStart":193,"domainLookupEnd":193,"domainLookupStart":193,"fetchStart":193,"redirectEnd":0,"redirectStart":0,"requestStart":193,"responseEnd":699.1000001430511,"responseStart":699.1000001430511,"secureConnectionStart":193},{"duration":506.39999985694885,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":193.10000014305115,"connectEnd":193.10000014305115,"connectStart":193.10000014305115,"domainLookupEnd":193.10000014305115,"domainLookupStart":193.10000014305115,"fetchStart":193.10000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":193.10000014305115,"responseEnd":699.5,"responseStart":699.5,"secureConnectionStart":193.10000014305115},{"duration":506.7999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":193.20000004768372,"connectEnd":193.20000004768372,"connectStart":193.20000004768372,"domainLookupEnd":193.20000004768372,"domainLookupStart":193.20000004768372,"fetchStart":193.20000004768372,"redirectEnd":0,"redirectStart":0,"requestStart":193.20000004768372,"responseEnd":700,"responseStart":700,"secureConnectionStart":193.20000004768372},{"duration":507.19999980926514,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bu7/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":193.30000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":193.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":700.5,"responseStart":0,"secureConnectionStart":0},{"duration":507,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":193.40000009536743,"connectEnd":193.40000009536743,"connectStart":193.40000009536743,"domainLookupEnd":193.40000009536743,"domainLookupStart":193.40000009536743,"fetchStart":193.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":193.40000009536743,"responseEnd":700.4000000953674,"responseStart":700.4000000953674,"secureConnectionStart":193.40000009536743},{"duration":507.30000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":193.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":193.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":700.8000001907349,"responseStart":0,"secureConnectionStart":0},{"duration":507.2999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/3339d87fa2538a859872f2df449bf8d0-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":193.60000014305115,"connectEnd":193.60000014305115,"connectStart":193.60000014305115,"domainLookupEnd":193.60000014305115,"domainLookupStart":193.60000014305115,"fetchStart":193.60000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":193.60000014305115,"responseEnd":700.9000000953674,"responseStart":700.9000000953674,"secureConnectionStart":193.60000014305115},{"duration":863.3999998569489,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":209.10000014305115,"connectEnd":209.10000014305115,"connectStart":209.10000014305115,"domainLookupEnd":209.10000014305115,"domainLookupStart":209.10000014305115,"fetchStart":209.10000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":209.10000014305115,"responseEnd":1072.5,"responseStart":1072.5,"secureConnectionStart":209.10000014305115},{"duration":1143.2000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":220.40000009536743,"connectEnd":220.40000009536743,"connectStart":220.40000009536743,"domainLookupEnd":220.40000009536743,"domainLookupStart":220.40000009536743,"fetchStart":220.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":220.40000009536743,"responseEnd":1363.6000001430511,"responseStart":1363.6000001430511,"secureConnectionStart":220.40000009536743},{"duration":485.2999999523163,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":871.8000001907349,"connectEnd":871.8000001907349,"connectStart":871.8000001907349,"domainLookupEnd":871.8000001907349,"domainLookupStart":871.8000001907349,"fetchStart":871.8000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":871.8000001907349,"responseEnd":1357.1000001430511,"responseStart":1357.1000001430511,"secureConnectionStart":871.8000001907349}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":14,"responseStart":175,"responseEnd":220,"domLoading":181,"domInteractive":1379,"domContentLoadedEventStart":1379,"domContentLoadedEventEnd":1413,"domComplete":2125,"loadEventStart":2125,"loadEventEnd":2127,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1366.9000000953674},{"name":"bigPipe.sidebar-id.end","time":1367.8000001907349},{"name":"bigPipe.activity-panel-pipe-id.start","time":1368},{"name":"bigPipe.activity-panel-pipe-id.end","time":1370.4000000953674},{"name":"activityTabFullyLoaded","time":1420.6000001430511}],"measures":[],"correlationId":"22ce9ca30a614a","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":96,"dbReadsTimeInMs":11,"dbConnsTimeInMs":19,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}